From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEDAFC4320A for ; Mon, 2 Aug 2021 21:22:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEB606023F for ; Mon, 2 Aug 2021 21:22:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232803AbhHBVWg (ORCPT ); Mon, 2 Aug 2021 17:22:36 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:56285 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232387AbhHBVWd (ORCPT ); Mon, 2 Aug 2021 17:22:33 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 3AE0DD1F9E; Mon, 2 Aug 2021 17:22:21 -0400 (EDT) (envelope-from nico@fluxnic.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=date:from :to:cc:subject:in-reply-to:message-id:references:mime-version :content-type; s=sasl; bh=CRe+PDqlDBc1oefWEPXwlMOMctNURIEIHe/d9Q t60Zw=; b=m56WwsFDwPpRT2I7QecE9QLtZve1ynAPPvMtr86IMieAQ0k64QIjcG ere3sLLtO6zvM5XKKEBpLA8U5yOsgOFdCEFYNjnjyv6YFtjUzpti+ITFKrna8M+t hD4UfkW89CoeS57/fwcMo5aLVf0BKL2f6JdTGHEv5wnY7sE4HMEuA= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 306C3D1F9D; Mon, 2 Aug 2021 17:22:21 -0400 (EDT) (envelope-from nico@fluxnic.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=fluxnic.net; h=date:from:to:cc:subject:in-reply-to:message-id:references:mime-version:content-type; s=2016-12.pbsmtp; bh=CRe+PDqlDBc1oefWEPXwlMOMctNURIEIHe/d9Qt60Zw=; b=ieIfu5e1D8DeXYWVBpJ3d47r+18sJuZPvVsfKLoBGLvrJ7QCly8af887QGWpjGtlqC2Q0DlUCVdRiqDh8fGFYNz0LDeMezu17uoVXLzjP4HiDrUKICoTGn66qmkxcr5UFcacvfUy/fmF4pjGlREKRXTM4p+y0kPcXqu/WWCbsDM= Received: from yoda.home (unknown [96.21.170.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 55557D1F9C; Mon, 2 Aug 2021 17:22:20 -0400 (EDT) (envelope-from nico@fluxnic.net) Received: from xanadu.home (xanadu.home [192.168.2.2]) by yoda.home (Postfix) with ESMTPSA id ED3792DA09B9; Mon, 2 Aug 2021 17:22:18 -0400 (EDT) Date: Mon, 2 Aug 2021 17:22:18 -0400 (EDT) From: Nicolas Pitre To: Arnd Bergmann cc: "Keller, Jacob E" , Richard Cochran , "Brandeburg, Jesse" , "Nguyen, Anthony L" , "David S. Miller" , Jakub Kicinski , Arnd Bergmann , Kurt Kanzenbach , "Saleem, Shiraz" , "Ertman, David M" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies In-Reply-To: Message-ID: <7q2p5954-3062-po4-ps5r-9n30n5663ns3@syhkavp.arg> References: <20210802145937.1155571-1-arnd@kernel.org> <20210802164907.GA9832@hoboy.vegasvil.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Pobox-Relay-ID: B87DEF62-F3D7-11EB-A6DA-FD8818BA3BAF-78420484!pb-smtp2.pobox.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Aug 2021, Arnd Bergmann wrote: > On Mon, Aug 2, 2021 at 10:46 PM Keller, Jacob E > wrote: > > > > You can do something like it for a particular symbol though, such as > > > > > > config MAY_USE_PTP_1588_CLOCK > > > def_tristate PTP_1588_CLOCK || !PTP_1588_CLOCK > > > > > > config E1000E > > > tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support" > > > depends on PCI && (!SPARC32 || BROKEN) > > > + depends on MAY_USE_PTP_1588_CLOCK > > > select CRC32 > > > - imply PTP_1588_CLOCK > > > > What about "integrates"? > > Maybe, we'd need to look at whether that fits for the other users of the > "A || !A" trick. I implemented "conditional dependencies" at the time, which is syntactic sugar to express the above as: depends on A if A != n depends on A if A etc. http://lkml.iu.edu/hypermail/linux/kernel/2004.2/09783.html But Masahiro shut it down. Nicolas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Pitre Date: Mon, 2 Aug 2021 17:22:18 -0400 (EDT) Subject: [Intel-wired-lan] [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies In-Reply-To: References: <20210802145937.1155571-1-arnd@kernel.org> <20210802164907.GA9832@hoboy.vegasvil.org> Message-ID: <7q2p5954-3062-po4-ps5r-9n30n5663ns3@syhkavp.arg> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Mon, 2 Aug 2021, Arnd Bergmann wrote: > On Mon, Aug 2, 2021 at 10:46 PM Keller, Jacob E > wrote: > > > > You can do something like it for a particular symbol though, such as > > > > > > config MAY_USE_PTP_1588_CLOCK > > > def_tristate PTP_1588_CLOCK || !PTP_1588_CLOCK > > > > > > config E1000E > > > tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support" > > > depends on PCI && (!SPARC32 || BROKEN) > > > + depends on MAY_USE_PTP_1588_CLOCK > > > select CRC32 > > > - imply PTP_1588_CLOCK > > > > What about "integrates"? > > Maybe, we'd need to look at whether that fits for the other users of the > "A || !A" trick. I implemented "conditional dependencies" at the time, which is syntactic sugar to express the above as: depends on A if A != n depends on A if A etc. http://lkml.iu.edu/hypermail/linux/kernel/2004.2/09783.html But Masahiro shut it down. Nicolas