All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ron Panduwana <panduwana@gmail.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
	Lee Marlow <lee.marlow@gmail.com>,
	Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH v2] Make use of git status when autocompleting git add, rm, checkout --, and reset HEAD
Date: Tue, 30 Aug 2011 16:14:56 -0700	[thread overview]
Message-ID: <7v1uw21ogf.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1314740583-14567-1-git-send-email-panduwana@gmail.com> (Ron Panduwana's message of "Wed, 31 Aug 2011 04:43:03 +0700")

Ron Panduwana <panduwana@gmail.com> writes:

> Signed-off-by: Ron Panduwana <panduwana@gmail.com>

"Make use of" is something anybody can read from the patch. What we need
from the proposed commit log message above S-o-b: line is to justify why
it is a good change. Does it make the code simpler to follow by making it
shorter? Does it make it faster to complete, and if so by how much faster?
Does it make it easier to use by not including paths that it used to show,
and if so what are the differences the end users would see, and why is it
justified to omit these paths from the candidate set?

  reply	other threads:[~2011-08-30 23:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30 21:43 [PATCH v2] Make use of git status when autocompleting git add, rm, checkout --, and reset HEAD Ron Panduwana
2011-08-30 23:14 ` Junio C Hamano [this message]
2011-09-06 17:43 ` SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1uw21ogf.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=lee.marlow@gmail.com \
    --cc=panduwana@gmail.com \
    --cc=spearce@spearce.org \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.