From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org, "Yann Dirson" <ydirson@altern.org>,
"Michael Witten" <mfwitten@MIT.EDU>,
"Ryan Anderson" <ryan@michonline.com>,
"Michael Witten" <mfwitten@gmail.com>,
"Adam Roben" <aroben@apple.com>
Subject: Re: [PATCH] send-email: make annotate configurable
Date: Wed, 11 Apr 2012 08:46:34 -0700 [thread overview]
Message-ID: <7v62d6nued.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <vpqaa2i61ty.fsf@bauges.imag.fr> (Matthieu Moy's message of "Wed, 11 Apr 2012 11:43:21 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> I do not doubt the usefulness of it, but if there is no --no-annotate, it
>>> would make the new variable unusable for those who would never run it
>>> without --annotate option
>>
>> Sorry; I meant to say "for those who mostly but not always run it with
>> the --annotate option".
>
> Actually, I guess you also meant "and who sometimes use older versions
> of Git", since the --no-annotate is there for people who always use the
> new version.
Not really. I didn't even have that in mind, and I agree with below.
> I don't think we can do anything for it. Any patch that introduces a new
> command-line option has the same issue. The only solution is on the user
> side: use only features that work for all versions of Git you use. In
> this case, it means "wait for all your machines to upgrade Git before
> setting sendemail.annotate".
And for that to work well, it is most sensible for the version that
introduces the configuration variable to make sure that the --no-annotate
command line override also is there, as the override becomes even more
necessary because of the configuration variable.
prev parent reply other threads:[~2012-04-11 15:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-07 0:29 [PATCH] send-email: make annotate configurable Felipe Contreras
2012-04-07 5:00 ` Junio C Hamano
2012-04-07 10:34 ` Matthieu Moy
2012-04-09 18:07 ` Junio C Hamano
2012-04-09 20:03 ` Junio C Hamano
2012-04-11 9:43 ` Matthieu Moy
2012-04-11 15:46 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v62d6nued.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=aroben@apple.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=mfwitten@MIT.EDU \
--cc=mfwitten@gmail.com \
--cc=ryan@michonline.com \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.