All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Nelson Elhage <nelhage@MIT.EDU>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Feb 2010, #06; Tue, 23)
Date: Wed, 24 Feb 2010 15:42:28 -0800	[thread overview]
Message-ID: <7v635m6w0r.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1002241004010.1946@xanadu.home> (Nicolas Pitre's message of "Wed\, 24 Feb 2010 10\:09\:53 -0500 \(EST\)")

Nicolas Pitre <nico@fluxnic.net> writes:

> On Tue, 23 Feb 2010, Junio C Hamano wrote:
>
>> * ne/pack-local-doc (2010-02-18) 1 commit
>>  - Documentation: pack-objects: Clarify --local's semantics.
>> 
>> Comments from pack experts?
>
> The patch is fine in the sense that what it modifies was indeed wrong.
>
> However the "even if it appears in the standard input" formulation 
> should also be fixed as the object list may be specified with a rev spec 
> on the command line, and not necessarily only via standard input.

Ah, true.  Perhaps something like this.

-- >8 --
Subject: pack-objects documentation: reword "objects that appear in the standard input"

These were written back when we always read objects from the standard
input.  These days --revs and its friends can feed only the start and
end points and have the command internally enumerate the objects.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 Documentation/git-pack-objects.txt |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/git-pack-objects.txt b/Documentation/git-pack-objects.txt
index 769f1de..1deaa65 100644
--- a/Documentation/git-pack-objects.txt
+++ b/Documentation/git-pack-objects.txt
@@ -120,12 +120,12 @@ base-name::
 
 --incremental::
 	This flag causes an object already in a pack to be ignored
-	even if it appears in the standard input.
+	even if it would have otherwise been packed.
 
 --local::
 	This flag causes an object that is borrowed from an alternate
-	object store to be ignored even if it appears in the standard
-	input.
+	object store to be ignored even if it would have otherwise been
+	packed.
 
 --non-empty::
         Only create a packed archive if it would contain at

  reply	other threads:[~2010-02-24 23:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24  1:20 What's cooking in git.git (Feb 2010, #06; Tue, 23) Junio C Hamano
2010-02-24  2:06 ` Tay Ray Chuan
2010-02-24  6:28 ` Jeff King
2010-02-24 15:09 ` Nicolas Pitre
2010-02-24 23:42   ` Junio C Hamano [this message]
2010-02-25  0:11     ` Nelson Elhage
2010-02-25 21:39 ` Sverre Rabbelier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v635m6w0r.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=nelhage@MIT.EDU \
    --cc=nico@fluxnic.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.