All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Frank Lichtenheld <frank@lichtenheld.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Documentation: Replace @@GIT_VERSION@@ in documentation
Date: Sun, 25 Mar 2007 22:33:42 -0700	[thread overview]
Message-ID: <7v7it41scp.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <11748238102228-git-send-email-frank@lichtenheld.de> (Frank Lichtenheld's message of "Sun, 25 Mar 2007 13:56:49 +0200")

Frank Lichtenheld <frank@lichtenheld.de> writes:

>  %.html : %.txt
>  	$(ASCIIDOC) -b xhtml11 -d manpage -f asciidoc.conf $(ASCIIDOC_EXTRA) $<
> +	sed -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' $@ >$@+
> +	mv $@+ $@
>  
>  %.1 %.7 : %.xml
>  	xmlto -m callouts.xsl man $<
>  
>  %.xml : %.txt
>  	$(ASCIIDOC) -b docbook -d manpage -f asciidoc.conf $<
> +	sed -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' $@ >$@+
> +	mv $@+ $@
>  
>  user-manual.xml: user-manual.txt user-manual.conf
>  	$(ASCIIDOC) -b docbook -d book $<

Sorry, but these compositions are wrong, as the build procedure
can die after asciidoc finishes but before it manages to finish
sed/mv.  The next make invocation would not know that the
previous one did not complete and would assume that the build
product %.html or %.xml are up to date.

Ideally if we can persuade asciidoc to output to its stdout, we
could do this:

	rm -f $@+ $@
        $(ASCIIDOC) --to-stdout ... | sed -e $(script) >$@+
        mv $@+ $@

  parent reply	other threads:[~2007-03-26  5:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-23 18:54 [PATCH 1/2] Documentation: Allow @@GIT_VERSION@@ in asciidoc.conf Frank Lichtenheld
2007-03-23 18:54 ` [PATCH 2/2] Documentation: Add version information to man pages Frank Lichtenheld
2007-03-23 21:53 ` [PATCH 1/2] Documentation: Allow @@GIT_VERSION@@ in asciidoc.conf Junio C Hamano
2007-03-24 12:04   ` Frank Lichtenheld
2007-03-24 14:26     ` Brian Gernhardt
2007-03-24 21:33     ` Junio C Hamano
2007-03-25 11:56       ` [PATCH 1/2] Documentation: Replace @@GIT_VERSION@@ in documentation Frank Lichtenheld
2007-03-25 11:56         ` [PATCH 2/2] Documentation: Add version information to man pages Frank Lichtenheld
2007-03-27  6:55           ` Junio C Hamano
2007-03-26  5:33         ` Junio C Hamano [this message]
2007-03-26  5:45           ` [PATCH 1/2] Documentation: Replace @@GIT_VERSION@@ in documentation Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v7it41scp.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=frank@lichtenheld.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.