From: Junio C Hamano <gitster@pobox.com>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/6] more automation for cover letter generation
Date: Sat, 18 Apr 2009 11:31:31 -0700 [thread overview]
Message-ID: <7v8wlxx18c.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1240071381-25165-1-git-send-email-ft@bewatermyfriend.org
Frank Terbeck <ft@bewatermyfriend.org> writes:
> The following setup would suit me pretty well:
>
> [format]
> coverletter = true
> coveronepatch = false
Nobody wants a cover letter to a single patch, so a better way
would probably be:
'yes' means default behaviour, that is add cover letter for
multiple-patch series, non for a single patch;
'no' means no cover; and
'always' means a probably insane "cover even a single patch".
In any case, because this new feature is way too late to be in the
upcoming 1.6.3 release anyway, I think it is a saner approach to add a
command line option "--cover=yes" to "cover if multiple", "--cover=always"
to "cover even a single patch", and "--cover=no" to countermand a
configured "format.cover" the user may have in the configuration from the
command line.
> overwritecoverletter = false
I do not think it is particularly a good idea, and it is a good idea to
have it in the configuration.
- Why not protect the earlier patch output? People often tweak messages
(both above and below the three-dash lines) in them.
- Isn't this pretty much per invocation?
I can understand (I may not be enthused about it) a new --clobber={yes,no}
command line option to allow/forbid clobbering the existing files, and you
may want to add --clobber=patches to allow clobbering only the patches but
not cover (which I do not think makes much sense, though).
next prev parent reply other threads:[~2009-04-18 18:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 16:16 [PATCH 0/6] more automation for cover letter generation Frank Terbeck
2009-04-18 16:16 ` [PATCH 1/6] format-patch: add cover{letter,onepatch} options Frank Terbeck
2009-04-18 16:16 ` [PATCH 2/6] Add documentation for format-patch's --cover-one-patch Frank Terbeck
2009-04-18 16:16 ` [PATCH 3/6] Document format.coverletter and format.coveronepatch Frank Terbeck
2009-04-18 16:16 ` [PATCH 4/6] format-patch: introduce overwritecoverletter option Frank Terbeck
2009-04-18 16:16 ` [PATCH 5/6] Add documentation for --cover-overwrite Frank Terbeck
2009-04-18 16:16 ` [PATCH 6/6] Document format.overwritecoverletter Frank Terbeck
2009-04-18 18:31 ` Junio C Hamano [this message]
2009-05-04 9:58 ` [PATCH v2 0/4] more automation for cover letter generation Frank Terbeck
2009-05-04 9:58 ` [PATCH v2 1/4] Add format.coverletter option Frank Terbeck
2009-05-04 9:59 ` [PATCH v2 2/4] Add format.coverauto boolean Frank Terbeck
2009-05-04 18:39 ` Stephen Boyd
2009-05-04 21:41 ` Frank Terbeck
2009-05-04 23:20 ` Junio C Hamano
2009-05-05 8:49 ` Frank Terbeck
2009-05-05 10:41 ` Junio C Hamano
2009-05-05 13:29 ` Frank Terbeck
2009-05-05 15:23 ` Frank Terbeck
2009-05-04 9:59 ` [PATCH v2 3/4] Add tests for coverauto, coverletter and --cover-letter Frank Terbeck
2009-05-04 9:59 ` [PATCH v2 4/4] Documentation for format.coverletter " Frank Terbeck
2009-04-21 3:32 ` [PATCH 0/6] more automation for cover letter generation Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8wlxx18c.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=ft@bewatermyfriend.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.