All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Sam Vilain <sam.vilain@catalyst.net.nz>
Cc: Petr Baudis <pasky@suse.cz>, git@vger.kernel.org
Subject: Re: [PATCH] Fix cg-commit -p to not touch the working tree
Date: Sun, 11 Feb 2007 20:25:37 -0800	[thread overview]
Message-ID: <7v8xf4atoe.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070212031923.D20B913A382@magnus.utsl.gen.nz> (Sam Vilain's message of "Mon, 12 Feb 2007 16:14:31 +1300")

Sam Vilain <sam.vilain@catalyst.net.nz> writes:

> Previously, the working tree state was modified with `patch', which
> was a fragile operation.  Do everything with `git-apply --cached
> --index' instead.

I do not use Cogito so I do not know what behaviour is wanted
here, but '--cached --index' is same as saying just '--cached'
as far as I know.  It will patch against the index and should
not touch working tree.  If the original used 'patch' to apply,
I suspect it wanted to touch the working tree (and possibly, it
wanted to leave the index alone?), so --cached might be
completely wrong thing to use here?

  reply	other threads:[~2007-02-12  4:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-12  3:14 [PATCH] Fix cg-commit -p to not touch the working tree Sam Vilain
2007-02-12  4:25 ` Junio C Hamano [this message]
2007-02-12 20:22   ` Sam Vilain
2007-02-12 22:01     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8xf4atoe.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=pasky@suse.cz \
    --cc=sam.vilain@catalyst.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.