All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Jiang Xin <worldhello.net@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] i18n: mark OPTION_NUMBER (-NUM) for translation
Date: Wed, 06 Feb 2013 07:47:39 -0800	[thread overview]
Message-ID: <7va9rho350.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CACsJy8DcXuFqjBtufQq1-0Vm3H4uxs03Crx+akY-kbrVgY8vUw@mail.gmail.com> (Duy Nguyen's message of "Wed, 6 Feb 2013 17:45:41 +0700")

Duy Nguyen <pclouds@gmail.com> writes:

> How about utf8_fwprintf? wprintf() deals with wide characters and
> returns the number of wide characters, I think the name fits. And we
> could just drop utf8_ and use the existing name, because we don't use
> wchar_t* anyway.

Please, no.  That line of reasoning shows a horrible design taste
(or lack of taste).  "We don't use X right now" (or "We will promise
never to use X", for that matter) is never a good reason to abuse a
name that normal people would closely associate with X to something
that is completely different.  That leads to more confusion, not
less.

I guess utf8_fprintf() is not so bad after all.  fprintf() without
the utf8_ prefix is perfectly capable of showing a string encoded in
UTF-8, and anybody can correctly guess that the magic utf8_ prefix
would introduce (i.e. the difference between utf8_fprintf and
fprintf) can only be about the return value.  It can be reasonably
expected that everybody would then know that the display column
count can be the only sane return value that is different from what
fprintf() would return.

  reply	other threads:[~2013-02-06 15:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05  7:40 [PATCH] Get correct column with for options in command usage Jiang Xin
2013-02-05 12:15 ` Duy Nguyen
2013-02-05 12:18   ` Duy Nguyen
2013-02-05 16:09     ` Junio C Hamano
2013-02-05 16:16   ` [PATCH v2 1/2] " Jiang Xin
2013-02-05 16:16   ` [PATCH v2 2/2] i18n: mark OPTION_NUMBER (-NUM) for translation Jiang Xin
2013-02-05 17:07     ` Junio C Hamano
2013-02-06  0:15       ` Jiang Xin
2013-02-06  2:44         ` Junio C Hamano
2013-02-06  3:02           ` Jiang Xin
2013-02-06  4:35             ` Junio C Hamano
2013-02-06 10:45               ` Duy Nguyen
2013-02-06 15:47                 ` Junio C Hamano [this message]
2013-02-08  2:10                   ` [PATCH v4] Add utf8_fprintf helper which returns correct columns Jiang Xin
2013-02-08  6:03                     ` Torsten Bögershausen
2013-02-08  6:13                       ` Torsten Bögershausen
2013-02-08  7:20                       ` Jiang Xin
2013-02-08 16:19                         ` Torsten Bögershausen
2013-02-09  6:31                           ` [PATCH v5] Add utf8_fprintf helper that " Jiang Xin
2013-02-06  1:16       ` [PATCH v3] Add utf8_fprintf helper which " Jiang Xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7va9rho350.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.