All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matt Kraai <kraai@ftbfs.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: make feature_blame return a list
Date: Mon, 15 Dec 2008 21:38:55 -0800	[thread overview]
Message-ID: <7vabawu1ao.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081216024605.GA4529@ftbfs.org> (Matt Kraai's message of "Mon, 15 Dec 2008 18:46:05 -0800")

Matt Kraai <kraai@ftbfs.org> writes:

> If you'd like me to resubmit my second patch, I'm happy to do so.
> Just let me know whether you prefer the resulting function to wrap its
> return values in parentheses (as is currently done by feature_grep and
> feature_pickaxe) or not.

Sure, keeping what feature_grep does is just fine.

Thanks.

  reply	other threads:[~2008-12-16  5:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-15 14:51 [PATCH] gitweb: make feature_blame return a list Matt Kraai
2008-12-15 14:51 ` [PATCH] gitweb: unify boolean feature subroutines Matt Kraai
2008-12-15 22:21   ` Junio C Hamano
2008-12-15 22:20 ` [PATCH] gitweb: make feature_blame return a list Junio C Hamano
2008-12-15 22:52   ` Giuseppe Bilotta
2008-12-16  2:46   ` Matt Kraai
2008-12-16  5:38     ` Junio C Hamano [this message]
2008-12-16  6:16       ` [PATCH] gitweb: unify boolean feature subroutines Matt Kraai
2008-12-16  7:36         ` [PATCH] gitweb: pass the option name to the feature callback Matt Kraai
2008-12-16  9:03         ` [PATCH] gitweb: unify boolean feature subroutines Junio C Hamano
2008-12-16 14:23           ` Matt Kraai
2008-12-17  8:10             ` Petr Baudis
2008-12-17  8:20               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabawu1ao.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kraai@ftbfs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.