From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "Jonathan Nieder" <jrnieder@gmail.com>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Thomas Rast" <trast@student.ethz.ch>
Subject: Re: [RFC/PATCH v4 6/6] completion: add public _GIT_complete helper
Date: Mon, 07 May 2012 11:56:06 -0700 [thread overview]
Message-ID: <7vbolz6cs9.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1336353800-17323-7-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Mon, 7 May 2012 03:23:20 +0200")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> So that users can easily define aliases, such as:
>
> _GIT_complete gf git_fetch
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> contrib/completion/git-completion.bash | 10 +++++-----
> t/t9902-completion.sh | 9 ++++++++-
> 2 files changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 049110e..2b7ef02 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2678,6 +2678,7 @@ _gitk ()
>
> __git_func_wrap ()
> {
> + local cmd="${1#git_}" cmd_pos=1
> if [[ -n ${ZSH_VERSION-} ]]; then
> emulate -L bash
> setopt KSH_TYPESET
> @@ -2695,8 +2696,7 @@ __git_func_wrap ()
> _$1
> }
>
> -# this is NOT a public function; use at your own risk
> -__git_complete ()
> +_GIT_complete ()
If it is now a public function, please have some description as to how to
use it for people who find this in the tarball extract.
I am guessing that
_GIT_complete frotz git_fetch
is a way to declare that 'git frotz' wants the same kind of completion as
'git fetch' command, but I am not sure, as if it were the case it strikes
me somewhat odd that it is not "_GIT_complete frotz fetch".
next prev parent reply other threads:[~2012-05-07 18:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 1:23 [RFC/PATCH v4 0/6] completion: __git_complete and other stuff Felipe Contreras
2012-05-07 1:23 ` [RFC/PATCH v4 1/6] completion: add new __git_complete helper Felipe Contreras
2012-05-07 9:51 ` SZEDER Gábor
2012-05-07 18:51 ` Junio C Hamano
2012-05-07 20:53 ` Felipe Contreras
2012-05-07 1:23 ` [RFC/PATCH v4 2/6] tests: add more bash completion tests Felipe Contreras
2012-05-07 1:23 ` [RFC/PATCH v4 3/6] completion: simplify _git_bundle Felipe Contreras
2012-05-07 1:23 ` [RFC/PATCH v4 4/6] completion: simplify command stuff Felipe Contreras
2012-05-07 10:08 ` SZEDER Gábor
2012-05-07 1:23 ` [RFC/PATCH v4 5/6] completion: calculate argument position properly Felipe Contreras
2012-05-07 1:27 ` Felipe Contreras
2012-05-07 18:59 ` Junio C Hamano
2012-05-07 21:01 ` Felipe Contreras
2012-05-07 21:52 ` Junio C Hamano
2012-05-08 12:50 ` Felipe Contreras
2012-05-07 1:23 ` [RFC/PATCH v4 6/6] completion: add public _GIT_complete helper Felipe Contreras
2012-05-07 18:56 ` Junio C Hamano [this message]
2012-05-07 20:57 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbolz6cs9.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=szeder@ira.uka.de \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.