From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Thomas Rast <trast@student.ethz.ch>,
Pierre Habouzit <madcoder@debian.org>,
Pascal Obry <pascal@obry.net>, Jay Soffian <jaysoffian@gmail.com>,
David Brown <git@davidb.org>, Matthew Wilcox <matthew@wil.cx>,
"Robin H. Johnson" <robbat2@gentoo.org>
Subject: Re: [PATCH RESEND] send-email: add 'specify-author' option
Date: Fri, 06 Apr 2012 13:22:39 -0700 [thread overview]
Message-ID: <7vbon41ugg.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAMP44s1b=HfhPNkmiEjPnQpupd0FPBNgVyp5Sw=zFVTdqmJXEg@mail.gmail.com> (Felipe Contreras's message of "Fri, 6 Apr 2012 22:42:16 +0300")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> On Fri, Apr 6, 2012 at 8:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> Some mail servers (Microsoft Exchange) mangle the 'From' header, so
>>> while applying the patches, the author has to be fixed manually.
>> ...
>> I wouldn't say that the existing option names to send-email are great, but
>> I have to say that the one added by this is simply horrible ;-)
>>
>> The first paragraph of the proposed commit log message states the problem
>> it tries to address very clearly, which is good, but is "From: " the only
>> thing that needs this? I am wondering if this should be named and behave
>> more like "--duplicate-header" or "--in-body-header".
>
> I have never seen any other 'in-body-header' other than From, and I
> don't see how that would be useful. Anybody else?
The "Subject:" is very often used in the wild, when responding to an
existing discussion thread with a patch, without changing the topic of the
thread (I would say it is used more than "From: " override).
When using send-email to start a thread anew, this use case is much less
of a problem, but I wouldn't be surprised if a broken MSA/MTA mangled the
subject (especially imagine a non-ASCII ones) incorrectly which would be
helped with exactly the same in-body-header mechanism.
You probably meant "I do not want to hear from Junio" by your last
half-sentence, but I replied anyway ;-).
next prev parent reply other threads:[~2012-04-06 20:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 12:21 [PATCH RESEND] send-email: add 'specify-author' option Felipe Contreras
2012-04-06 12:32 ` Felipe Contreras
2012-04-06 17:14 ` Junio C Hamano
2012-04-06 19:42 ` Felipe Contreras
2012-04-06 20:22 ` Junio C Hamano [this message]
2012-04-06 21:48 ` Felipe Contreras
2012-04-06 22:30 ` Junio C Hamano
2012-04-07 11:46 ` Felipe Contreras
2012-04-08 4:45 ` Junio C Hamano
2012-04-12 15:59 ` Michael Witten
2012-04-12 15:41 ` Michael Witten
2012-04-12 17:40 ` Junio C Hamano
2012-04-06 19:47 ` Thomas Rast
2012-04-06 21:30 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbon41ugg.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@davidb.org \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
--cc=madcoder@debian.org \
--cc=matthew@wil.cx \
--cc=pascal@obry.net \
--cc=robbat2@gentoo.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.