From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Hermann Gausterer <git-mailinglist@mrq1.org>,
git list <git@vger.kernel.org>
Subject: Re: [PATCH] add-interactive: shortcut to add hunk and quit
Date: Mon, 16 May 2011 22:09:58 -0700 [thread overview]
Message-ID: <7vboz1j4k9.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <vpq4o4uwqin.fsf@bauges.imag.fr> (Matthieu Moy's message of "Mon, 16 May 2011 18:37:20 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Hermann Gausterer <git-mailinglist@mrq1.org> writes:
>
>> this combines the two commands "y"+"q" to one.
>> i use this if i know that this is the last hunk to add.
>
> (please capitalize the "I", and actually, avoid saying "I" in a commit
> message)
>
> I'm not convinced this is useful enough to deserve a new command. The
> help message already starts being scary ...
>
>> + Q - quit; stage this hunk but none of the remaining ones
>
> The explanation shouldn't start with "quit" I think. I'd say basically
> "stage this hunk and quit" or "stage this hunk but none of the remaining
> ones".
I agree with both points. Other than that, the changes in this round looks
good to me.
Hermann, care to re-roll for the last time?
next prev parent reply other threads:[~2011-05-17 5:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-15 12:55 [PATCH] add-interactive: shortcut for add hunk and quit Hermann Gausterer
2011-05-15 20:30 ` Junio C Hamano
2011-05-16 16:26 ` [PATCH] add-interactive: shortcut to " Hermann Gausterer
2011-05-16 16:37 ` Matthieu Moy
2011-05-17 5:09 ` Junio C Hamano [this message]
2011-05-17 7:12 ` Hermann Gausterer
2011-05-18 6:40 ` Pete Harlan
2011-05-18 6:45 ` Jeff King
2011-05-18 9:26 ` Michael J Gruber
2011-05-18 15:28 ` Junio C Hamano
2011-05-19 10:16 ` Thomas Rast
2011-05-19 11:02 ` Jeff King
2011-05-19 19:25 ` Junio C Hamano
2011-05-19 19:42 ` Jeff King
2011-05-18 8:43 ` Hermann Gausterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vboz1j4k9.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git-mailinglist@mrq1.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.