From: Junio C Hamano <gitster@pobox.com>
To: Mark Levedahl <mlevedahl@gmail.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
"Ramsay Jones" <ramsay@ramsay1.demon.co.uk>,
mhagger@alum.mit.edu, "Jeff King" <peff@peff.net>,
"Johannes Sixt" <j6t@kdbg.org>,
"Shawn O. Pearce" <spearce@spearce.org>,
dpotapov@gmail.com, "GIT Mailing-list" <git@vger.kernel.org>
Subject: Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions
Date: Thu, 18 Jul 2013 16:32:11 -0700 [thread overview]
Message-ID: <7vd2qf1m2s.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <51E86E02.4060208@gmail.com> (Mark Levedahl's message of "Thu, 18 Jul 2013 18:36:50 -0400")
Mark Levedahl <mlevedahl@gmail.com> writes:
> Unlike the results on the fast Win7 laptop, the above show
> statistically significant slow down from the fast_lstat approach. I'm
> just not seeing a case for the special case handling, and of course
> Junio has already voted with his preference of removing the special
> case stuff as well.
Please don't take what I said as any "vote" in this thread. I do
not have a first-hand data to back anything up.
I was primarily trying to see my understanding of the consensus of
the thread was correct. If we can do without s/lstat/fast_lstat/
almost everywhere in the codebase, of course, I would be happier, as
it would give us one less thing to worry about.
If the assumptions like "they were declining minority and only lose
population over time", "it is easy for them to revert the removal
and keep going", and "removal will not hurt them too much in the
first place, only a few hundred milliseconds", that might trump the
longer-term maintainability issue, and we may end up having to carry
that win32 stat implementation a bit longer until these users all
switch to Cygwin 1.7, but judging from the "cvs binary seems to be
built incorrectly" incident the other day, it might be the case some
users still hesitate to update, fearing that 1.7 series may not be
solid enough, perhaps?
next prev parent reply other threads:[~2013-07-18 23:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 20:23 [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions Ramsay Jones
2013-07-14 16:15 ` Mark Levedahl
2013-07-15 19:49 ` Junio C Hamano
2013-07-16 2:06 ` Torsten Bögershausen
2013-07-16 3:54 ` Mark Levedahl
2013-07-16 15:42 ` Dmitry Potapov
2013-07-16 22:52 ` Mark Levedahl
2013-07-18 17:50 ` Ramsay Jones
2013-07-18 21:49 ` Torsten Bögershausen
2013-07-18 22:36 ` Mark Levedahl
2013-07-18 23:32 ` Junio C Hamano [this message]
2013-07-19 15:34 ` Mark Levedahl
2013-07-16 3:44 ` Mark Levedahl
2013-07-16 21:36 ` Ramsay Jones
2013-07-16 23:13 ` Mark Levedahl
2013-07-18 17:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd2qf1m2s.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=mhagger@alum.mit.edu \
--cc=mlevedahl@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=spearce@spearce.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.