From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 3/3] name-rev: --weight option (WIP)
Date: Wed, 29 Aug 2012 21:09:27 -0700 [thread overview]
Message-ID: <7vd329uiko.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120830035127.GB32268@sigill.intra.peff.net> (Jeff King's message of "Wed, 29 Aug 2012 23:51:27 -0400")
Jeff King <peff@peff.net> writes:
> When you wrote "oldest" here, I thought that meant you would do a
> comparison on the taggerdate. But reading the implementation, you really
> mean "topologically oldest".
>
> I wonder, though, if the former would be sufficient for most people.
Even without clock skew, timestamps are inappropriate measure for
the purpose of measuring "this dates back to...", unless you are
limiting yourself to very linear history. Even in our own history,
v1.7.6.6 is 4 months newer than v1.7.7, for example. The same holds
true between v1.7.6.6^0 and v1.7.7^0, so the story does not change
whether you use tagger date or committer date.
Basing this based on tag names is an attractive idea, but we would
need to devise a way for people to pass project specific tagname
comparison function from outside. v3.2 is newer than v3.2-rc1 but
v3.2-bis may probably be newer than v3.2 and I do not think we want
to collect the rules and cast the logic in our code in stone.
next prev parent reply other threads:[~2012-08-30 4:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 4:48 Funny 'git describe --contains' output Greg KH
2012-08-29 5:57 ` Junio C Hamano
2012-08-29 6:36 ` Junio C Hamano
2012-08-29 18:17 ` Greg KH
2012-08-29 21:17 ` [PATCH 0/3] "git name-rev --weight" Junio C Hamano
2012-08-29 21:17 ` [PATCH 1/3] name-rev: lose unnecessary typedef Junio C Hamano
2012-08-29 21:17 ` [PATCH 2/3] name_rev: clarify when a new tip-name is assigned to a commit Junio C Hamano
2012-08-29 21:17 ` [PATCH 3/3] name-rev: --weight option (WIP) Junio C Hamano
2012-08-29 23:37 ` Junio C Hamano
2012-08-30 3:36 ` Jeff King
2012-08-30 3:53 ` Junio C Hamano
2012-08-30 3:55 ` Jeff King
2012-08-30 4:10 ` Junio C Hamano
2012-08-30 4:15 ` Junio C Hamano
2012-08-30 15:59 ` Junio C Hamano
2012-08-30 3:51 ` Jeff King
2012-08-30 4:09 ` Junio C Hamano [this message]
2012-08-30 7:06 ` [PATCH 0/3] "git name-rev --weight" Philip Oakley
2012-08-30 15:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd329uiko.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.