From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH 3/5] setup_revisions: remember whether a ref was positive or not Date: Mon, 08 Aug 2011 15:56:02 -0700 Message-ID: <7vd3gfv7gd.fsf@alter.siamese.dyndns.org> References: <1311517282-24831-1-git-send-email-srabbelier@gmail.com> <1311517282-24831-4-git-send-email-srabbelier@gmail.com> <7vy5znscst.fsf@alter.siamese.dyndns.org> <7vr55fs1z0.fsf@alter.siamese.dyndns.org> <7vy5zabbz7.fsf@alter.siamese.dyndns.org> <7vfwlbztfg.fsf@alter.siamese.dyndns.org> <7vpqkfv8x1.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Junio C Hamano , Johannes Schindelin , Jonathan Nieder , Jeff King , Git List , Daniel Barkalow , Ramkumar Ramachandra , Dmitry Ivankov To: Sverre Rabbelier X-From: git-owner@vger.kernel.org Tue Aug 09 00:56:13 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QqYk0-0000vG-AN for gcvg-git-2@lo.gmane.org; Tue, 09 Aug 2011 00:56:12 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751610Ab1HHW4H (ORCPT ); Mon, 8 Aug 2011 18:56:07 -0400 Received: from b-pb-sasl-quonix.pobox.com ([208.72.237.35]:38623 "EHLO smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328Ab1HHW4F (ORCPT ); Mon, 8 Aug 2011 18:56:05 -0400 Received: from smtp.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id B37284178; Mon, 8 Aug 2011 18:56:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=RMbdYh1L2og4OHZA1SUVIrxhHwk=; b=mI423u n4JUh3IVMQgzx7bWmFIcho4Luy77nT2lzhUI8X5lWKfhzES4CiBFZ4pj9LgCvv7R 1HmEWC3BjvwUnBtgLadyoD0HRLypN3pydQdsAkLqS4tlyF1uhPUkFQvs/r8IiHA/ iXJY+z7V7VxZdwde2eYs8nfLa62pxaSvxm6vA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=JO/QEWR4uSycwJHz7ClypVOhF07CKR1q 0Lv6Wx9RjZVXP2hSDDSgEaYVjFdRfTzZM3oJfgs2kHmW0hRijMBMGVAHNG7FiJkm dqHPbHSuLyQV5Pil4RT01M8OE1q6NTI/RQYrXtQVqqYiHDu/HwXrozNKApMTBayu +nJms+U+gNc= Received: from b-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id A6BDA4177; Mon, 8 Aug 2011 18:56:04 -0400 (EDT) Received: from pobox.com (unknown [76.102.170.102]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by b-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 30F504176; Mon, 8 Aug 2011 18:56:04 -0400 (EDT) In-Reply-To: (Sverre Rabbelier's message of "Tue, 9 Aug 2011 00:28:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: 980F01E2-C211-11E0-A506-1DC62E706CDE-77302942!b-pb-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Sverre Rabbelier writes: >> Please remind yourself why then it is not sufficient for your patch to >> read from the name field please? > > Sure, we could do it. But it would be duplicating all the effort > already being done in rev-parse! > >> After all, wasn't the issue that "master^0..master" yields an empty set >> but you somehow wanted to know that the RHS of that dotdot was given as a >> positive ref? > > The issue was that if I push "master" to origin but I already pushed a > "next" which points at the same commit nothing happens... Would we have the same issue with "git bundle", by the way, caused by the same setup_revisions() limitation? Over there we would also need to decide the set of refs that the user wanted to record their values while computing the set of commits we would need to transfer. In this message I am not interested in talking about what implementation to use to fix it, but just wondering the scope of the same issue and trying to figure out the (positive) impact of _a_ fix.