From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] update-index: add --swap to swap index and worktree content
Date: Tue, 16 Aug 2011 13:01:41 -0700 [thread overview]
Message-ID: <7vippxgm6y.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1313158058-7684-1-git-send-email-pclouds@gmail.com> (=?utf-8?B?Ik5ndXnhu4VuCVRow6FpIE5n4buNYw==?= Duy"'s message of "Fri, 12 Aug 2011 21:07:38 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> What I want is a quick way to modify index content without changing
> worktree, then I can continue adding more hunks to the index.
Why would you even want to do that?
Suppose you want to update hello.c in the index but not in the working
tree for whatever reason I do not understand. Presumably you would with
this patch do this:
edit hello.c
git update-index --swap hello.c
assuming that the state of hello.c _before_ the edit was pristine. But
then after that what would you do? Probably you would commit that
untested change, and rebase-i to clean them up later, which is fine.
BUT
After swapping, the file in the working tree lacks the change you made to
the index, so if you keep working on it after the above "swap" in your
editor, the next "git add" will revert whatever you did with the first
"edit".
I think that makes it too error prone and difficult to understand for both
new and experienced people.
Whatever the expected use case is, it needs to be explained a lot better.
next prev parent reply other threads:[~2011-08-16 20:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 14:07 [PATCH] update-index: add --swap to swap index and worktree content Nguyễn Thái Ngọc Duy
2011-08-16 13:01 ` Michael J Gruber
2011-08-16 14:45 ` Nguyen Thai Ngoc Duy
2011-08-16 20:01 ` Junio C Hamano [this message]
2011-08-16 21:01 ` Jeff King
2011-08-16 21:56 ` Junio C Hamano
2011-08-16 22:22 ` Jeff King
2011-08-16 23:01 ` Junio C Hamano
2011-08-16 23:06 ` Jeff King
2011-08-17 2:11 ` Nguyen Thai Ngoc Duy
2011-08-17 2:17 ` Jeff King
2011-08-17 14:13 ` Martin von Zweigbergk
2011-08-17 14:32 ` Nguyen Thai Ngoc Duy
2011-08-17 18:26 ` Junio C Hamano
2011-08-17 19:46 ` Jeff King
2011-08-18 1:01 ` Martin von Zweigbergk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vippxgm6y.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.