From: Junio C Hamano <email@example.com> To: firstname.lastname@example.org Cc: Alex Riesen <email@example.com>, Christian Couder <firstname.lastname@example.org>, Jonathan Nieder <email@example.com>, Jeff King <firstname.lastname@example.org> Subject: "git -c web.browser=w3m help -w help" still kicks firefox Date: Mon, 23 Aug 2010 11:05:04 -0700 [thread overview] Message-ID: <email@example.com> (raw) My firefox runs in a different "workspace" than what I usually look at while working, and I've beem scratching my head why "git help -w help" doesn't seem to do anything, while I was opening a new tab every time I tried it. And then I tried the command on the Subject line, only to end up with yet another new tab X-<. I know exactly why this happens---we save the config from the command line on a list only so that we can apply them in the correct order after items coming from files, but we do not use the saved values to pass them around to sub-git invocations. 8b1fa77 (Allow passing of configuration parameters in the command line, 2010-03-26) A "trivial fix" would be to pass this info through the execv_git_cmd() interface by either exporting it via an environment variable or by modifying the command line options, but I am not sure about the possible fallouts from such a change. For example, does "git -c var=value config ..." work sensibly when what "config" is told to do (say, remove a section) contradicts with having the named var with a given value? I am wondering if this is worth fixing it in the first place. Opinions? Patches ;-)?
next reply other threads:[~2010-08-23 18:05 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-08-23 18:05 Junio C Hamano [this message] 2010-08-23 18:38 ` Jeff King 2010-08-23 19:16 ` Jeff King 2010-08-24 6:41 ` [PATCH 2/1] do not pass "git -c foo=bar" params to transport helpers Jonathan Nieder 2010-08-24 14:14 ` Jeff King 2010-08-24 19:07 ` [PATCH 2/1] do not pass "git -c foo=bar" " Eric Raible 2010-08-23 19:02 ` "git -c web.browser=w3m help -w help" still kicks firefox Alex Riesen 2010-08-23 20:33 ` Jeff King 2010-08-24 5:01 ` Jonathan Nieder 2010-08-24 14:12 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: "git -c web.browser=w3m help -w help" still kicks firefox' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.