Re: [PATCH 1/3 v2] send-email: correct logic error with --suppress-cc=cc

From: Junio C Hamano <gitster@pobox.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org, Ryan Anderson <ryan@michonline.com>,
	Thomas Rast <trast@student.ethz.ch>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 1/3 v2] send-email: correct logic error with --suppress-cc=cc
Date: Fri, 13 Feb 2009 22:52:39 -0800	[thread overview]
Message-ID: <7viqndzf0o.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1234592519-71980-1-git-send-email-jaysoffian@gmail.com> (Jay Soffian's message of "Sat, 14 Feb 2009 01:21:59 -0500")

Jay Soffian <jaysoffian@gmail.com> writes:

> --suppress-cc=cc is supposed to suppress harvesting addresses from any
> Cc: lines. However, in the case where the Cc: line contained the sender,
> it would only suppress if --suppress-cc=self.

Perhaps I am personally slightly in favor of your interpretation, but the
current behaviour makes sort of sense, too.  To everybody, himself is
always special (and that is why we have 'self'); I do not think it is
entirely unreasonable if --suppress-cc=cc meant remove people from Cc list
but I am special.

> And here's a re-roll of this one. Sheesh, that logic was too subtle for
> my brain.

Perhaps it is easier to clarify the goal by updating the tests to define
what needs to happen first?  Working from tests often makes the end result
much more robust than randomly modifying the existing code here and there
until it happens to start doing something you think it should do.