All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Jeff King <peff@peff.net>
Cc: Francis Moreau <francis.moro@gmail.com>, git@vger.kernel.org
Subject: Re: git-send-email and aliases
Date: Tue, 27 Mar 2007 18:52:33 -0700	[thread overview]
Message-ID: <7vk5x2m8wu.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 20070327110246.GA30217@sigill.intra.peff.net

Jeff King <peff@peff.net> writes:

> On Tue, Mar 27, 2007 at 03:59:19AM -0700, Junio C Hamano wrote:
>
>> It might be easier but I do not think that is useful.  When
>> git-commit runs the $EDITOR for the commit log message, I think
>> people would expect (if you are using vi) "!!git log" to honor
>> their alias.
>
> Then git-commit can unset GIT_NOALIAS when it expects to call into
> "user" code such as the editor.

Surely, but then it is not just a matter of "setting GIT_NOALIAS
at the top of all git programs" anymore.  You need to audit the
code.

> A potentially bigger problem with any such scheme is that non-git
> scripts would have to set GIT_NOALIAS. Not a big deal for new scripts,
> but it might break old scripts.

You are right.  Both GIT_NOALIAS and "write git-foo if you do
not want to be affected with alias" would fail that.

  reply	other threads:[~2007-03-28  1:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-26  9:39 git-send-email and aliases Francis Moreau
2007-03-26  9:47 ` Junio C Hamano
2007-03-26  9:57   ` Francis Moreau
2007-03-27  9:38   ` Francis Moreau
2007-03-27 10:29     ` Junio C Hamano
2007-03-27 10:46       ` Jeff King
2007-03-27 10:59         ` Junio C Hamano
2007-03-27 11:02           ` Jeff King
2007-03-28  1:52             ` Junio C Hamano [this message]
2007-03-27 16:08       ` Francis Moreau
2007-03-26 10:08 ` Nicolas Vilz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vk5x2m8wu.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=francis.moro@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.