All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Caldwell <david@porkrind.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] stash: Add --include-untracked option to stash and remove all untracked files
Date: Sun, 26 Jun 2011 13:02:22 -0700	[thread overview]
Message-ID: <7vliwoz7ht.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1308963366-1697-1-git-send-email-david@porkrind.org> (David Caldwell's message of "Fri, 24 Jun 2011 17:56:06 -0700")

David Caldwell <david@porkrind.org> writes:

> @@ -49,6 +57,7 @@ clear_stash () {
>  
>  create_stash () {
>  	stash_msg="$1"
> +	untracked="$2"

Hmm...

> @@ -173,7 +213,7 @@ save_stash () {
>  	test -f "$GIT_DIR/logs/$ref_stash" ||
>  		clear_stash || die "Cannot initialize stash"
>  
> -	create_stash "$stash_msg"
> +	create_stash "$stash_msg" $untracked

Just a minor nit from internal API point of view, I would prefer to see
something like

	create_stash --untracked=all "message"

or even

	create_stash --untracked=all --message="message"

once you start enriching these functions with optional behaviour.

  reply	other threads:[~2011-06-26 20:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-20 23:36 [PATCH] stash: Add --clean option to stash and remove all untracked files David Caldwell
2011-06-21  0:38 ` Jeff King
2011-06-21  1:36   ` David Caldwell
2011-06-21  5:08     ` Andrew Wong
2011-06-21  6:28       ` Johannes Sixt
2011-06-21 14:18         ` Jeff King
2011-06-21 16:11           ` Paul Ebermann
2011-06-21 21:23             ` Marc Branchaud
2011-06-22  7:47             ` Miles Bader
2011-06-22 15:00               ` Jeff King
2011-06-21 17:16           ` Junio C Hamano
2011-06-24 20:02 ` [PATCH] stash: Add --include-untracked " David Caldwell
2011-06-24 20:31   ` Matthieu Moy
2011-06-25  0:56     ` David Caldwell
2011-06-26 20:02       ` Junio C Hamano [this message]
2011-06-29 17:11 David Caldwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vliwoz7ht.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=david@porkrind.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.