All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
	Git List <git@vger.kernel.org>,
	Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH 3/6] t5516 (fetch-push): introduce mk_test_with_name()
Date: Fri, 22 Mar 2013 07:52:47 -0700	[thread overview]
Message-ID: <7vmwtv8p1c.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130322144454.GA3083@sigill.intra.peff.net> (Jeff King's message of "Fri, 22 Mar 2013 10:44:55 -0400")

Jeff King <peff@peff.net> writes:

> I think this is OK, and I do not mind if it gets applied. But what I was
> hinting at in my earlier mail was that we might want to do this (I have
> it as a separate patch on top of your 3/6 here, but it would make more
> sense squashed in):

I would prefer to see a preparatory patch to teach mk_test/mk_empty
to _always_ take the new name (i.e. the result of your patch) and
then do whatever new things on top.

By the way, I am planning to _not_ look at new stuff today. I'd
rather see known recent regressions addressed (and unknown ones
discovered and squashed) before we move forward, and I would
appreciate if regular contributors did the same.

Thanks.

  reply	other threads:[~2013-03-22 14:53 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22  7:52 [PATCH v3 0/6] Support triangular workflows Ramkumar Ramachandra
2013-03-22  7:52 ` [PATCH 1/6] remote.c: simplify a bit of code using git_config_string() Ramkumar Ramachandra
2013-03-22 18:26   ` Jonathan Nieder
2013-03-22  7:52 ` [PATCH 2/6] t5516 (fetch-push): update test description Ramkumar Ramachandra
2013-03-22 18:29   ` Jonathan Nieder
2013-03-22  7:52 ` [PATCH 3/6] t5516 (fetch-push): introduce mk_test_with_name() Ramkumar Ramachandra
2013-03-22 14:44   ` Jeff King
2013-03-22 14:52     ` Junio C Hamano [this message]
2013-03-22 14:59       ` Jeff King
2013-03-22 21:14       ` Jonathan Nieder
2013-03-28 13:03     ` Ramkumar Ramachandra
2013-03-22 14:54   ` Junio C Hamano
2013-03-22 14:58     ` Jeff King
2013-03-22  7:52 ` [PATCH 4/6] remote.c: introduce a way to have different remotes for fetch/push Ramkumar Ramachandra
2013-03-22 21:21   ` Jonathan Nieder
2013-03-22 22:13     ` Junio C Hamano
2013-03-22 23:41       ` Jonathan Nieder
2013-03-23 13:18         ` Ramkumar Ramachandra
2013-03-23 12:57       ` Ramkumar Ramachandra
2013-03-22  7:52 ` [PATCH 5/6] remote.c: introduce remote.pushdefault Ramkumar Ramachandra
2013-03-22 14:56   ` Jeff King
2013-03-27  9:39     ` Ramkumar Ramachandra
2013-03-22  7:52 ` [PATCH 6/6] remote.c: introduce branch.<name>.pushremote Ramkumar Ramachandra
2013-03-22 17:37   ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2013-03-20 12:44 [PATCH v2 0/6] Support triangular workflows Ramkumar Ramachandra
2013-03-20 12:44 ` [PATCH 3/6] t5516 (fetch-push): introduce mk_test_with_name() Ramkumar Ramachandra
2013-03-20 18:28   ` Jonathan Nieder
2013-03-20 18:38     ` Ramkumar Ramachandra
2013-03-20 18:41       ` Jonathan Nieder
2013-03-20 18:58         ` Jeff King
2013-03-20 19:52           ` Junio C Hamano
2013-03-20 20:00           ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vmwtv8p1c.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.