From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH] log doc: the argument to --encoding is not optional
Date: Mon, 05 Aug 2013 08:20:00 -0700 [thread overview]
Message-ID: <7vob9cnp0f.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130802221640.GA7478@elie.Belkin> (Jonathan Nieder's message of "Fri, 2 Aug 2013 15:16:40 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> $ git log --encoding
> fatal: Option '--encoding' requires a value
> $ git rev-list --encoding
> fatal: Option '--encoding' requires a value
>
> The argument to --encoding has always been mandatory. Unfortunately
> manpages like git-rev-list(1), git-log(1), and git-show(1) have
> described the option's syntax as "--encoding[=<encoding>]" since it
> was first documented. Clarify by removing the extra brackets.
>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
Thanks.
> Documentation/git-rev-list.txt | 2 +-
> Documentation/pretty-options.txt | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-rev-list.txt b/Documentation/git-rev-list.txt
> index 65ac27e0..045b37b8 100644
> --- a/Documentation/git-rev-list.txt
> +++ b/Documentation/git-rev-list.txt
> @@ -40,7 +40,7 @@ SYNOPSIS
> [ \--right-only ]
> [ \--cherry-mark ]
> [ \--cherry-pick ]
> - [ \--encoding[=<encoding>] ]
> + [ \--encoding=<encoding> ]
> [ \--(author|committer|grep)=<pattern> ]
> [ \--regexp-ignore-case | -i ]
> [ \--extended-regexp | -E ]
> diff --git a/Documentation/pretty-options.txt b/Documentation/pretty-options.txt
> index 5e499421..eea0e306 100644
> --- a/Documentation/pretty-options.txt
> +++ b/Documentation/pretty-options.txt
> @@ -28,7 +28,7 @@ people using 80-column terminals.
> This is a shorthand for "--pretty=oneline --abbrev-commit"
> used together.
>
> ---encoding[=<encoding>]::
> +--encoding=<encoding>::
> The commit objects record the encoding used for the log message
> in their encoding header; this option can be used to tell the
> command to re-code the commit log message in the encoding
next prev parent reply other threads:[~2013-08-05 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 22:16 [PATCH] log doc: the argument to --encoding is not optional Jonathan Nieder
2013-08-05 15:20 ` Junio C Hamano [this message]
2013-08-05 15:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vob9cnp0f.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.