All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Martin Svensson <martin.k.svensson@netinsight.se>
Cc: git@vger.kernel.org
Subject: Re: cherry-pick -x formats the message incorrectly
Date: Tue, 16 Nov 2010 11:20:56 -0800	[thread overview]
Message-ID: <7vpqu5gjmv.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <loom.20101116T100730-967@post.gmane.org> (Martin Svensson's message of "Tue\, 16 Nov 2010 09\:14\:15 +0000 \(UTC\)")

Martin Svensson <martin.k.svensson@netinsight.se> writes:

> Now that's not good, because it is a two-line summary. In my opinion, the
> parentheses should _always_ end up in the detailed part.
> It should be:
>
>   foo
>   
>   (cherry picked from commit eb42a6475d2c2e4fff7a1b626ce6e27eec21e886)
>
> Am I right?

I tend to agree (modulo s/summary/subject/ would be the wording I would
have used).

This falls into "patches welcome" category, though.  I do not think
anybody sane is still using cherry-pick with -x option these days after
http://thread.gmane.org/gmane.comp.version-control.git/28378

  reply	other threads:[~2010-11-16 19:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-16  9:14 cherry-pick -x formats the message incorrectly Martin Svensson
2010-11-16 19:20 ` Junio C Hamano [this message]
2010-11-16 19:35   ` Jonathan Nieder
2010-11-16 21:34     ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vpqu5gjmv.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=martin.k.svensson@netinsight.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.