All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Tim Henigan <tim.henigan@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH v3] diff-no-index: exit(1) if 'diff --quiet <repo file> <external file>' finds changes
Date: Thu, 21 Jun 2012 09:55:12 -0700	[thread overview]
Message-ID: <7vsjdosiz3.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAFouethNTzcWq_YKzGz+jRTeCjKZEC2ZYMZuQxkF+5AOTC=x-A@mail.gmail.com> (Tim Henigan's message of "Thu, 21 Jun 2012 11:07:12 -0400")

Tim Henigan <tim.henigan@gmail.com> writes:

> It looks like the best place to add tests is t4010-diff-pathspec.sh.

Well, pathspecs are all about limiting the changes in the repository
by patterns, while "diff --no-index" is about exact pathnames, so I
am not sure if that is a good place to put them.  Isn't there a test
script that is dedicated to the "diff --no-index" codepath (perhaps
4053) that is more appropriate for doing this?

      reply	other threads:[~2012-06-21 16:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18 19:28 [PATCH v3] diff-no-index: exit(1) if 'diff --quiet <repo file> <external file>' finds changes Tim Henigan
2012-06-18 19:45 ` Jeff King
2012-06-18 20:09 ` Junio C Hamano
2012-06-19 13:05   ` Tim Henigan
2012-06-19 13:58     ` Jeff King
2012-06-19 16:47       ` Tim Henigan
2012-06-20 13:38         ` Tim Henigan
2012-06-20 16:06           ` Jeff King
2012-06-20 18:44             ` Junio C Hamano
2012-06-20 18:52               ` Jeff King
2012-06-20 19:21                 ` Junio C Hamano
2012-06-21 15:07             ` Tim Henigan
2012-06-21 16:55               ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vsjdosiz3.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=tim.henigan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.