From: Junio C Hamano <gitster@pobox.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Git Mailing List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 2/2] Submodules: Add the new "fetch" config option
Date: Mon, 30 Aug 2010 00:34:13 -0700 [thread overview]
Message-ID: <7vsk1wftai.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4C7A81F0.4090209@web.de> (Jens Lehmann's message of "Sun\, 29 Aug 2010 17\:51\:12 +0200")
Jens Lehmann <Jens.Lehmann@web.de> writes:
> diff --git a/submodule.c b/submodule.c
> index e4f2419..8c98fad 100644
> --- a/submodule.c
> +++ b/submodule.c
> @@ -100,6 +101,14 @@ int parse_submodule_config_option(const char *var, const char *value)
> config = string_list_append(&config_name_for_path, xstrdup(value));
> config->util = strbuf_detach(&submodname, NULL);
> strbuf_release(&submodname);
> + } else if ((len > 5) && !strcmp(var + len - 6, ".fetch")) {
> + strbuf_add(&submodname, var, len - 6);
> + config = unsorted_string_list_lookup(&config_fetch_for_name, submodname.buf);
> + if (!config)
> + config = string_list_append(&config_fetch_for_name,
> + strbuf_detach(&submodname, NULL));
> + config->util = (void *)git_config_bool(var, value);
Hmm? We get this here...
submodule.c:110: error: cast to pointer from integer of different size
next prev parent reply other threads:[~2010-08-30 7:34 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-29 15:49 [RFC PATCH 0/2] Teach fetch and pull to recursively fetch submodules too Jens Lehmann
2010-08-29 15:50 ` [PATCH 1/2] fetch/pull: Recursively fetch populated submodules Jens Lehmann
2010-08-29 15:51 ` [PATCH 2/2] Submodules: Add the new "fetch" config option Jens Lehmann
2010-08-30 7:34 ` Junio C Hamano [this message]
2010-08-30 17:37 ` [PATCH 2/2 v2] Submodules: Add the new "fetch" config option for fetch and pull Jens Lehmann
2010-08-29 17:29 ` [RFC PATCH 0/2] Teach fetch and pull to recursively fetch submodules too Ævar Arnfjörð Bjarmason
2010-08-29 22:34 ` Jens Lehmann
2010-08-30 5:58 ` Junio C Hamano
2010-08-30 17:41 ` Jens Lehmann
2010-09-15 0:18 ` Kevin Ballard
2010-09-15 2:40 ` Kevin Ballard
2010-09-16 13:55 ` [PATCH] fetch: Get submodule paths from index and not from .gitmodules Jens Lehmann
2010-09-16 19:29 ` Kevin Ballard
2010-09-17 11:31 ` Jens Lehmann
2010-09-17 12:06 ` Johannes Sixt
2010-09-17 12:22 ` Jens Lehmann
2010-09-17 12:32 ` Johannes Sixt
2010-09-17 14:01 ` Jens Lehmann
2010-09-17 14:14 ` Johannes Sixt
2010-09-18 0:29 ` Kevin Ballard
2010-09-18 22:32 ` [PATCH 0/2] fix problems with recursive submodule fetching Jens Lehmann
2010-09-18 22:33 ` [PATCH 1/2] fetch: Fix a bug swallowing the output of " Jens Lehmann
2010-09-18 22:35 ` [PATCH 2/2] fetch: Get submodule paths from index and not from .gitmodules Jens Lehmann
2010-09-19 3:54 ` [PATCH 0/2] fix problems with recursive submodule fetching Kevin Ballard
2010-09-19 16:40 ` Jens Lehmann
2010-09-20 6:40 ` Kevin Ballard
2010-10-05 20:43 ` [PATCH v2 0/3] Teach fetch and pull to recursively fetch submodules too Jens Lehmann
2010-10-05 20:43 ` [PATCH 1/3] fetch/pull: Recursively fetch populated submodules Jens Lehmann
2010-10-05 20:44 ` [PATCH 2/3] Submodules: Add the new "fetch" config option for fetch and pull Jens Lehmann
2010-10-07 13:33 ` Jon Seymour
2010-10-09 19:22 ` Jens Lehmann
2010-10-09 19:54 ` Jonathan Nieder
2010-10-09 20:12 ` Jens Lehmann
2010-10-05 20:45 ` [PATCH 3/3] Add the 'fetch.recursive' config setting Jens Lehmann
2010-10-05 21:06 ` [PATCH v2 0/3] Teach fetch and pull to recursively fetch submodules too Junio C Hamano
2010-10-06 22:52 ` Kevin Ballard
2010-10-06 23:22 ` Jonathan Nieder
2010-10-09 19:28 ` Jens Lehmann
2010-10-09 20:02 ` Jonathan Nieder
2010-10-09 20:37 ` Jens Lehmann
2010-10-21 18:29 ` Jonathan Nieder
2010-10-21 21:15 ` Jens Lehmann
2010-10-09 19:17 ` Jens Lehmann
2010-10-13 14:48 ` Marc Branchaud
2010-10-13 19:32 ` Jens Lehmann
2010-10-13 19:34 ` Kevin Ballard
2010-10-13 20:06 ` Jens Lehmann
2010-10-13 20:11 ` Kevin Ballard
2010-10-14 1:01 ` Chris Packham
2010-10-14 18:14 ` Jens Lehmann
2010-10-14 18:31 ` Chris Packham
2010-10-13 21:27 ` Marc Branchaud
2010-10-13 21:31 ` Kevin Ballard
2010-09-15 11:32 ` [RFC PATCH 0/2] " Jens Lehmann
2010-09-15 23:12 ` Kevin Ballard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsk1wftai.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.