From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC 3/3] t/gitweb-lib.sh: Add support for GITWEB_TEST_INSTALLED
Date: Sun, 12 Sep 2010 10:37:47 -0700 [thread overview]
Message-ID: <7vtylueuc4.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1284284466-14506-4-git-send-email-jnareb@gmail.com> (Jakub Narebski's message of "Sun\, 12 Sep 2010 11\:41\:06 +0200")
Jakub Narebski <jnareb@gmail.com> writes:
> It is an RFC because I am not sure where to put documentation,
> i.e. description of GITWEB_TEST_INSTALLED. Should it be put in
> t/README, in gitweb/README, or in gitweb/INSTALL, or in
> t/gitweb-lib.sh header?
I think the comment in this file is fine.
> + # You can set the GITWEB_TEST_INSTALLED environment variable to
> + # the gitwebdir (the directory where gitweb is installed / deployed to)
> + # of an existing gitweb instalation to test that installation.
> + if test -n "$GITWEB_TEST_INSTALLED" ; then
> + SCRIPT_NAME="$GITWEB_TEST_INSTALLED/gitweb.cgi"
> + test -f "$SCRIPT_NAME" ||
> + error "Cannot find gitweb.cgi at $GITWEB_TEST_INSTALLED."
I don't know if GIT_WEB_TEST_INSTALLED=/path/to/some/directory (naming the
directory that houses the script which must be named gitweb.cgi) is easier
to use than GIT_WEB_TEST_INSTALLED=/path/to/some/gitweb.perl (naming the
script that is allowed to be renamed).
next prev parent reply other threads:[~2010-09-12 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-12 9:41 [PATCH 0/3] t/gitweb-lib.sh improvements Jakub Narebski
2010-09-12 9:41 ` [PATCH 1/3] t/gitweb-lib.sh: Use GIT_BUILD_DIR Jakub Narebski
2010-09-12 9:41 ` [PATCH 2/3] t/gitweb-lib.sh: Use tabs for indent consistently Jakub Narebski
2010-09-12 9:41 ` [PATCH/RFC 3/3] t/gitweb-lib.sh: Add support for GITWEB_TEST_INSTALLED Jakub Narebski
2010-09-12 9:46 ` Ævar Arnfjörð Bjarmason
2010-09-12 17:37 ` Junio C Hamano [this message]
2010-09-12 19:33 ` Jakub Narebski
2010-09-16 19:58 ` [RFC/PATCHv2 " Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtylueuc4.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.