From: Junio C Hamano <gitster@pobox.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: git@vger.kernel.org, Pierre Habouzit <madcoder@debian.org>
Subject: Re: [PATCH] Microoptimize strbuf_cmp
Date: Thu, 19 Mar 2009 15:01:40 -0700 [thread overview]
Message-ID: <7vvdq56ukb.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090319210931.GB31014@blimp.localdomain> (Alex Riesen's message of "Thu, 19 Mar 2009 22:09:32 +0100")
Alex Riesen <raa.lkml@gmail.com> writes:
> Make it inline and cleanup a bit. It is definitely less code
> including object code, but it is not always measurably faster
> (but mostly is).
The only in-tree user seems to be rerere, so inlining for that single
caller will reduce the object side, but I am not sure if this is a good
change in the longer term if we want to encourage the use of strbuf
library.
The rewrite of the logic does seem worth doing, though.
next prev parent reply other threads:[~2009-03-19 22:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 21:09 [PATCH] Microoptimize strbuf_cmp Alex Riesen
2009-03-19 22:01 ` Junio C Hamano [this message]
2009-03-19 22:27 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvdq56ukb.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.