From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>, Chris Rorvick <chris@rorvick.com>
Subject: Re: [PATCH 0/3] Finishing touches to "push" advises
Date: Mon, 21 Jan 2013 23:26:30 -0800 [thread overview]
Message-ID: <7vwqv5brvd.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1358836230-9197-1-git-send-email-gitster@pobox.com> (Junio C. Hamano's message of "Mon, 21 Jan 2013 22:30:27 -0800")
As far as I am concerned, I am pretty much done with this topic, at
least for now. Of course if there are bugreports I'll try to help
resolving them, but I do not expect myself adding new object-type
based policy decision to this codepath.
The call the updated call makes to ref_newer() no longer feeds
certain combinations to the function, because the NULL-ness of the
old and commit-ness of both are checked before making a call.
I notice that builtin/remote.c has another callsite for ref_newer().
Although I didn't look at the code, I think it is trying to see if
the branch can be pushed as a fast-forward to the remote (or the
remote tip moved since you started building on top of it).
It probably makes sense to refactor the logic that is run per-ref in
the loop in the set_ref_status_for_push() function into a new helper
function, inline ref_newer() there, and have the remaining callers
of ref_newer() to use that new helper function, which knows the new
rules such as "refs/tags/ cannot be replaced with anything without
force".
next prev parent reply other threads:[~2013-01-22 7:26 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 1:41 [PATCH v6 0/8] push: update remote tags only with force Chris Rorvick
2012-11-30 1:41 ` [PATCH v6 1/8] push: return reject reasons as a bitset Chris Rorvick
2012-11-30 1:41 ` [PATCH v6 2/8] push: add advice for rejected tag reference Chris Rorvick
2012-12-02 10:42 ` Junio C Hamano
2012-12-03 3:27 ` [PATCH 0/2] push: honor advice.* configuration Chris Rorvick
2012-12-03 3:27 ` [PATCH 1/2] push: rename config variable for more general use Chris Rorvick
2012-12-03 3:27 ` [PATCH 2/2] push: allow already-exists advice to be disabled Chris Rorvick
2012-11-30 1:41 ` [PATCH v6 3/8] push: flag updates Chris Rorvick
2012-11-30 1:41 ` [PATCH v6 4/8] push: flag updates that require force Chris Rorvick
2012-11-30 1:41 ` [PATCH v6 5/8] push: require force for refs under refs/tags/ Chris Rorvick
2012-11-30 1:41 ` [PATCH v6 6/8] push: require force for annotated tags Chris Rorvick
2012-11-30 1:41 ` [PATCH v6 7/8] push: clarify rejection of update to non-commit-ish Chris Rorvick
2012-11-30 1:41 ` [PATCH v6 8/8] push: cleanup push rules comment Chris Rorvick
2012-12-02 20:43 ` [PATCH] remote.c: fix grammatical error in comment Chris Rorvick
2012-12-03 18:53 ` [PATCH v6 0/8] push: update remote tags only with force Junio C Hamano
2013-01-16 13:32 ` Max Horn
2013-01-16 16:00 ` Junio C Hamano
2013-01-16 16:01 ` Jeff King
2013-01-16 17:10 ` Junio C Hamano
2013-01-16 17:43 ` Jeff King
2013-01-16 21:02 ` Junio C Hamano
2013-01-17 2:19 ` Chris Rorvick
2013-01-17 3:11 ` Jeff King
2013-01-17 3:42 ` Chris Rorvick
2013-01-16 16:36 ` Junio C Hamano
2013-01-16 16:48 ` Junio C Hamano
2013-01-17 6:20 ` Chris Rorvick
2013-01-17 6:59 ` Junio C Hamano
2013-01-17 13:09 ` Chris Rorvick
2013-01-18 1:06 ` Jeff King
2013-01-18 3:18 ` Chris Rorvick
2013-01-21 23:40 ` Jeff King
2013-01-21 23:53 ` Junio C Hamano
2013-01-22 4:59 ` Chris Rorvick
2013-01-22 6:44 ` Junio C Hamano
2013-01-22 5:53 ` [PATCH 0/3] Finishing touches to "push" advises Junio C Hamano
2013-01-22 5:53 ` [PATCH 1/3] push: further clean up fields of "struct ref" Junio C Hamano
2013-01-22 5:53 ` [PATCH 2/3] push: introduce REJECT_FETCH_FIRST and REJECT_NEEDS_FORCE Junio C Hamano
2013-01-22 6:04 ` Junio C Hamano
2013-01-22 5:53 ` [PATCH 3/3] push: further reduce "struct ref" and simplify the logic Junio C Hamano
2013-01-22 6:21 ` Junio C Hamano
2013-01-22 6:30 ` [PATCH 0/3] Finishing touches to "push" advises Junio C Hamano
2013-01-22 6:30 ` [PATCH v2 1/3] push: further clean up fields of "struct ref" Junio C Hamano
2013-01-23 6:43 ` Jeff King
2013-01-22 6:30 ` [PATCH v2 2/3] push: introduce REJECT_FETCH_FIRST and REJECT_NEEDS_FORCE Junio C Hamano
2013-01-23 6:56 ` Jeff King
2013-01-23 16:28 ` Junio C Hamano
2013-01-24 6:43 ` Jeff King
2013-01-22 6:30 ` [PATCH v2 3/3] push: further simplify the logic to assign rejection status Junio C Hamano
2013-01-22 7:26 ` Junio C Hamano [this message]
2013-01-23 21:55 ` [PATCH v4 0/3] Finishing touches to "push" advises Junio C Hamano
2013-01-23 21:55 ` [PATCH v4 1/3] push: further clean up fields of "struct ref" Junio C Hamano
2013-01-24 22:22 ` Eric Sunshine
2013-01-23 21:55 ` [PATCH v4 2/3] push: further simplify the logic to assign rejection reason Junio C Hamano
2013-01-23 21:55 ` [PATCH v4 3/3] push: introduce REJECT_FETCH_FIRST and REJECT_NEEDS_FORCE Junio C Hamano
2013-01-24 6:58 ` Jeff King
2013-01-24 17:19 ` Junio C Hamano
2013-01-25 4:31 ` [PATCH v4 0/3] Finishing touches to "push" advises Chris Rorvick
2013-01-25 5:04 ` Junio C Hamano
2013-01-25 5:14 ` Chris Rorvick
2013-01-18 4:36 ` [PATCH v6 0/8] push: update remote tags only with force Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwqv5brvd.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=chris@rorvick.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.