From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: Jakub Narebski <jnareb@gmail.com>,
mikachu@gmail.com, computerdruid@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH 1/3] clone: do not accept --depth on local clones
Date: Fri, 20 Aug 2010 17:27:19 -0700 [thread overview]
Message-ID: <7vwrrk95eg.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 1282269067-5527-1-git-send-email-pclouds@gmail.com
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> clone_local() function disregards --depth. Make it more apparent.
> Also hint users that file:// works with --depth.
Hmm---why?
The "--depth" option is an ugly hack that tries to conserve network
bandwidth and disk usage, which is not necessary if you are doing a local
hardlinking clone. Without this patch we allowed people to clone with the
option without a downside (allowing it didn't result in broken repository,
for example), but with it, what has long been allowed suddenly stops
working. Is the breakage justifiable?
next prev parent reply other threads:[~2010-08-21 0:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 1:51 [PATCH 1/3] clone: do not accept --depth on local clones Nguyễn Thái Ngọc Duy
2010-08-20 1:51 ` [PATCH 2/3] fetch-pack: use args.shallow to detect shallow clone instead of args.depth Nguyễn Thái Ngọc Duy
2010-08-20 1:51 ` [PATCH 3/3] {fetch,upload}-pack: allow --depth=0 for infinite depth Nguyễn Thái Ngọc Duy
2010-08-20 22:11 ` Jakub Narebski
2010-08-22 22:51 ` Nguyen Thai Ngoc Duy
2010-08-21 0:27 ` Junio C Hamano
2010-08-21 0:27 ` Junio C Hamano [this message]
2010-08-22 22:43 ` [PATCH 1/3] clone: do not accept --depth on local clones Nguyen Thai Ngoc Duy
-- strict thread matches above, loose matches on Subject: below --
2010-08-18 12:54 fully deepening a shallow clone Daniel Johnson
2010-08-19 10:40 ` [PATCH 1/3] clone: do not accept --depth on local clones Nguyễn Thái Ngọc Duy
2010-08-19 14:31 ` Daniel Johnson
2010-08-19 22:15 ` Nguyen Thai Ngoc Duy
2010-08-19 20:49 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwrrk95eg.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=computerdruid@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=mikachu@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.