From: Junio C Hamano <gitster@pobox.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Daniel Barkalow <barkalow@iabervon.org>,
Hugo Mildenberger <Hugo.Mildenberger@namir.de>
Subject: Re: [PATCH] Quote LF in urls git fetch saves in FETCH_HEAD
Date: Tue, 12 May 2009 16:16:02 -0700 [thread overview]
Message-ID: <7vws8l7w0d.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20090512172452.GA32594@blimp.localdomain> (Alex Riesen's message of "Tue\, 12 May 2009 19\:24\:52 +0200")
Alex Riesen <raa.lkml@gmail.com> writes:
> + for (i = 0; i < url_len; ++i)
> + if ('\n' == url[i])
> + fputs("\\n", fp);
> + else
> + fputc(url[i], fp);
> + fputc('\n', fp);
This ad-hoc quoting feels _very_ wrong. Who is on the reading side and
how does it unquote? If it uses quote.c infrastructure, we should be
quoting using the function from the same library shouldn't we?
If it is just informational use only, then it might make more sense to
drop this ugly "quoted \n" silently. I dunno.
next prev parent reply other threads:[~2009-05-12 23:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 20:08 git fails with control characters in trunk directory name Hugo Mildenberger
2009-05-12 6:51 ` Alex Riesen
2009-05-12 9:02 ` Hugo Mildenberger
2009-05-12 10:54 ` Alex Riesen
2009-05-12 13:57 ` Hugo Mildenberger
2009-05-12 14:59 ` Alex Riesen
2009-05-12 16:59 ` Hugo Mildenberger
2009-05-12 17:18 ` Alex Riesen
2009-05-12 17:24 ` [PATCH] Quote LF in urls git fetch saves in FETCH_HEAD Alex Riesen
2009-05-12 23:16 ` Junio C Hamano [this message]
2009-05-13 6:06 ` Alex Riesen
[not found] ` <200905131340.31509.Hugo.Mildenberger@namir.de>
2009-05-13 12:10 ` Alex Riesen
2009-05-13 14:49 ` Hugo Mildenberger
2009-05-13 12:39 ` Hugo Mildenberger
2009-05-13 15:18 ` Daniel Barkalow
2009-05-13 16:09 ` Alex Riesen
2009-05-13 17:07 ` Alex Riesen
2009-05-13 17:12 ` Daniel Barkalow
2009-05-13 18:11 ` Alex Riesen
2009-05-13 18:23 ` Junio C Hamano
2009-05-13 18:08 ` [PATCH 1/2] " Alex Riesen
2009-05-13 20:53 ` [PATCH 2/2] Improve the naming of guessed target repository for git clone Alex Riesen
2009-05-14 0:41 ` Junio C Hamano
2009-05-14 5:54 ` Alex Riesen
2009-05-14 6:35 ` Junio C Hamano
2009-05-14 8:45 ` Alex Riesen
2009-05-14 12:50 ` Hugo Mildenberger
2009-05-14 8:33 ` Alex Riesen
2009-05-16 17:49 ` Junio C Hamano
2009-05-12 17:41 ` git fails with control characters in trunk directory name Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vws8l7w0d.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Hugo.Mildenberger@namir.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.