All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: [PATCH] tests: use test_cmp instead of piping to diff(1)
Date: Mon, 13 Sep 2010 16:31:45 -0700	[thread overview]
Message-ID: <7vy6b59q5a.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1284411582-1088-1-git-send-email-avarab@gmail.com> (=?utf-8?B?IsOGdmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Mon\, 13 Sep 2010 20\:59\:42 +0000")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> @@ -37,9 +37,10 @@ head1=$(add_file sm1 foo1 foo2)
>  test_expect_success 'added submodule' "
>  	git add sm1 &&
>  	git diff-index -p --submodule=log HEAD >actual &&
> -	diff actual - <<-EOF
> +	cat >expected <<-EOF &&
>  Submodule sm1 0000000...$head1 (new submodule)
>  EOF
> +    test_cmp expected actual
>  "

Nit.  Did you really mean <<-EOF, not <<EOF, here, especially you are
writing the here document without indentation with any TAB?

  reply	other threads:[~2010-09-13 23:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 20:59 [PATCH] tests: use test_cmp instead of piping to diff(1) Ævar Arnfjörð Bjarmason
2010-09-13 23:31 ` Junio C Hamano [this message]
2010-09-14  1:45   ` Ævar Arnfjörð Bjarmason
2010-09-14 23:17     ` Jens Lehmann
2010-09-15 23:15       ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vy6b59q5a.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Jens.Lehmann@web.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.