From: Junio C Hamano <junkio@cox.net>
To: "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/5] Introduces for_each_revision() helper
Date: Sat, 28 Apr 2007 23:59:18 -0700 [thread overview]
Message-ID: <7vy7kbeke1.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070427181326.14bbbf5c@localhost> (Luiz Fernando N. Capitulino's message of "Fri, 27 Apr 2007 18:13:26 -0300")
"Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
writes:
> Em Fri, 27 Apr 2007 12:32:11 -0700
> Junio C Hamano <junkio@cox.net> escreveu:
>
> | "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
> | writes:
> |
> | > From: Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
> | >
> | > This macro may be used to iterate over revisions, so, instead of
> | > doing: ...
> |
> | I am not a big fan of magic control-flow macros, as it makes the
> | code harder to grok for people new to the codebase.
>
> Yeah, I agree. But I think that any experienced programmer will
> understand it.
>
> Anyways, I don't want to raise polemic discussions for minor
> changes. Feel free to drop this one then.
I on the other hand like the kernel style list macros.
The reason I do not like this particular one is because both
operations you are hiding are not simple operations like
"initialize a variable to list head" or "follow a single pointer
in the structure", but rather heavyweight operations with rather
complex semantics. I would want to make sure that people
realize they are calling something heavyweight when they use the
revision traversal.
next prev parent reply other threads:[~2007-04-29 6:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-27 17:00 [PATCH 0/5] New for_each_revision() helper Luiz Fernando N. Capitulino
2007-04-27 17:00 ` [PATCH 1/5] Introduces " Luiz Fernando N. Capitulino
2007-04-27 19:32 ` Junio C Hamano
2007-04-27 21:13 ` Luiz Fernando N. Capitulino
2007-04-29 6:59 ` Junio C Hamano [this message]
2007-04-29 7:06 ` Shawn O. Pearce
2007-04-30 23:19 ` Junio C Hamano
2007-04-28 2:46 ` Johannes Schindelin
2007-04-28 11:50 ` Alex Riesen
2007-04-28 12:52 ` Johannes Schindelin
2007-04-28 16:02 ` Luiz Fernando N. Capitulino
2007-04-28 16:48 ` Alex Riesen
2007-04-29 13:04 ` Luiz Fernando N. Capitulino
2007-04-27 17:00 ` [PATCH 2/5] builtin-fmt-merge-msg.c: Use " Luiz Fernando N. Capitulino
2007-04-27 17:00 ` [PATCH 3/5] reachable.c: " Luiz Fernando N. Capitulino
2007-04-27 17:00 ` [PATCH 4/5] builtin-shortlog.c: " Luiz Fernando N. Capitulino
2007-04-27 17:00 ` [PATCH 5/5] builtin-log.c: " Luiz Fernando N. Capitulino
-- strict thread matches above, loose matches on Subject: below --
2007-04-26 19:46 [PATCH 0/5] RFC: " Luiz Fernando N Capitulino
2007-04-26 19:46 ` [PATCH 1/5] Introduces " Luiz Fernando N Capitulino
2007-04-26 19:59 ` Andy Whitcroft
2007-04-26 21:12 ` Luiz Fernando N. Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy7kbeke1.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=lcapitulino@mandriva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.