All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stephen Boyd <bebarino@gmail.com>
Cc: Pat Notz <patnotz@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] commit: add message options for rebase --autosquash
Date: Fri, 17 Sep 2010 11:21:16 -0700	[thread overview]
Message-ID: <7vzkvg2pur.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4C93288B.7000908@gmail.com> (Stephen Boyd's message of "Fri\, 17 Sep 2010 01\:36\:27 -0700")

Stephen Boyd <bebarino@gmail.com> writes:

> The whole point of squash is to combine two commit texts, right?
> Otherwise wouldn't you use --fixup where you throw away the text
> eventually and thus don't want to open an editor?

You mentioned almost everything I wanted to say.  I think --fixup makes
sense, but I doubt --squash does, _unless_ its interactactions with other
message pre-filling options, e.g. -m, -F, -c, are really well thought
out.

  parent reply	other threads:[~2010-09-17 18:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-17  1:39 [PATCH 0/2] Add commit message options for rebase --autosquash Pat Notz
2010-09-17  1:39 ` [PATCH 1/2] commit: add " Pat Notz
2010-09-17  8:36   ` Stephen Boyd
2010-09-17 15:34     ` Pat Notz
2010-09-17 16:14     ` Bryan Drewery
2010-09-17 17:07       ` Stephen Boyd
2010-09-17 17:47         ` Bryan Drewery
2010-09-17 18:21     ` Junio C Hamano [this message]
2010-09-17  1:39 ` [PATCH 2/2] t7500: add tests of commit --fixup/--squash Pat Notz
2010-09-21 20:24 ` [PATCHv2 0/4] Add commit message options for rebase --autosquash Pat Notz
2010-09-21 20:25 ` [PATCHv2 1/4] commit: --fixup option for use with " Pat Notz
2010-09-21 20:35   ` Sverre Rabbelier
2010-09-22 18:01   ` Pat Notz
2010-09-21 20:25 ` [PATCHv2 2/4] t7500: add tests of commit --fixup Pat Notz
2010-09-21 20:25 ` [PATCHv2 3/4] commit: --squash option for use with rebase --autosquash Pat Notz
2010-09-22 18:02   ` Pat Notz
2010-09-21 20:25 ` [PATCHv2 4/4] t7500: add tests of commit --squash Pat Notz
2010-09-21 20:36   ` Ævar Arnfjörð Bjarmason
2010-09-22 17:59     ` Pat Notz
2010-09-22 18:12       ` Ævar Arnfjörð Bjarmason
2010-09-22 18:16         ` Pat Notz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vzkvg2pur.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=patnotz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.