From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 582D5C3A5A3 for ; Tue, 27 Aug 2019 13:15:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1FED1206BF for ; Tue, 27 Aug 2019 13:15:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=newmedia-net.de header.i=@newmedia-net.de header.b="eoODabQc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727784AbfH0NPJ (ORCPT ); Tue, 27 Aug 2019 09:15:09 -0400 Received: from webmail.newmedia-net.de ([185.84.6.166]:58416 "EHLO webmail.newmedia-net.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725920AbfH0NPJ (ORCPT ); Tue, 27 Aug 2019 09:15:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=newmedia-net.de; s=mikd; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=9fuge9gHfWzyABbPL4HNUzYARK+xus4TfcOn8NSHkiY=; b=eoODabQcl0AlBg4SL0Rom5QP5YtJ/Pme4H1Q9RaxzT+iLJ+2v7T+trrMMs1bW5P39uXlL1p+P2WUp1DeH3bdWpdY7q0E2mIqWhL/OkSmIab0Dacwx5N1Yr6AMV4Gzdy7HXE4SXGjn0opOro5e/XkVAp3K1C/ZtbQUjVQTsNy8I8=; Subject: Re: Implementing Mikrotik IE To: Johannes Berg , Josef Miegl Cc: linux-wireless References: <20190815152844.k5mmddvbwrohkzr6@pepin-laptop.localdomain> <3a079683-6f57-3b42-f909-90c46e14f14f@newmedia-net.de> <20190816111044.4ntizgmpa3twbzcg@pepin-laptop.localdomain> <20190816113818.ohktykc4fyetzyvq@pepin-laptop.localdomain> <9985fddfb059640f36665efc9c1ef2dc0bdb7662.camel@sipsolutions.net> <20190819113706.ujsz67sxcwt2ulmt@pepin-laptop.localdomain> <6efb9b56c77cd9ea945f89c3371b49c301dc2b4e.camel@sipsolutions.net> <58A25955-2A17-4DE7-82FB-3B20E00C96EC@miegl.cz> <5ee160209eb1f9e70f6224c393389266280d7d80.camel@sipsolutions.net> <0452a0cbb36bcffa8371a58dfd931864c1f79eef.camel@sipsolutions.net> <68A3B9AF-8864-4C0F-A50B-71CCB76AE81D@miegl.cz> <21433c24-4860-be12-8d79-11e954e0bf9d@newmedia-net.de> From: Sebastian Gottschall Message-ID: <80063559-afc5-b352-e5ca-6138a6048ee0@newmedia-net.de> Date: Tue, 27 Aug 2019 15:14:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Received: from [212.111.244.1] (helo=[172.29.0.186]) by webmail.newmedia-net.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.72) (envelope-from ) id 1i2bJa-0005Yy-RT; Tue, 27 Aug 2019 15:15:14 +0200 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Am 27.08.2019 um 15:10 schrieb Johannes Berg: > On Tue, 2019-08-27 at 15:08 +0200, Sebastian Gottschall wrote: >> Am 22.08.2019 um 23:06 schrieb Josef Miegl: >>> On August 22, 2019 10:08:13 PM GMT+02:00, Johannes Berg wrote: >>>> On Thu, 2019-08-22 at 09:00 +0200, Johannes Berg wrote: >>>>> Perhaps it expects the 4-way-HS to already be in 4-addr frame format, >>>> or >>>>> something else special in the 4-way-HS if you have WDS? >>>> I think this is actually the right guess. >>> Yes, it indeed it! Thank you so much Johannes! >> good finding. my idea here is if we parse the wds flags field from mtik >> ie within mac80211 we could also support this special handing without >> any workaround > The same holds true if we parse it in hostapd, and add a flag to the > EAPOL to control the encapsulation, which is way more general, so much > preferable IMHO. i know .same result and i know that the userspace solution is more prefered Sebastian > > johannes > >