From: Daniel Scally <djrscally@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Clément Léger" <clement.leger@bootlin.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] software node: fix wrong node passed to find nargs_prop
Date: Tue, 21 Dec 2021 22:09:45 +0000 [thread overview]
Message-ID: <800d89c5-c9e3-d969-ea9a-08ec0362a90c@gmail.com> (raw)
In-Reply-To: <YcGiIHAJS7/qXcJv@paasikivi.fi.intel.com>
Hi Sakari
On 21/12/2021 09:45, Sakari Ailus wrote:
> Hi Greg, Andy,
>
> On Tue, Dec 21, 2021 at 10:34:11AM +0100, Greg Kroah-Hartman wrote:
>> On Mon, Dec 20, 2021 at 11:37:07PM +0000, Daniel Scally wrote:
>>> Thanks Andy
>>>
>>> On 20/12/2021 22:13, Andy Shevchenko wrote:
>>>> + Sakari, Dan
>>>>
>>>> On Monday, December 20, 2021, Clément Léger <clement.leger@bootlin.com
>>>> <mailto:clement.leger@bootlin.com>> wrote:
>>>>
>>>> nargs_prop refers to a property located in the reference that is found
>>>> within the nargs property.
>>>
>>> I think this is right (it's not used in the ACPI version, and the OF
>>> version is quite convoluted so a bit hard to follow)...but also I note
>>> that none of the users of fwnode_property_get_reference_args() pass
>>> anything to nargs_prop anyway...do we even need this?
>>
>> Looks like it is unused, please just remove it.
>
> If you remove nargs_prop argument, then callers will have to use OF
> property API instead to parse references with property-defined number of
> arguments. The goal has been to cover all functionality in a
> firmware-independent way.
My mistake, I missed that of_parse_phandle_with_args() has a ton of
direct users. I guess we should try to replace those with
fwnode_property_get_reference_args() where appropriate.
next prev parent reply other threads:[~2021-12-21 22:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 21:05 [PATCH] software node: fix wrong node passed to find nargs_prop Clément Léger
[not found] ` <CAHp75Vf+F2L4EFmokRYD+-M9hSuz+SbiiWnqHvFZttRyfKS-mg@mail.gmail.com>
2021-12-20 23:37 ` Daniel Scally
2021-12-21 9:34 ` Greg Kroah-Hartman
2021-12-21 9:45 ` Sakari Ailus
2021-12-21 22:09 ` Daniel Scally [this message]
2021-12-22 9:34 ` Sakari Ailus
2021-12-21 9:46 ` Clément Léger
2021-12-21 22:08 ` Daniel Scally
2021-12-21 11:52 ` Sakari Ailus
2021-12-22 11:19 ` Heikki Krogerus
2021-12-22 17:27 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=800d89c5-c9e3-d969-ea9a-08ec0362a90c@gmail.com \
--to=djrscally@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=clement.leger@bootlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.