From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3256C43460 for ; Fri, 23 Apr 2021 15:45:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78D2361404 for ; Fri, 23 Apr 2021 15:45:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242623AbhDWPqY (ORCPT ); Fri, 23 Apr 2021 11:46:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230294AbhDWPqV (ORCPT ); Fri, 23 Apr 2021 11:46:21 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C50CC061574; Fri, 23 Apr 2021 08:45:45 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id a12so34328924pfc.7; Fri, 23 Apr 2021 08:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=xVcqGlzpyrQHNmToxJ7ZnGOGDgcVdGv3b8uz5G7yLRM=; b=MfCOYQ7+QkiuAqFXjNyCl3AQCTca/IPTcblAM4Hg6d3RhpTMT2WBStXyvQI49KWb6H MbLXF2DNQ0E+7mFIN/vs+jkFznXXfHL+Z9UbPbtA6xh9VPYIRJqcUZtv8epFTxk8qgV2 HPcF7i0Mo4PrfTNo1LQzvvSzdcSOH+2eyLi7pRx1LHuV+fN849SvA0ez5+y27eWhPnhL fclz5ZQTsdPWSRaFBYN31MFeNwT4ucAsvoKoShj6U6rghZsgSMsPRHDFDMVLKlWeRgPY tlZlnuVy1Ge/P4cdjlCEr17+7D8wGxr7/kaKqam36GVb+sjZlb5p+nc8+sUDXjWJSrT8 ACuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xVcqGlzpyrQHNmToxJ7ZnGOGDgcVdGv3b8uz5G7yLRM=; b=TEoCScPfJma0WMNOjW7bxRPRA8Ioj/3QgwiSw8FrWlmV2eTzXc3m222wO+6cFJvqHD jb0lW3y5hxgF3DQEVOuoyBx3LzLiHJSiNAlOIsmmhjILkyFjoDhBtMCniqt63wMv0qmR 3cyq4ZWLnF45j2MGIVV5ikbl9RZeDUT6pVccOVL/+dW0zQcsdNDcJNzwZ3yc3bGBrEoE IyQ7XfMr3zLwsan7BLIENmycUCcW2o9qTr2gJXGTb6V4nhYfoyMidOPzxyS/1y+Zn15u EP1tLOHlHgFNkWGb5IBebsU2ikq6fUIOiHYUcwZ3OFY5nyR6wtIStteQ80O+kifIKhtm rM2g== X-Gm-Message-State: AOAM532127FbxvhtbPIUWMjROjHPDhib3q6GMF08cC+eBNGa4ivfhozR n4y9zo0weJEWg7tW3P2nMMningvUQSY= X-Google-Smtp-Source: ABdhPJxMlBmMG7vSUI9BH9dYl6JGX6gw0FsoAOwoI0X9yC0u3xDMjYH9BLWIehqsPteetytEj9M95g== X-Received: by 2002:a63:b515:: with SMTP id y21mr4423576pge.253.1619192744212; Fri, 23 Apr 2021 08:45:44 -0700 (PDT) Received: from [10.230.29.202] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id g1sm5509326pgi.64.2021.04.23.08.45.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Apr 2021 08:45:43 -0700 (PDT) Subject: Re: [PATCH] mips/bcm63xx: Use BUG_ON instead of if condition followed by BUG To: zhouchuangao , Thomas Bogendoerfer , bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1619166623-70445-1-git-send-email-zhouchuangao@vivo.com> From: Florian Fainelli Message-ID: <800fd777-dc61-07e0-bc13-bb95a0924335@gmail.com> Date: Fri, 23 Apr 2021 08:45:41 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <1619166623-70445-1-git-send-email-zhouchuangao@vivo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/23/2021 1:30 AM, zhouchuangao wrote: > BUG_ON uses unlikely in if(), it can be optimized at compile time. > > Usually, the condition in if() is not satisfied. In my opinion, > this can improve the efficiency of the multi-stage pipeline. > > Signed-off-by: zhouchuangao Acked-by: Florian Fainelli Subject prefix should have been: MIPS: BCM63XX: Use BUG_ON instead of condition followed by BUG to match prior submissions done to this directory. Thanks. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E6E3C433ED for ; Fri, 23 Apr 2021 15:47:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EA13613D8 for ; Fri, 23 Apr 2021 15:47:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EA13613D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mxAiSy4pRzPhOEX7LWMwqHjv9Pg4D3qjFTUeNuHyBeo=; b=f+hbqrnRH2Pwx6zcyMJKCM3+8 S7ZibnDRfmPhXhaqAn84g0pPmV6AIrcejboSrdMznP6fJNaQyXj9a30WSFGxhoG4AkjH+j0N21nO8 q+XMVa3v6oiUZZPd7ApA8AMvTnexD45Yiqccf2u0aDwmYvNgandPtEYLOI9svKu7ZsR+FViLX1RXE qUdxN/8r6pTlfkcKZ9Z4Svtip8Og+4IPvCve+ajzcWSEFjIiFKz+COzbnH2yJuX16P/SdcqvuMdLf l9k7BIDmQQeqXb7AUePl4JfodVQ0Saa6bBXJLXyZe1dkld3+votGGN4h90WqdHL8NUY7mP6DULXOF Vl3W54zng==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZy07-001nXf-Po; Fri, 23 Apr 2021 15:45:52 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZy04-001nWw-56 for linux-arm-kernel@desiato.infradead.org; Fri, 23 Apr 2021 15:45:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Sender:Reply-To:Cc:Content-ID:Content-Description; bh=xVcqGlzpyrQHNmToxJ7ZnGOGDgcVdGv3b8uz5G7yLRM=; b=WC+fB4jTPubgrNU2DvxfjVk4GT m1/YR+cA8CWUoLcW+DEw982vJId2L4a4QAJOnCiN9Y0v72vzkFBTkHp8DKOw0A+t8SSL7pw6LdMaO zYdArfPBuW8wKWnlwvFNBCOAEIn8PwN/C5Ne2QxJ9rVEsOP4rQnVN5Ib+kOljZSgair3zrFeZ9qDo yrZsnPOPFi2S3+o24LLWnzSisimfhNc9SrkaUE/A/uxMEnR7ZA5yzE3twt0FCG3AU5QGPt7fbGZvq XAl3klz5KaPqyS3TRAYlhzViS30LFHbow+MRi9NrYlBpRoyDU0hgGdpVSFOeEmGuRs7lSDmthqLm5 IHzr5G0A==; Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZy01-00EWSp-Dd for linux-arm-kernel@lists.infradead.org; Fri, 23 Apr 2021 15:45:46 +0000 Received: by mail-pg1-x52d.google.com with SMTP id m12so14739978pgr.9 for ; Fri, 23 Apr 2021 08:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=xVcqGlzpyrQHNmToxJ7ZnGOGDgcVdGv3b8uz5G7yLRM=; b=MfCOYQ7+QkiuAqFXjNyCl3AQCTca/IPTcblAM4Hg6d3RhpTMT2WBStXyvQI49KWb6H MbLXF2DNQ0E+7mFIN/vs+jkFznXXfHL+Z9UbPbtA6xh9VPYIRJqcUZtv8epFTxk8qgV2 HPcF7i0Mo4PrfTNo1LQzvvSzdcSOH+2eyLi7pRx1LHuV+fN849SvA0ez5+y27eWhPnhL fclz5ZQTsdPWSRaFBYN31MFeNwT4ucAsvoKoShj6U6rghZsgSMsPRHDFDMVLKlWeRgPY tlZlnuVy1Ge/P4cdjlCEr17+7D8wGxr7/kaKqam36GVb+sjZlb5p+nc8+sUDXjWJSrT8 ACuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xVcqGlzpyrQHNmToxJ7ZnGOGDgcVdGv3b8uz5G7yLRM=; b=h4aOekj4gtPHyvDk5DIFINiDXfsa7dIK7VPo3zeGc34qYC3BNRbB6NORjImSyyEoSv nwkb5lg4hH1gBUfA6OSFmpJDXNPpiVL6dXfZU9rMIp72+U6MZDYwyg8fNCYt0c1gxmJ5 Jd+8g82BeIF02CljamdPywlGOr4ZqKyFcl5ILM8mbHzIUAJVXDqoNxAswhHkn8G65EJ+ yHsTgxhCuZOnYEFdk5Pde62nN9JerzxV91b83NA52E6d8NzoRidO3lpzUGK+R3C3mOGH 2OAwls9a3EZCR0WrUxy7XjJPe7HIwjWA1Wbnyd58lVXZryr9/V4ruyWcIH4ilCc6Lqcj Htvg== X-Gm-Message-State: AOAM532D1ksFeOHSdxRpI9n6+VSvzry8Fa6lMByeYcG7MTFIo5I/L0Vq J4mmURCixjLUdKsxB3KkrKc= X-Google-Smtp-Source: ABdhPJxMlBmMG7vSUI9BH9dYl6JGX6gw0FsoAOwoI0X9yC0u3xDMjYH9BLWIehqsPteetytEj9M95g== X-Received: by 2002:a63:b515:: with SMTP id y21mr4423576pge.253.1619192744212; Fri, 23 Apr 2021 08:45:44 -0700 (PDT) Received: from [10.230.29.202] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id g1sm5509326pgi.64.2021.04.23.08.45.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Apr 2021 08:45:43 -0700 (PDT) Subject: Re: [PATCH] mips/bcm63xx: Use BUG_ON instead of if condition followed by BUG To: zhouchuangao , Thomas Bogendoerfer , bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1619166623-70445-1-git-send-email-zhouchuangao@vivo.com> From: Florian Fainelli Message-ID: <800fd777-dc61-07e0-bc13-bb95a0924335@gmail.com> Date: Fri, 23 Apr 2021 08:45:41 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <1619166623-70445-1-git-send-email-zhouchuangao@vivo.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210423_084545_488018_C5BEC53B X-CRM114-Status: UNSURE ( 8.36 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/23/2021 1:30 AM, zhouchuangao wrote: > BUG_ON uses unlikely in if(), it can be optimized at compile time. > > Usually, the condition in if() is not satisfied. In my opinion, > this can improve the efficiency of the multi-stage pipeline. > > Signed-off-by: zhouchuangao Acked-by: Florian Fainelli Subject prefix should have been: MIPS: BCM63XX: Use BUG_ON instead of condition followed by BUG to match prior submissions done to this directory. Thanks. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel