From: Laurent Vivier <laurent@vivier.eu>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"QEMU Trivial" <qemu-trivial@nongnu.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Roman Bolshakov" <r.bolshakov@yadro.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v2 2/4] Makefile: Require GNU make 3.82+
Date: Sun, 13 Dec 2020 23:56:22 +0100 [thread overview]
Message-ID: <8010190c-6265-2dbb-cb55-25353d9922ec@vivier.eu> (raw)
In-Reply-To: <CAFEAcA_XA1FcQos+m0vv6DVkbaybYwX5ytsM5gMaLAtL0jGGgA@mail.gmail.com>
Le 13/12/2020 à 20:04, Peter Maydell a écrit :
> On Sun, 13 Dec 2020 at 17:22, Laurent Vivier <laurent@vivier.eu> wrote:
>>
>> Le 12/10/2020 à 11:47, Thomas Huth a écrit :
>>> On 25/08/2020 22.27, Roman Bolshakov wrote:
>>>> QEMU build fails with cryptic messages if make is too old:
>>>>
>>>> Makefile.ninja:2655: *** multiple target patterns. Stop.
>>>>
>>>> To avoid the confusion it's worth to fail the build right away and print
>>>> a friendly error message.
>>>>
>>>> +ifeq ($(filter undefine,$(value .FEATURES)),)
>>>> +$(error Unsupported Make version: $(MAKE_VERSION). \
>>>> + Please use GNU Make 3.82 or above)
>>>> +endif
>>>> +
>>>> # Always point to the root of the build tree (needs GNU make).
>>>> BUILD_DIR=$(CURDIR)
>>>
>>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>>
>>>
>>
>> Applied to my trivial-patches branch.
>
> Commit 09e93326e448ab4 says that the switch to ninja from
> ninjatool removed the requirement for Make 3.82. Is this
> change still required?
>
It seems 09e93326e448ab4 has been committed on 17th of October, so after Thomas' review.
I remove it from my queue.
Thanks,
Laurent
next prev parent reply other threads:[~2020-12-13 22:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 20:27 [PATCH v2 0/4] Compatibility make fixes for meson Roman Bolshakov
2020-08-25 20:27 ` [PATCH v2 1/4] configure: Use discovered make for in-source build Roman Bolshakov
2020-08-25 20:27 ` [PATCH v2 2/4] Makefile: Require GNU make 3.82+ Roman Bolshakov
2020-10-12 9:47 ` Thomas Huth
2020-12-13 17:21 ` Laurent Vivier
2020-12-13 19:04 ` Peter Maydell
2020-12-13 22:56 ` Laurent Vivier [this message]
2020-12-14 13:46 ` Roman Bolshakov
2020-08-25 20:27 ` [PATCH v2 3/4] configure: Prefer gmake on darwin Roman Bolshakov
2020-08-25 20:27 ` [PATCH v2 4/4] configure: Test if $make actually exists Roman Bolshakov
2020-10-12 9:49 ` Thomas Huth
2020-12-13 17:22 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8010190c-6265-2dbb-cb55-25353d9922ec@vivier.eu \
--to=laurent@vivier.eu \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.