All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Kacur <jkacur@redhat.com>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Daniel Wagner <dwagner@suse.de>,
	Clark Williams <williams@redhat.com>,
	linux-rt-users@vger.kernel.org, Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH rt-tests v1 1/2] rt-utils: Call get_timestmap() in rt_init()
Date: Tue, 29 Jun 2021 23:05:37 -0400 (EDT)	[thread overview]
Message-ID: <801072c7-a6c9-ccb0-471-d89d51b2cc3d@redhat.com> (raw)
In-Reply-To: <87r1gl6uhm.fsf@kurt>



On Tue, 29 Jun 2021, Kurt Kanzenbach wrote:

> Hi Daniel,
> 
> On Mon Jun 28 2021, Daniel Wagner wrote:
> > Move the get_timestamp() from rt_test_start() to rt_init(). The idea
> > of rt_test_start() was to get the start timestamp right before the
> > 'main loop' for the test starts. At least for cyclictest the
> > rt_test_start() was placed wrongly so that the first test cycle could
> > hit the pagefault when strftime() wrote into the tsbuf.
> >
> > We don't have an exact semantic description what start test timestamp
> > means, so the simplest thing to avoid any further problems with it, is
> > to take the timestamp right at the beginning when the program
> > starts. Most test programs have a very short setup phase anyway.
> >
> > Reported-by: Mike Galbraith <efault@gmx.de>
> > Signed-off-by: Daniel Wagner <dwagner@suse.de>
> 
> This fixes the issue for me:
> 
> Tested-by: Kurt Kanzenbach <kurt@linutronix.de>
> 
> Thanks,
> Kurt
> 

thanks, added


  reply	other threads:[~2021-06-30  3:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 20:12 [PATCH rt-tests v1 0/2] Fix for start timestamp Daniel Wagner
2021-06-28 20:12 ` [PATCH rt-tests v1 1/2] rt-utils: Call get_timestmap() in rt_init() Daniel Wagner
2021-06-29  6:43   ` Kurt Kanzenbach
2021-06-30  3:05     ` John Kacur [this message]
2021-06-30  3:04   ` John Kacur
2021-06-28 20:12 ` [PATCH rt-tests v1 2/2] rt-utils: Remove empty rt_test_start() Daniel Wagner
2021-06-30  3:05   ` John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=801072c7-a6c9-ccb0-471-d89d51b2cc3d@redhat.com \
    --to=jkacur@redhat.com \
    --cc=dwagner@suse.de \
    --cc=efault@gmx.de \
    --cc=kurt@linutronix.de \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.