From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754397AbbIPKHM (ORCPT ); Wed, 16 Sep 2015 06:07:12 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:62860 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753784AbbIPKHH (ORCPT ); Wed, 16 Sep 2015 06:07:07 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Andrzej Hajda , Roland Stigge , Marek Szyprowski , linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 01/31] arch/arm/mach-lpc32xx: use kmemdup rather than duplicating its implementation Date: Wed, 16 Sep 2015 12:06:36 +0200 Message-ID: <80137044.ODrprXt1av@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <55F93BE5.60508@samsung.com> References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-2-git-send-email-a.hajda@samsung.com> <55F93BE5.60508@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:R46GNqFeUJhW8KFmV3xFbCv7cEqYcb+EbJw8ksWlA8tJlHmIFjo iDX1ecYEmimGG6CKgnA4qJC0/S+eIuix0+IySxWEol9Jh175uYT4vQ8lmXOyIWSKpbTfMaG keHF4/nT4tbWMoT6JfMLXHj5xnE67EnInfSYIxRv04IJTHFvpIgXXQy3NdSAwEXR8UoGbvA poaiFEolBm6cJHv+VtBMw== X-UI-Out-Filterresults: notjunk:1;V01:K0:jMypdc5ANFc=:nruRDbVixP1SduQMmL/li1 u8Pw3gr2Zrb/KkilbJHT9HiFRDQk2tiFBE+rPgAJZ0Nqc97ORHZxWku3BDgxgfPq3T/Idsf3p Wa7VdA0BPYmkr3xRc2ASkx0hmgHHA0pfqlXjwCPTE3NgKoJo0lH38bVc+qexqBGmMraF4t1qJ f4OmBbgr99J0GFUYgGM7x8vRMPqi4dutws9L4FUJZRz5MvDKwlV6BBGzhcRYu2APYpmfVOmBl mPtm39ogbbZLDfcw23e/p7AG8NojKEw6zARm8LZ+Km//ZlVdR4fFs+A9DO4CTrY9clFdXQ1WF AwGtXHz8X7kyTBaC5h+QeuO4Q8NhGX8AihnspgATA2SJo6ygHPnYTpBa+xz+feu+DdDZZ94yQ 8cpFoNZf2oA0Hr/DWVj1xNZp2OiOOgGHZyHCkMmmh2JHSSkTid/9DG0W29EQXHqJQEeV1uND7 LE+0pZH9d40ErKJgJotA+XfSE8wzfPBfCPTdBPZOW8h8BlRpPmUgqKNwhejDT1ibIRwpaFugy K2VNncnxUm0XjfargAos2raycEFdptXndgDmPGgl90ZYUatdERIa/9s36Zqbb5ZzJ4XD3bU6t +YBq3BUb9aQZEf9RQ+BnFrilxNIVRGQH9PyUnHXAvElyqcH0gkN1Zh/lPjrXKbAVa/FfVlVBy C3m7lxBqPPRfm2jq7U2teq19U7+D7OKeQhpk/e5hxfSa1ULNFJ60PZPa8WS4UgZDHu/0AW2nV S/ZF6sPzN/QB0RjS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 16 September 2015 11:52:37 Andrzej Hajda wrote: > > @@ -87,7 +87,8 @@ static int lpc32xx_pm_enter(suspend_state_t state) > > void *iram_swap_area; > > > > /* Allocate some space for temporary IRAM storage */ > > - iram_swap_area = kmalloc(lpc32xx_sys_suspend_sz, GFP_KERNEL); > > + iram_swap_area = kmemdup((void *)TEMP_IRAM_AREA, > > + lpc32xx_sys_suspend_sz, GFP_KERNEL); > > if (!iram_swap_area) { > > printk(KERN_ERR > > "PM Suspend: cannot allocate memory to save portion " > > @@ -95,10 +96,6 @@ static int lpc32xx_pm_enter(suspend_state_t state) > > return -ENOMEM; > > } > > > > - /* Backup a small area of IRAM used for the suspend code */ > > - memcpy(iram_swap_area, (void *) TEMP_IRAM_AREA, > > - lpc32xx_sys_suspend_sz); > Hmm, the patch looks correct in principle, but I think I'd rather leave the original version with the comment in place, because the source is not just random memory but instead some SRAM. We might want to use memcpy_fromio()/memcpy_toio here and remove the cast for both copies instead. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 16 Sep 2015 12:06:36 +0200 Subject: [PATCH 01/31] arch/arm/mach-lpc32xx: use kmemdup rather than duplicating its implementation In-Reply-To: <55F93BE5.60508@samsung.com> References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-2-git-send-email-a.hajda@samsung.com> <55F93BE5.60508@samsung.com> Message-ID: <80137044.ODrprXt1av@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 16 September 2015 11:52:37 Andrzej Hajda wrote: > > @@ -87,7 +87,8 @@ static int lpc32xx_pm_enter(suspend_state_t state) > > void *iram_swap_area; > > > > /* Allocate some space for temporary IRAM storage */ > > - iram_swap_area = kmalloc(lpc32xx_sys_suspend_sz, GFP_KERNEL); > > + iram_swap_area = kmemdup((void *)TEMP_IRAM_AREA, > > + lpc32xx_sys_suspend_sz, GFP_KERNEL); > > if (!iram_swap_area) { > > printk(KERN_ERR > > "PM Suspend: cannot allocate memory to save portion " > > @@ -95,10 +96,6 @@ static int lpc32xx_pm_enter(suspend_state_t state) > > return -ENOMEM; > > } > > > > - /* Backup a small area of IRAM used for the suspend code */ > > - memcpy(iram_swap_area, (void *) TEMP_IRAM_AREA, > > - lpc32xx_sys_suspend_sz); > Hmm, the patch looks correct in principle, but I think I'd rather leave the original version with the comment in place, because the source is not just random memory but instead some SRAM. We might want to use memcpy_fromio()/memcpy_toio here and remove the cast for both copies instead. Arnd