All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joao Pinto <Joao.Pinto@synopsys.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>,
	Joao Pinto <Joao.Pinto@synopsys.com>
Cc: <linux-kernel@vger.kernel.org>, <ijc+devicetree@hellion.org.uk>,
	<liviu.dudau@arm.com>, <ryan.harkin@linaro.org>
Subject: Re: [PATCH 3/3] tda998x: add HPD delay to avoid disabling sound when EDID checksum fails.
Date: Tue, 31 May 2016 17:58:31 +0100	[thread overview]
Message-ID: <801ce163-b8ac-3375-56f2-9a8d7cd70ded@synopsys.com> (raw)
In-Reply-To: <20160530191044.GR19428@n2100.arm.linux.org.uk>

Hi Russell,

On 5/30/2016 8:10 PM, Russell King - ARM Linux wrote:
> On Mon, May 30, 2016 at 04:15:54PM +0100, Joao Pinto wrote:
>> When using ffplay to reproduce video+sound it was noticed that sometimes the
>> sound was disabled. The cause was an initial EDID checksum error that disabled

(...)

>> @@ -1313,6 +1324,7 @@ static int tda998x_create(struct i2c_client *client, struct tda998x_priv *priv)
>>  
>>  		/* init read EDID waitqueue and HDP work */
>>  		init_waitqueue_head(&priv->wq_edid);
>> +		INIT_DELAYED_WORK(&priv->dwork, tda998x_hpd);
>>  
>>  		/* clear pending interrupts */
>>  		reg_read(priv, REG_INT_FLAGS_0);
> 
> Clearly, this patch is incomplete.  There's nothing that schedules this
> work to be run.

You are right, forgot to include the schedule in the patch!

> 
> In any case, this is reintroducing the code which I deleted when I fixed
> the (rather crappy) previous implemention of delaying the EDID read after
> a hotplug event.  You should not need this patch.
> 

If a checksum validation fails the video reproduction is done muted if you use a
simple app like ffplay. This does not happen if using mplayer.

Could you please check the sound support patch?

Thanks,
Joao

  reply	other threads:[~2016-05-31 17:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-30 15:15 [PATCH 0/3] tda998x: add sound support Joao Pinto
2016-05-30 15:15 ` [PATCH 1/3] tda998x: adding " Joao Pinto
2016-05-30 15:15 ` [PATCH 2/3] tda998x: adding sound support for Juno in the DT Joao Pinto
2016-05-30 15:15 ` [PATCH 3/3] tda998x: add HPD delay to avoid disabling sound when EDID checksum fails Joao Pinto
2016-05-30 19:10   ` Russell King - ARM Linux
2016-05-31 16:58     ` Joao Pinto [this message]
2016-06-01 16:32       ` Russell King - ARM Linux
2016-06-01 16:38         ` Joao Pinto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=801ce163-b8ac-3375-56f2-9a8d7cd70ded@synopsys.com \
    --to=joao.pinto@synopsys.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=liviu.dudau@arm.com \
    --cc=ryan.harkin@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.