From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C23C35666 for ; Sat, 22 Feb 2020 16:31:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15908206ED for ; Sat, 22 Feb 2020 16:31:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727053AbgBVQbe (ORCPT ); Sat, 22 Feb 2020 11:31:34 -0500 Received: from mx2.yrkesakademin.fi ([85.134.45.195]:22755 "EHLO mx2.yrkesakademin.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726550AbgBVQbe (ORCPT ); Sat, 22 Feb 2020 11:31:34 -0500 X-Greylist: delayed 902 seconds by postgrey-1.27 at vger.kernel.org; Sat, 22 Feb 2020 11:31:33 EST Subject: Re: Regression in 5.4 kernel on 32-bit Radeon IBM T40 To: =?UTF-8?Q?Christian_K=c3=b6nig?= , Christoph Hellwig , Woody Suwalski CC: DRI mailing list , LKML , "Deucher, Alexander" , Pavel Machek References: <400f6ce9-e360-0860-ca2a-fb8bccdcdc9b@gmail.com> <20200109141436.GA22111@lst.de> <9ad75215-3ff1-ee76-9985-12fd78d6aa5f@amd.com> From: Thomas Backlund Message-ID: <801e4196-5e22-e805-4d45-0245efdaa508@mageia.org> Date: Sat, 22 Feb 2020 18:16:28 +0200 MIME-Version: 1.0 In-Reply-To: <9ad75215-3ff1-ee76-9985-12fd78d6aa5f@amd.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 09-01-2020 kl. 17:12, skrev Christian König: > Hi Christoph, > > Am 09.01.20 um 15:14 schrieb Christoph Hellwig: >> Hi Woody, >> >> sorry for the late reply, I've been off to a vacation over the holidays. >> >> On Sat, Dec 14, 2019 at 10:17:15PM -0500, Woody Suwalski wrote: >>> Regression in 5.4 kernel on 32-bit Radeon IBM T40 >>> triggered by >>> commit 33b3ad3788aba846fc8b9a065fe2685a0b64f713 >>> Author: Christoph Hellwig >>> Date:   Thu Aug 15 09:27:00 2019 +0200 >>> >>> Howdy, >>> The above patch has triggered a display problem on IBM Thinkpad T40, >>> where >>> the screen is covered with a lots of random short black horizontal >>> lines, >>> or distorted letters in X terms. >>> >>> The culprit seems to be that the dma_get_required_mask() is returning a >>> value 0x3fffffff >>> which is smaller than dma_get_mask()0xffffffff.That results in >>> dma_addressing_limited()==0 in ttm_bo_device(), and using 40-bits dma >>> instead of 32-bits. >> Which is the intended behavior assuming your system has 1GB of memory. >> Does it? > > Assuming the system doesn't have the 1GB split up somehow crazy over the > address space that should indeed work as intended. > >> >>> If I hardcode "1" as the last parameter to ttm_bo_device_init() in >>> place of >>> a call to dma_addressing_limited(),the problem goes away. >> I'll need some help from the drm / radeon / TTM maintainers if there are >> any other side effects from not passing the need_dma32 paramters. >> Obviously if the device doesn't have more than 32-bits worth of dram and >> no DMA offset we can't feed unaddressable memory to the device. >> Unfortunately I have a very hard time following the implementation of >> the TTM pool if it does anything else in this case. > > The only other thing which comes to mind is using huge pages. Can you > try a kernel with CONFIG_TRANSPARENT_HUGEPAGE disabled? > Any progress on this ? We have a bugreport in Mageia with the hw: Dell Inspiron 5100, 32-bit P4 processor, 2GB of RAM, Radeon Mobility 7500 (RV200) graphics that gets display issues too and reverting the offending commit restores normal behaviour. and the same issue is still there with 5.5 series kernels. -- Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61CDEC35679 for ; Mon, 24 Feb 2020 09:20:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21F5F20836 for ; Mon, 24 Feb 2020 09:20:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21F5F20836 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mageia.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 04F40899DB; Mon, 24 Feb 2020 09:20:28 +0000 (UTC) X-Greylist: delayed 907 seconds by postgrey-1.36 at gabe; Sat, 22 Feb 2020 16:31:39 UTC Received: from mx1.yrkesakademin.fi (mx1.yrkesakademin.fi [85.134.45.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E27B6E95E for ; Sat, 22 Feb 2020 16:31:39 +0000 (UTC) Subject: Re: Regression in 5.4 kernel on 32-bit Radeon IBM T40 To: =?UTF-8?Q?Christian_K=c3=b6nig?= , Christoph Hellwig , Woody Suwalski References: <400f6ce9-e360-0860-ca2a-fb8bccdcdc9b@gmail.com> <20200109141436.GA22111@lst.de> <9ad75215-3ff1-ee76-9985-12fd78d6aa5f@amd.com> From: Thomas Backlund Message-ID: <801e4196-5e22-e805-4d45-0245efdaa508@mageia.org> Date: Sat, 22 Feb 2020 18:16:28 +0200 MIME-Version: 1.0 In-Reply-To: <9ad75215-3ff1-ee76-9985-12fd78d6aa5f@amd.com> Content-Language: en-US X-Mailman-Approved-At: Mon, 24 Feb 2020 09:20:26 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Deucher, Alexander" , Pavel Machek , LKML , DRI mailing list Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" RGVuIDA5LTAxLTIwMjAga2wuIDE3OjEyLCBza3JldiBDaHJpc3RpYW4gS8O2bmlnOgo+IEhpIENo cmlzdG9waCwKPiAKPiBBbSAwOS4wMS4yMCB1bSAxNToxNCBzY2hyaWViIENocmlzdG9waCBIZWxs d2lnOgo+PiBIaSBXb29keSwKPj4KPj4gc29ycnkgZm9yIHRoZSBsYXRlIHJlcGx5LCBJJ3ZlIGJl ZW4gb2ZmIHRvIGEgdmFjYXRpb24gb3ZlciB0aGUgaG9saWRheXMuCj4+Cj4+IE9uIFNhdCwgRGVj IDE0LCAyMDE5IGF0IDEwOjE3OjE1UE0gLTA1MDAsIFdvb2R5IFN1d2Fsc2tpIHdyb3RlOgo+Pj4g UmVncmVzc2lvbiBpbiA1LjQga2VybmVsIG9uIDMyLWJpdCBSYWRlb24gSUJNIFQ0MAo+Pj4gdHJp Z2dlcmVkIGJ5Cj4+PiBjb21taXQgMzNiM2FkMzc4OGFiYTg0NmZjOGI5YTA2NWZlMjY4NWEwYjY0 ZjcxMwo+Pj4gQXV0aG9yOiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4KPj4+IERhdGU6 wqDCoCBUaHUgQXVnIDE1IDA5OjI3OjAwIDIwMTkgKzAyMDAKPj4+Cj4+PiBIb3dkeSwKPj4+IFRo ZSBhYm92ZSBwYXRjaCBoYXMgdHJpZ2dlcmVkIGEgZGlzcGxheSBwcm9ibGVtIG9uIElCTSBUaGlu a3BhZCBUNDAsIAo+Pj4gd2hlcmUKPj4+IHRoZSBzY3JlZW4gaXMgY292ZXJlZCB3aXRoIGEgbG90 cyBvZiByYW5kb20gc2hvcnQgYmxhY2sgaG9yaXpvbnRhbCAKPj4+IGxpbmVzLAo+Pj4gb3IgZGlz dG9ydGVkIGxldHRlcnMgaW4gWCB0ZXJtcy4KPj4+Cj4+PiBUaGUgY3VscHJpdCBzZWVtcyB0byBi ZSB0aGF0IHRoZSBkbWFfZ2V0X3JlcXVpcmVkX21hc2soKSBpcyByZXR1cm5pbmcgYQo+Pj4gdmFs dWUgMHgzZmZmZmZmZgo+Pj4gd2hpY2ggaXMgc21hbGxlciB0aGFuIGRtYV9nZXRfbWFzaygpMHhm ZmZmZmZmZi5UaGF0IHJlc3VsdHMgaW4KPj4+IGRtYV9hZGRyZXNzaW5nX2xpbWl0ZWQoKT09MCBp biB0dG1fYm9fZGV2aWNlKCksIGFuZCB1c2luZyA0MC1iaXRzIGRtYQo+Pj4gaW5zdGVhZCBvZiAz Mi1iaXRzLgo+PiBXaGljaCBpcyB0aGUgaW50ZW5kZWQgYmVoYXZpb3IgYXNzdW1pbmcgeW91ciBz eXN0ZW0gaGFzIDFHQiBvZiBtZW1vcnkuCj4+IERvZXMgaXQ/Cj4gCj4gQXNzdW1pbmcgdGhlIHN5 c3RlbSBkb2Vzbid0IGhhdmUgdGhlIDFHQiBzcGxpdCB1cCBzb21laG93IGNyYXp5IG92ZXIgdGhl IAo+IGFkZHJlc3Mgc3BhY2UgdGhhdCBzaG91bGQgaW5kZWVkIHdvcmsgYXMgaW50ZW5kZWQuCj4g Cj4+Cj4+PiBJZiBJIGhhcmRjb2RlICIxIiBhcyB0aGUgbGFzdCBwYXJhbWV0ZXIgdG8gdHRtX2Jv X2RldmljZV9pbml0KCkgaW4gCj4+PiBwbGFjZSBvZgo+Pj4gYSBjYWxsIHRvIGRtYV9hZGRyZXNz aW5nX2xpbWl0ZWQoKSx0aGUgcHJvYmxlbSBnb2VzIGF3YXkuCj4+IEknbGwgbmVlZCBzb21lIGhl bHAgZnJvbSB0aGUgZHJtIC8gcmFkZW9uIC8gVFRNIG1haW50YWluZXJzIGlmIHRoZXJlIGFyZQo+ PiBhbnkgb3RoZXIgc2lkZSBlZmZlY3RzIGZyb20gbm90IHBhc3NpbmcgdGhlIG5lZWRfZG1hMzIg cGFyYW10ZXJzLgo+PiBPYnZpb3VzbHkgaWYgdGhlIGRldmljZSBkb2Vzbid0IGhhdmUgbW9yZSB0 aGFuIDMyLWJpdHMgd29ydGggb2YgZHJhbSBhbmQKPj4gbm8gRE1BIG9mZnNldCB3ZSBjYW4ndCBm ZWVkIHVuYWRkcmVzc2FibGUgbWVtb3J5IHRvIHRoZSBkZXZpY2UuCj4+IFVuZm9ydHVuYXRlbHkg SSBoYXZlIGEgdmVyeSBoYXJkIHRpbWUgZm9sbG93aW5nIHRoZSBpbXBsZW1lbnRhdGlvbiBvZgo+ PiB0aGUgVFRNIHBvb2wgaWYgaXQgZG9lcyBhbnl0aGluZyBlbHNlIGluIHRoaXMgY2FzZS4KPiAK PiBUaGUgb25seSBvdGhlciB0aGluZyB3aGljaCBjb21lcyB0byBtaW5kIGlzIHVzaW5nIGh1Z2Ug cGFnZXMuIENhbiB5b3UgCj4gdHJ5IGEga2VybmVsIHdpdGggQ09ORklHX1RSQU5TUEFSRU5UX0hV R0VQQUdFIGRpc2FibGVkPwo+IAoKCkFueSBwcm9ncmVzcyBvbiB0aGlzID8KCldlIGhhdmUgYSBi dWdyZXBvcnQgaW4gTWFnZWlhIHdpdGggdGhlIGh3OgpEZWxsIEluc3Bpcm9uIDUxMDAsIDMyLWJp dCBQNCBwcm9jZXNzb3IsIDJHQiBvZiBSQU0sIFJhZGVvbiBNb2JpbGl0eSAKNzUwMCAoUlYyMDAp IGdyYXBoaWNzCgp0aGF0IGdldHMgZGlzcGxheSBpc3N1ZXMgdG9vIGFuZCByZXZlcnRpbmcgdGhl IG9mZmVuZGluZyBjb21taXQgcmVzdG9yZXMgCm5vcm1hbCBiZWhhdmlvdXIuCgphbmQgdGhlIHNh bWUgaXNzdWUgaXMgc3RpbGwgdGhlcmUgd2l0aCA1LjUgc2VyaWVzIGtlcm5lbHMuCgotLQpUaG9t YXMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==