From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94C44C43381 for ; Tue, 26 Mar 2019 15:39:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 639D020823 for ; Tue, 26 Mar 2019 15:39:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731985AbfCZPjo (ORCPT ); Tue, 26 Mar 2019 11:39:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58452 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbfCZPjo (ORCPT ); Tue, 26 Mar 2019 11:39:44 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1628A81E06; Tue, 26 Mar 2019 15:39:44 +0000 (UTC) Received: from [10.3.116.169] (ovpn-116-169.phx2.redhat.com [10.3.116.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B28717A89; Tue, 26 Mar 2019 15:39:39 +0000 (UTC) Subject: Re: [PATCH net 0/2] thunderx: fix receive buffer page recycling From: Dean Nelson To: Robert Richter , Sunil Goutham , David Miller Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vadim Lomovtsev References: <155360907744.12643.15472521931039184559.email-sent-by-dnelson@cyan> Message-ID: <8033cc8a-f5a9-8caf-b5c5-770a66bff78c@redhat.com> Date: Tue, 26 Mar 2019 10:39:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <155360907744.12643.15472521931039184559.email-sent-by-dnelson@cyan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 26 Mar 2019 15:39:44 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/26/19 9:04 AM, Dean Nelson wrote: > In attempting to optimize receive buffer page recycling for XDP, commit > 773225388dae15e72790 inadvertently introduced two problems for the non-XDP > case, that will be addressed by this patch series. > > Dean Nelson (2): > thunderx: enable page recycling for non-XDP case > thunderx: eliminate extra calls to put_page() for pages held for recycling > > drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 30 ++++++++++++++---------------- > 1 file changed, 14 insertions(+), 16 deletions(-) > I'm self-NACK'ng this patchset in order to add the omitted 'Fixes' lines. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DB95C43381 for ; Tue, 26 Mar 2019 15:39:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C568A20866 for ; Tue, 26 Mar 2019 15:39:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I3iA/cu0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C568A20866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QMgoSaBxJxexWaJYta+h7fJNhcCdWcY0zwOa1FtBS2c=; b=I3iA/cu0D6OvZ2uNfTbW1gM1r pDnTIBU6FdVsAmTo7NelzkB70v7boJKqx5zUWpRy7+w3LKPdYomtU87ULko0RHgYwmR8/p7FR85F0 CX19gZj3+oc/xxxevq6Lp+ogD7dqIsMC/GKWH4KGI2a4wnKD94by9Nq8E3vBTSSz7QEOXPOpqQaNU taNJSRpyxDG2RIGG5n7K/JS8wurcidZDg6s8fR3qGbFhqfWy7zpyN0fuhVv70FBf7qnWEBv08L7ZB lsqgD6Z0AjcaeCK6r6SqiLgjBIihwkYoLQLS4FcWKTsMBur5OWb+KJ54+Lt8tQGFMqrAzHWlAMh6n +OB9M7GlA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8oB2-0002Oc-Bm; Tue, 26 Mar 2019 15:39:48 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8oAy-0002Lm-FB for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 15:39:46 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1628A81E06; Tue, 26 Mar 2019 15:39:44 +0000 (UTC) Received: from [10.3.116.169] (ovpn-116-169.phx2.redhat.com [10.3.116.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B28717A89; Tue, 26 Mar 2019 15:39:39 +0000 (UTC) Subject: Re: [PATCH net 0/2] thunderx: fix receive buffer page recycling From: Dean Nelson To: Robert Richter , Sunil Goutham , David Miller References: <155360907744.12643.15472521931039184559.email-sent-by-dnelson@cyan> Message-ID: <8033cc8a-f5a9-8caf-b5c5-770a66bff78c@redhat.com> Date: Tue, 26 Mar 2019 10:39:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <155360907744.12643.15472521931039184559.email-sent-by-dnelson@cyan> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 26 Mar 2019 15:39:44 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_083944_527709_A0C04910 X-CRM114-Status: GOOD ( 15.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Vadim Lomovtsev , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/26/19 9:04 AM, Dean Nelson wrote: > In attempting to optimize receive buffer page recycling for XDP, commit > 773225388dae15e72790 inadvertently introduced two problems for the non-XDP > case, that will be addressed by this patch series. > > Dean Nelson (2): > thunderx: enable page recycling for non-XDP case > thunderx: eliminate extra calls to put_page() for pages held for recycling > > drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 30 ++++++++++++++---------------- > 1 file changed, 14 insertions(+), 16 deletions(-) > I'm self-NACK'ng this patchset in order to add the omitted 'Fixes' lines. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel