From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45830)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afarallax@yandex.ru>) id 1bG9Fj-0004Fd-N8
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 14:21:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afarallax@yandex.ru>) id 1bG9Fh-0004yi-P5
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 14:21:22 -0400
From: Sergey Sorokin <afarallax@yandex.ru>
In-Reply-To: <d021833e-312d-5dad-1a77-5800fadb733a@twiddle.net>
References: <1466599029-3388432-1-git-send-email-afarallax@yandex.ru>
	<5d86b8ba-16e8-e94d-ba7f-e865cbcc938e@twiddle.net>
	<1793281466613020@web5h.yandex.ru>
	<6c24c820-4a26-848c-e62d-88ebce59125d@twiddle.net>
	<201241466676212@web21j.yandex.ru>
	<458f40bb-cb58-4e10-2237-a08cb35155bd@twiddle.net>
	<200981466691221@web14m.yandex.ru>
	<d021833e-312d-5dad-1a77-5800fadb733a@twiddle.net>
MIME-Version: 1.0
Message-Id: <804691466706062@web16g.yandex.ru>
Date: Thu, 23 Jun 2016 21:21:02 +0300
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2] Improve the alignment check
 infrastructure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Alexander Graf <agraf@suse.de>, "qemu-arm@nongnu.org" <qemu-arm@nongnu.org>, Claudio Fontana <claudio.fontana@huawei.com>, Vassili Karpov <av1474@comtv.ru>

Yes, I thought about it. tcg_canonicalize_memop() is good place too.
But do you think that get_alignment_bits() is not good enough?

23.06.2016, 19:13, "Richard Henderson" <rth@twiddle.net>:
> On 06/23/2016 07:13 AM, Sergey Sorokin wrote:
>>> =C2=A0I think we ought to check this in tcg-op.c, rather than wait un=
til generating
>>> =C2=A0code in the backend.
>> =C2=A0I think it's better to check this in one place in get_alignment_=
bits() function
>> =C2=A0because there can be a direct call of helpers from softmmu_templ=
ate.h.
>
> I'm talking about the asserts in tcg/*/tcg-target.inc.c. Those asserts =
are
> better done in once place in tcg_canonicalize_memop.
>
> r~