From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0824C433EF for ; Thu, 2 Dec 2021 10:22:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356938AbhLBKZo (ORCPT ); Thu, 2 Dec 2021 05:25:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242697AbhLBKZl (ORCPT ); Thu, 2 Dec 2021 05:25:41 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6113C06174A for ; Thu, 2 Dec 2021 02:22:18 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id d9so37729543wrw.4 for ; Thu, 02 Dec 2021 02:22:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=e2CI3s+qc3l0KIfBWaOSCWRJ87QQ1SRqvUo2BVvjmHQ=; b=upIXAYbG3/iaLyoXO2Im9gJtusVYVjH2ZpBvbS7wdC6co3rmb4A2CSOP5DK7CdbPSZ l2oqIBBhwc0xLaPtw2qigD+KWar+7DPhgXEvB0t0yOL9hX9PHJFUAzCJuzMLQOwYn4Jj /Ls4zzkAPFMX65LliElRVUjT54eAqKTYUxR1thvH+POS8SQGf7NxCpDTb+RD4X8WJsjY j7miC3gIz0VDCp8Ph7FFMSWatDPY14HeIt+9NvO6B3+hEH/XWbFs3KxDBpsRnkOtTpEU ywWubvvzXr+n0gpRQO+vZXnq6aaAlV+0erYoa2mKe5sVYqOH5AofQpInHSneey67n3cR CXhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e2CI3s+qc3l0KIfBWaOSCWRJ87QQ1SRqvUo2BVvjmHQ=; b=kwyjdWwSST+L7LHCn9eN8sXtPeUVPnmZFoHbyxsM6OvYa9BqapzIVVOhZuRTTzy3q6 GuwSS8nof63FGadMtH45qJTMgV3tLSTrdUSY1/u48vEbLooo5JV2rkd8GXAxPyDerOdv 2qDK1ZKz1ej6VD1On4EHwlcC63wyY7DKk+bw/Pv7xb8Kq0L+it5nxSCzx9rEhqGuarN8 px43cFWFlLRSDAlbizP7TjRWZleWiUhWQeF8o/vDBVppjlvVJkDXRFIeCPM8252nUzDd 7J1u2K15fyYrp+EM9ST6fyZJFVRs3Rp0GxD1mVVffMv/ZTPnh/4l3K4WmoCWSoBBB49G uEDA== X-Gm-Message-State: AOAM531OkSWmDrxpLt923u5tyMVXpZf++rOu0iqPFxrxzOu+SiOXgOmA tyMldHcGhT2rVmjUWRgBqRvipA== X-Google-Smtp-Source: ABdhPJx1SKD6YvDp85QSxzRBRb+Q8ouDEm+WIW36C1XVsx6W7DTO4SNM0Z6q+zY/U815jKycPsrzIg== X-Received: by 2002:adf:eb05:: with SMTP id s5mr12763604wrn.448.1638440537248; Thu, 02 Dec 2021 02:22:17 -0800 (PST) Received: from ?IPv6:2a01:e34:ed2f:f020:72d0:52a1:d4ea:f564? ([2a01:e34:ed2f:f020:72d0:52a1:d4ea:f564]) by smtp.googlemail.com with ESMTPSA id az4sm1741476wmb.20.2021.12.02.02.22.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Dec 2021 02:22:16 -0800 (PST) Subject: Re: [PATCH 2/2] clocksource: timer-imx-sysctr: set cpumask to cpu_possible_mask To: "Peng Fan (OSS)" , tglx@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, van.freenix@gmail.com, Peng Fan References: <20211201125030.2307746-1-peng.fan@oss.nxp.com> <20211201125030.2307746-2-peng.fan@oss.nxp.com> From: Daniel Lezcano Message-ID: <80578aa9-35dd-02ca-fb07-5895991572e2@linaro.org> Date: Thu, 2 Dec 2021 11:22:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211201125030.2307746-2-peng.fan@oss.nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/2021 13:50, Peng Fan (OSS) wrote: > From: Peng Fan > > Actually we have CLOCK_EVT_FEAT_DYNIRQ, the irq affinity will be runtime > changed and no issue. But the system counter timer is not tied to CPU0, > so use cpu_possible_mask here. Did you mean: "There is no reason to tie the system counter timer to CPU0, change its affinity to cpu_possible_mask. Moreover, the timer has the flag CLOCK_EVT_FEAT_DYNIRQ set, changing to cpu_possibl_mask will reduce the number of wakeups related to the system timer" ? Note you may want to explain why 'there is no reason' > Signed-off-by: Peng Fan > --- > drivers/clocksource/timer-imx-sysctr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/timer-imx-sysctr.c b/drivers/clocksource/timer-imx-sysctr.c > index 2b309af11266..55a8e198d2a1 100644 > --- a/drivers/clocksource/timer-imx-sysctr.c > +++ b/drivers/clocksource/timer-imx-sysctr.c > @@ -119,7 +119,7 @@ static struct timer_of to_sysctr = { > > static void __init sysctr_clockevent_init(void) > { > - to_sysctr.clkevt.cpumask = cpumask_of(0); > + to_sysctr.clkevt.cpumask = cpu_possible_mask; > > clockevents_config_and_register(&to_sysctr.clkevt, > timer_of_rate(&to_sysctr), > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A93DC433EF for ; Thu, 2 Dec 2021 10:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=lYCCrZaBz3tWERxGUCfTIzDHkaG6vO4S3MKeeosygeo=; b=aA9+oM2gvnj0kc2rDoHJ6eMqe2 B9dbfQjMTMbaCytyfMinN8c4aJs5wQ0QTDTIeLlZKzbfIVebh1i9EZIIN8z9h4l12fbFoEotyVIRz GHOu01Q2a+wDr9PiceZsaArCZaoTRNFZaEUoYaIHLRKRMGW5LAT2Sw6InZMn762jkyJb4H7VSPJLj KAAzynUszQhZyGsdKa0uZ8Rbln9NP2gxcS53kVzMBy0xJK6+hNGUZWXabMAlHgBL0iUMcJwFQEbMP oDyikDx24NR131Twh+iMerUEWvEynFKd33wl7ns/ZUgJQz1xBp7j1m/6wR8HIIQWt9U42o8pUALqI RwA3qgEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msjEN-00BoPJ-5m; Thu, 02 Dec 2021 10:22:23 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msjEJ-00BoO4-Az for linux-arm-kernel@lists.infradead.org; Thu, 02 Dec 2021 10:22:21 +0000 Received: by mail-wr1-x42e.google.com with SMTP id l16so58536063wrp.11 for ; Thu, 02 Dec 2021 02:22:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=e2CI3s+qc3l0KIfBWaOSCWRJ87QQ1SRqvUo2BVvjmHQ=; b=upIXAYbG3/iaLyoXO2Im9gJtusVYVjH2ZpBvbS7wdC6co3rmb4A2CSOP5DK7CdbPSZ l2oqIBBhwc0xLaPtw2qigD+KWar+7DPhgXEvB0t0yOL9hX9PHJFUAzCJuzMLQOwYn4Jj /Ls4zzkAPFMX65LliElRVUjT54eAqKTYUxR1thvH+POS8SQGf7NxCpDTb+RD4X8WJsjY j7miC3gIz0VDCp8Ph7FFMSWatDPY14HeIt+9NvO6B3+hEH/XWbFs3KxDBpsRnkOtTpEU ywWubvvzXr+n0gpRQO+vZXnq6aaAlV+0erYoa2mKe5sVYqOH5AofQpInHSneey67n3cR CXhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e2CI3s+qc3l0KIfBWaOSCWRJ87QQ1SRqvUo2BVvjmHQ=; b=3uwJjhkzCcT9xmHbsbyKg6kJoUhn804ILBcqr9xpuhyYrMRMzZ3+VS/U/LaO9BA+ut 1T7JYpr5run/tRl92iEsUcF5lB7KcVUzg65kgVTahN7Ai97govF+XdHchSz7tXaoE4ir Zk4S08xZM4r0i3+B+mqD4AyywiLW4IS5TECtZDBABbbArD5fRDoQymjVLNTpH0bl+nLN p4qQqQvZxmfke+1SOPxI9gXuvqWxT6uXJ7295CwiyawGTpSSj4s37ql39IDrYjTm2QoE a2OV8vpb8v88mNX+CATa87RvrABcehSCP1W6jThml1tcovUW7QQA2ukJum3pk+hPpwko t8nA== X-Gm-Message-State: AOAM53053bqaPCTUXjZUCEOv2/W+UH0Pjw2qNp8bmnlEyylhrV/wnOk7 ksvfJyWdiKvVzzSUvwYjuZ3mOw== X-Google-Smtp-Source: ABdhPJx1SKD6YvDp85QSxzRBRb+Q8ouDEm+WIW36C1XVsx6W7DTO4SNM0Z6q+zY/U815jKycPsrzIg== X-Received: by 2002:adf:eb05:: with SMTP id s5mr12763604wrn.448.1638440537248; Thu, 02 Dec 2021 02:22:17 -0800 (PST) Received: from ?IPv6:2a01:e34:ed2f:f020:72d0:52a1:d4ea:f564? ([2a01:e34:ed2f:f020:72d0:52a1:d4ea:f564]) by smtp.googlemail.com with ESMTPSA id az4sm1741476wmb.20.2021.12.02.02.22.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Dec 2021 02:22:16 -0800 (PST) Subject: Re: [PATCH 2/2] clocksource: timer-imx-sysctr: set cpumask to cpu_possible_mask To: "Peng Fan (OSS)" , tglx@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, van.freenix@gmail.com, Peng Fan References: <20211201125030.2307746-1-peng.fan@oss.nxp.com> <20211201125030.2307746-2-peng.fan@oss.nxp.com> From: Daniel Lezcano Message-ID: <80578aa9-35dd-02ca-fb07-5895991572e2@linaro.org> Date: Thu, 2 Dec 2021 11:22:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211201125030.2307746-2-peng.fan@oss.nxp.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211202_022219_433139_F4F64858 X-CRM114-Status: GOOD ( 19.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDEvMTIvMjAyMSAxMzo1MCwgUGVuZyBGYW4gKE9TUykgd3JvdGU6Cj4gRnJvbTogUGVuZyBG YW4gPHBlbmcuZmFuQG54cC5jb20+Cj4gCj4gQWN0dWFsbHkgd2UgaGF2ZSBDTE9DS19FVlRfRkVB VF9EWU5JUlEsIHRoZSBpcnEgYWZmaW5pdHkgd2lsbCBiZSBydW50aW1lCj4gY2hhbmdlZCBhbmQg bm8gaXNzdWUuIEJ1dCB0aGUgc3lzdGVtIGNvdW50ZXIgdGltZXIgaXMgbm90IHRpZWQgdG8gQ1BV MCwKPiBzbyB1c2UgY3B1X3Bvc3NpYmxlX21hc2sgaGVyZS4KCkRpZCB5b3UgbWVhbjoKCiJUaGVy ZSBpcyBubyByZWFzb24gdG8gdGllIHRoZSBzeXN0ZW0gY291bnRlciB0aW1lciB0byBDUFUwLCBj aGFuZ2UgaXRzCmFmZmluaXR5IHRvIGNwdV9wb3NzaWJsZV9tYXNrLgoKTW9yZW92ZXIsIHRoZSB0 aW1lciBoYXMgdGhlIGZsYWcgQ0xPQ0tfRVZUX0ZFQVRfRFlOSVJRIHNldCwgY2hhbmdpbmcgdG8K Y3B1X3Bvc3NpYmxfbWFzayB3aWxsIHJlZHVjZSB0aGUgbnVtYmVyIG9mIHdha2V1cHMgcmVsYXRl ZCB0byB0aGUgc3lzdGVtCnRpbWVyIgoKPwoKTm90ZSB5b3UgbWF5IHdhbnQgdG8gZXhwbGFpbiB3 aHkgJ3RoZXJlIGlzIG5vIHJlYXNvbicKCgo+IFNpZ25lZC1vZmYtYnk6IFBlbmcgRmFuIDxwZW5n LmZhbkBueHAuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2Nsb2Nrc291cmNlL3RpbWVyLWlteC1zeXNj dHIuYyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9u KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY2xvY2tzb3VyY2UvdGltZXItaW14LXN5c2N0 ci5jIGIvZHJpdmVycy9jbG9ja3NvdXJjZS90aW1lci1pbXgtc3lzY3RyLmMKPiBpbmRleCAyYjMw OWFmMTEyNjYuLjU1YThlMTk4ZDJhMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2Nsb2Nrc291cmNl L3RpbWVyLWlteC1zeXNjdHIuYwo+ICsrKyBiL2RyaXZlcnMvY2xvY2tzb3VyY2UvdGltZXItaW14 LXN5c2N0ci5jCj4gQEAgLTExOSw3ICsxMTksNyBAQCBzdGF0aWMgc3RydWN0IHRpbWVyX29mIHRv X3N5c2N0ciA9IHsKPiAgCj4gIHN0YXRpYyB2b2lkIF9faW5pdCBzeXNjdHJfY2xvY2tldmVudF9p bml0KHZvaWQpCj4gIHsKPiAtCXRvX3N5c2N0ci5jbGtldnQuY3B1bWFzayA9IGNwdW1hc2tfb2Yo MCk7Cj4gKwl0b19zeXNjdHIuY2xrZXZ0LmNwdW1hc2sgPSBjcHVfcG9zc2libGVfbWFzazsKPiAg Cj4gIAljbG9ja2V2ZW50c19jb25maWdfYW5kX3JlZ2lzdGVyKCZ0b19zeXNjdHIuY2xrZXZ0LAo+ ICAJCQkJCXRpbWVyX29mX3JhdGUoJnRvX3N5c2N0ciksCj4gCgoKLS0gCjxodHRwOi8vd3d3Lmxp bmFyby5vcmcvPiBMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNv Q3MKCkZvbGxvdyBMaW5hcm86ICA8aHR0cDovL3d3dy5mYWNlYm9vay5jb20vcGFnZXMvTGluYXJv PiBGYWNlYm9vayB8CjxodHRwOi8vdHdpdHRlci5jb20vIyEvbGluYXJvb3JnPiBUd2l0dGVyIHwK PGh0dHA6Ly93d3cubGluYXJvLm9yZy9saW5hcm8tYmxvZy8+IEJsb2cKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK