From: Rongwei Wang <rongwei.wang@linux.alibaba.com>
To: sj@kernel.org, akpm@linux-foundation.org
Cc: linux-damon@amazon.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mm/damon/sysfs: support fixed virtual address ranges monitoring
Date: Mon, 2 May 2022 15:56:58 +0800 [thread overview]
Message-ID: <80586516-d783-8f81-f6d7-338d9af7a3e6@linux.alibaba.com> (raw)
In-Reply-To: <20220426231750.48822-3-sj@kernel.org>
Hi, SeongJae
I had read and tested your patchset these days. It works.
It seems that these patches only fix the issue about init_regions in
DAMON-sysfs, but not fix in DAMON-dbgfs? maybe I missing something.
If so, do you have any plan to fix this bug in dbgfs? Actually, what I
want to say is that I ready a patch for solving the init_regions related
bug in dbgfs these days. I not sure if you're interested in it.
Best Regards,
Rongwei
On 4/27/22 7:17 AM, sj@kernel.org wrote:
> From: SeongJae Park <sj@kernel.org>
>
> This commit makes DAMON sysfs interface to support the fixed virtual
> address ranges monitoring. After this commit, writing 'fvaddr' to the
> 'operations' DAMON sysfs file makes DAMON uses the monitoring operations
> set for fixed virtual address ranges, so that users can monitor accesses
> to only interested virtual address ranges.
>
> Signed-off-by: SeongJae Park <sj@kernel.org>
> ---
> mm/damon/sysfs.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
> index 719a286d378f..767ab8c33e4d 100644
> --- a/mm/damon/sysfs.c
> +++ b/mm/damon/sysfs.c
> @@ -1694,7 +1694,7 @@ static struct kobj_type damon_sysfs_attrs_ktype = {
> /* This should match with enum damon_ops_id */
> static const char * const damon_sysfs_ops_strs[] = {
> "vaddr",
> - "unsupported", /* fvaddr is not supported by sysfs yet */
> + "fvaddr",
> "paddr",
> };
>
> @@ -1844,9 +1844,6 @@ static ssize_t operations_store(struct kobject *kobj,
>
> for (id = 0; id < NR_DAMON_OPS; id++) {
> if (sysfs_streq(buf, damon_sysfs_ops_strs[id])) {
> - /* fvaddr is not supported by sysfs yet */
> - if (id == DAMON_OPS_FVADDR)
> - return -EINVAL;
> context->ops_id = id;
> return count;
> }
> @@ -2136,7 +2133,8 @@ static int damon_sysfs_set_targets(struct damon_ctx *ctx,
> damon_sysfs_destroy_targets(ctx);
> return -ENOMEM;
> }
> - if (ctx->ops.id == DAMON_OPS_VADDR) {
> + if (ctx->ops.id == DAMON_OPS_VADDR ||
> + ctx->ops.id == DAMON_OPS_FVADDR) {
> t->pid = find_get_pid(sys_target->pid);
> if (!t->pid) {
> damon_sysfs_destroy_targets(ctx);
next prev parent reply other threads:[~2022-05-02 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 23:17 [PATCH 0/3] support fixed virtual address ranges monitoring sj
2022-04-26 23:17 ` [PATCH 1/3] mm/damon/vaddr: register a damon_operations for " sj
2022-04-26 23:17 ` [PATCH 2/3] mm/damon/sysfs: support " sj
2022-05-02 7:56 ` Rongwei Wang [this message]
2022-05-02 16:18 ` SeongJae Park
2022-05-03 2:20 ` Rongwei Wang
2022-04-26 23:17 ` [PATCH 3/3] Docs/{ABI,admin-guide}/damon: update for " sj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80586516-d783-8f81-f6d7-338d9af7a3e6@linux.alibaba.com \
--to=rongwei.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=linux-damon@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.