All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Huacai Chen <chenhc@lemote.com>,
	aleksandar.qemu.devel@gmail.com, richard.henderson@linaro.org,
	aleksandar.rikalo@rt-rk.com, aurelien@aurel32.net
Subject: Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions
Date: Tue, 31 Mar 2020 00:30:48 +0800	[thread overview]
Message-ID: <80698310-CBFC-4D65-826D-3F7AA038B126@flygoat.com> (raw)
In-Reply-To: <bbf10da2-76ee-a4c6-275d-fa1c8fc59e1e@redhat.com>



于 2020年3月31日 GMT+08:00 上午12:22:43, "Philippe Mathieu-Daudé" <philmd@redhat.com> 写到:
>On 3/30/20 6:18 PM, Jiaxun Yang wrote:
>> 
>> 
>> 于 2020年3月30日 GMT+08:00 下午11:39:44, "Philippe Mathieu-Daudé"
><philmd@redhat.com> 写到:
>>> Hi Jiaxun Yang,
>>>
>>> On 3/24/20 1:22 PM, Jiaxun Yang wrote:
>>>> Loongson multimedia condition instructions were previously
>>> implemented as
>>>> write 0 to rd due to lack of documentation. So I just confirmed
>with
>>> Loongson
>>>> about their encoding and implemented them correctly.
>>>
>>> If you have a binary using loongson multimedia instructions, can you
>>> add
>>> a test? So this code won't bitrot.
>> 
>> I know ffmpeg uses it.
>> But I think that's too fat.
>
>Looks perfect to me!
>
>It'll be simpler if you use a pre-build binary from a known
>distribution.

Unfortunately none of the distribution built ffmpeg with loongson insns enabled,
as it can't be enabled at runtime.

I'll try that after fulfill Loongson Extensions in  QEMU.

FFmpeg do use some other Loongson insns despite mmi. 

There are still 15+ instructions for me to work.

Thanks
-- 
Jiaxun Yang


  reply	other threads:[~2020-03-30 16:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-24 12:22 [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions Jiaxun Yang
2020-03-24 14:59 ` Richard Henderson
2020-03-25 10:44   ` Aleksandar Markovic
2020-03-25 10:47     ` Aleksandar Markovic
2020-03-25 11:13       ` Aleksandar Markovic
2020-03-26  1:30     ` Richard Henderson
2020-03-27 12:46       ` Aleksandar Markovic
2020-03-24 16:56 ` Aleksandar Markovic
2020-03-24 17:08   ` Jiaxun Yang
2020-03-24 17:26     ` Aleksandar Markovic
2020-03-30 15:39 ` Philippe Mathieu-Daudé
2020-03-30 16:18   ` Jiaxun Yang
2020-03-30 16:22     ` Philippe Mathieu-Daudé
2020-03-30 16:30       ` Jiaxun Yang [this message]
2020-03-30 19:01         ` Aleksandar Markovic
2020-04-01 14:36 ` Aleksandar Markovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80698310-CBFC-4D65-826D-3F7AA038B126@flygoat.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@rt-rk.com \
    --cc=aurelien@aurel32.net \
    --cc=chenhc@lemote.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.