From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ADE5C2B9F4 for ; Fri, 25 Jun 2021 13:47:22 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D61B061474 for ; Fri, 25 Jun 2021 13:47:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D61B061474 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3E81C82C19; Fri, 25 Jun 2021 15:47:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="aOV8c5Ye"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 37FEF82C1B; Fri, 25 Jun 2021 15:47:17 +0200 (CEST) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F0D0182C18 for ; Fri, 25 Jun 2021 15:47:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf36.google.com with SMTP id fq1so4684686qvb.1 for ; Fri, 25 Jun 2021 06:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VcnRxlxt+CZTRU0gw/wgyivF3H+FPseQ/qLcMc1lnlY=; b=aOV8c5YeRbzSW/6ILKUrZH8vpOFBHk7yoeMBIPBDncBpFqXQV44LVjLGCl7sAZ/ew2 NFAoRPIyP6WErp1kh9JIvc8nzu2xjjcIK7cYyUusb+3mmz1mL5AEYvLtbbG0URD3ORn6 IyMBO/LYuY+ROvoSD6FvN9c9iJuzYN4q7ClLwywQqUTlxvBDsSj/U2JUTO//xvC5gows NnP5f3iJlv+VH0b52CrMiugLqbzddWtQCh0pokJD9kzQZ0WS7UhWDaHBxaHB5Ly2TSFr c4loUUzYkjAtQhJ6jDjrsDRv8lX7ocA6xVlVXxfbnBRCLCMDTgxXYD+XnKK7WS9+5L2x 4J/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VcnRxlxt+CZTRU0gw/wgyivF3H+FPseQ/qLcMc1lnlY=; b=YnSUVFbtfQD06xpy8AJFp9QB3Mva/TZL219qcXcF63CVl1Rx+W8glIDv8UNzykl30H ug8VEidpcVkmny92erTBoqOuoG+Qq8d0UCX9pD3ZQ4muIT9PZZCLGWJ479dIMZImicoa FVdYnZnCuomD2zVTYb/bXCfDhyZeRvycEkfi5aGTP0keCMzFpJpD6EJMhlZRwkpdDJpC r5/yfpINz+dW+80enQLWCuMBjlwJNT54H2AVyJScA587YPScddEr3EqdfBBlmW7asVOU sD5HEV8HtrTWXTPkpIk2wO3p42yNE8X0EGS7SKQSnLGphDw20y0+Pdhckzwmd62uMRt6 EDXg== X-Gm-Message-State: AOAM5338mGo5ccBuUaHsOME9UaYNw9gB2hc/TcsuQpVoN/HRaUHVoCBN 3Zbhl+Zm2OHg9iGla6WSxsM= X-Google-Smtp-Source: ABdhPJy2NTi2fX0+IEQiMO8SuJpITOsmsIKtSfiTKosfXj/Etz+Qp9DQSVC6jb3KMAcnbGwuH6FuTg== X-Received: by 2002:a05:6214:1089:: with SMTP id o9mr11066835qvr.36.1624628832822; Fri, 25 Jun 2021 06:47:12 -0700 (PDT) Received: from [192.168.1.201] (pool-74-96-87-9.washdc.fios.verizon.net. [74.96.87.9]) by smtp.googlemail.com with ESMTPSA id c11sm3728887qth.29.2021.06.25.06.47.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Jun 2021 06:47:12 -0700 (PDT) Subject: Re: [PATCH 03/12] Revert "usb: gadget: fastboot: use correct max packet size" To: Maxime Ripard , u-boot@lists.denx.de, Andre Przywara Cc: Peng Fan , Li Jun , Marek Vasut , Tom Rini , Miquel Raynal , Jagan Teki References: <20210625130547.2177920-1-maxime@cerno.tech> <20210625130547.2177920-4-maxime@cerno.tech> From: Sean Anderson Message-ID: <806cca46-7bad-ccd8-4973-f7f06dda3128@gmail.com> Date: Fri, 25 Jun 2021 09:47:11 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210625130547.2177920-4-maxime@cerno.tech> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 6/25/21 9:05 AM, Maxime Ripard wrote: > This reverts commit 27c9141b1114fd5721437abbb1c694e45e765f19. Why does this need to be reverted? --Sean > --- > drivers/usb/gadget/f_fastboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c > index 8ba55aab9f8f..1fcffaf9dd26 100644 > --- a/drivers/usb/gadget/f_fastboot.c > +++ b/drivers/usb/gadget/f_fastboot.c > @@ -427,7 +427,7 @@ static unsigned int rx_bytes_expected(struct usb_ep *ep) > { > int rx_remain = fastboot_data_remaining(); > unsigned int rem; > - unsigned int maxpacket = usb_endpoint_maxp(ep->desc); > + unsigned int maxpacket = ep->maxpacket; > > if (rx_remain <= 0) > return 0; >