From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0714EC4332F for ; Fri, 25 Nov 2022 17:25:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oycRN-0001fJ-Up; Fri, 25 Nov 2022 12:24:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oycRL-0001ef-MC; Fri, 25 Nov 2022 12:24:39 -0500 Received: from forwardcorp1b.mail.yandex.net ([178.154.239.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oycRK-0001R9-1A; Fri, 25 Nov 2022 12:24:39 -0500 Received: from myt5-70c90f7d6d7d.qloud-c.yandex.net (myt5-70c90f7d6d7d.qloud-c.yandex.net [IPv6:2a02:6b8:c12:3e2c:0:640:70c9:f7d]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTP id 690F15FC50; Fri, 25 Nov 2022 20:24:19 +0300 (MSK) Received: from [IPV6:2a02:6b8:b081:16::1:7] (unknown [2a02:6b8:b081:16::1:7]) by myt5-70c90f7d6d7d.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id IOQuj10NiuQ1-a7OYYMt2; Fri, 25 Nov 2022 20:24:18 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1669397058; bh=6knt8v343ZU8E4ZKUB7GxohkRHzVuQdnYkad2W0sRRs=; h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID; b=opuAlSF09wPijtXmJLx1m9z1Gr/S/3qCPUY3thCXVlVB1htDDmfR8tankqTTo317T 7F01QpO1hWf0kk8jvC0WFESduHLNzx3sfAqFbi5D773USH0QsOyXvWiXkNMqb3T/No yvqCCiIBTm68nmZMHdRNPXpn2UpEYXRsfzzjiQMg= Authentication-Results: myt5-70c90f7d6d7d.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru Message-ID: <8070c591-72a7-2350-65b1-9767276f16c7@yandex-team.ru> Date: Fri, 25 Nov 2022 20:24:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v6 06/14] block: avoid duplicating filename string in bdrv_create Content-Language: en-US To: Emanuele Giuseppe Esposito , qemu-block@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Hanna Reitz , John Snow , Eric Blake , Fam Zheng , Stefan Hajnoczi , "Denis V. Lunev" , Stefan Weil , Jeff Cody , Cleber Rosa , qemu-devel@nongnu.org References: <20221125133518.418328-1-eesposit@redhat.com> <20221125133518.418328-7-eesposit@redhat.com> From: Vladimir Sementsov-Ogievskiy In-Reply-To: <20221125133518.418328-7-eesposit@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=178.154.239.136; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/25/22 16:35, Emanuele Giuseppe Esposito wrote: > We know that the string will stay around until the function > returns, and the parameter of drv->bdrv_co_create_opts is const char*, > so it must not be modified either. > > Suggested-by: Kevin Wolf > Signed-off-by: Emanuele Giuseppe Esposito > Reviewed-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir