From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=LQxz=DO=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,
	SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6A9AEC4363C
	for <linux-kernel@archiver.kernel.org>; Wed,  7 Oct 2020 20:33:09 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 022FE20760
	for <linux-kernel@archiver.kernel.org>; Wed,  7 Oct 2020 20:33:08 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="bGis6r8C"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728124AbgJGUdI (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 7 Oct 2020 16:33:08 -0400
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:3133 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726105AbgJGUdH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Oct 2020 16:33:07 -0400
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5f7e25ca0000>; Wed, 07 Oct 2020 13:32:10 -0700
Received: from [10.2.85.86] (172.20.13.39) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 7 Oct
 2020 20:32:56 +0000
Subject: Re: [PATCH 01/13] drm/exynos: Stop using frame_vector helpers
To:     Daniel Vetter <daniel.vetter@ffwll.ch>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
CC:     <kvm@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>, <linux-media@vger.kernel.org>,
        <linux-s390@vger.kernel.org>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Inki Dae <inki.dae@samsung.com>,
        Joonyoung Shim <jy0922.shim@samsung.com>,
        "Seung-Woo Kim" <sw0312.kim@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        "Andrew Morton" <akpm@linux-foundation.org>,
        =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
        Jan Kara <jack@suse.cz>,
        Dan Williams <dan.j.williams@intel.com>
References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch>
 <20201007164426.1812530-2-daniel.vetter@ffwll.ch>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <80718789-b3de-c30a-03c5-7c8cbf41f7d9@nvidia.com>
Date:   Wed, 7 Oct 2020 13:32:55 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201007164426.1812530-2-daniel.vetter@ffwll.ch>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1602102730; bh=l9BqHF8KWQmaN4RXmMMQ0YcJNLZG1Nf+tEGI/Rd7B58=;
        h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
         MIME-Version:In-Reply-To:Content-Type:Content-Language:
         Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
        b=bGis6r8CEYmrZyavIIA1+AVI5ZOhpqwwr99ccXacmU9iQ3VFTDuM97FlAOqT78Igm
         rCn6vdto1m5+BSCNb/A8nxrfefBagyIX9EjaXmATUsXTn9akCKaOpm6guzuSkTwIzf
         IpnyPYT00yPR0jTRCgi6gumSrIvalRt72z/Kx816tUwt9BZjxVThNnp6kaGyo0nU3j
         3PUi0rvlZKXu+7CrW0/PBtJDkTJjVt3tkFU+HWV1HnGZfccwM07dwDqshD0XGAGCor
         R7Fs108WnSzw2GTZDHNFHdIx8S9N3rVALIhly96SHgPVr7dfKcd4j8QZRD4wOkO8oz
         RPfm1ouAMFSew==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/7/20 9:44 AM, Daniel Vetter wrote:
> All we need are a pages array, pin_user_pages_fast can give us that
> directly. Plus this avoids the entire raw pfn side of get_vaddr_frames.
>=20
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Inki Dae <inki.dae@samsung.com>
> Cc: Joonyoung Shim <jy0922.shim@samsung.com>
> Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: John Hubbard <jhubbard@nvidia.com>
> Cc: J=C3=A9r=C3=B4me Glisse <jglisse@redhat.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: linux-mm@kvack.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-media@vger.kernel.org
> ---
>   drivers/gpu/drm/exynos/Kconfig          |  1 -
>   drivers/gpu/drm/exynos/exynos_drm_g2d.c | 48 ++++++++++++-------------
>   2 files changed, 22 insertions(+), 27 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kcon=
fig
> index 6417f374b923..43257ef3c09d 100644
> --- a/drivers/gpu/drm/exynos/Kconfig
> +++ b/drivers/gpu/drm/exynos/Kconfig
> @@ -88,7 +88,6 @@ comment "Sub-drivers"
>   config DRM_EXYNOS_G2D
>   	bool "G2D"
>   	depends on VIDEO_SAMSUNG_S5P_G2D=3Dn || COMPILE_TEST
> -	select FRAME_VECTOR
>   	help
>   	  Choose this option if you want to use Exynos G2D for DRM.
>  =20
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/ex=
ynos/exynos_drm_g2d.c
> index 967a5cdc120e..c83f6faac9de 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> @@ -205,7 +205,8 @@ struct g2d_cmdlist_userptr {
>   	dma_addr_t		dma_addr;
>   	unsigned long		userptr;
>   	unsigned long		size;
> -	struct frame_vector	*vec;
> +	struct page		**pages;
> +	unsigned int		npages;
>   	struct sg_table		*sgt;
>   	atomic_t		refcount;
>   	bool			in_pool;
> @@ -378,7 +379,7 @@ static void g2d_userptr_put_dma_addr(struct g2d_data =
*g2d,
>   					bool force)
>   {
>   	struct g2d_cmdlist_userptr *g2d_userptr =3D obj;
> -	struct page **pages;
> +	int i;

The above line can also be deleted, see below.

>  =20
>   	if (!obj)
>   		return;
> @@ -398,15 +399,11 @@ static void g2d_userptr_put_dma_addr(struct g2d_dat=
a *g2d,
>   	dma_unmap_sgtable(to_dma_dev(g2d->drm_dev), g2d_userptr->sgt,
>   			  DMA_BIDIRECTIONAL, 0);
>  =20
> -	pages =3D frame_vector_pages(g2d_userptr->vec);
> -	if (!IS_ERR(pages)) {
> -		int i;
> +	for (i =3D 0; i < g2d_userptr->npages; i++)
> +		set_page_dirty_lock(g2d_userptr->pages[i]);
>  =20
> -		for (i =3D 0; i < frame_vector_count(g2d_userptr->vec); i++)
> -			set_page_dirty_lock(pages[i]);
> -	}
> -	put_vaddr_frames(g2d_userptr->vec);
> -	frame_vector_destroy(g2d_userptr->vec);
> +	unpin_user_pages(g2d_userptr->pages, g2d_userptr->npages);
> +	kvfree(g2d_userptr->pages);

You can avoid writing your own loop, and just simplify the whole thing down=
 to
two lines:

	unpin_user_pages_dirty_lock(g2d_userptr->pages, g2d_userptr->npages,
				    true);
	kvfree(g2d_userptr->pages);


>  =20
>   	if (!g2d_userptr->out_of_list)
>   		list_del_init(&g2d_userptr->list);
> @@ -474,35 +471,34 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct =
g2d_data *g2d,
>   	offset =3D userptr & ~PAGE_MASK;
>   	end =3D PAGE_ALIGN(userptr + size);
>   	npages =3D (end - start) >> PAGE_SHIFT;
> -	g2d_userptr->vec =3D frame_vector_create(npages);
> -	if (!g2d_userptr->vec) {
> +	g2d_userptr->pages =3D kvmalloc_array(npages, sizeof(*g2d_userptr->page=
s),
> +					    GFP_KERNEL);
> +	if (!g2d_userptr->pages) {
>   		ret =3D -ENOMEM;
>   		goto err_free;
>   	}
>  =20
> -	ret =3D get_vaddr_frames(start, npages, FOLL_FORCE | FOLL_WRITE,
> -		g2d_userptr->vec);
> +	ret =3D pin_user_pages_fast(start, npages, FOLL_FORCE | FOLL_WRITE,
> +				  g2d_userptr->pages);
>   	if (ret !=3D npages) {
>   		DRM_DEV_ERROR(g2d->dev,
>   			      "failed to get user pages from userptr.\n");
>   		if (ret < 0)
> -			goto err_destroy_framevec;
> -		ret =3D -EFAULT;
> -		goto err_put_framevec;
> -	}
> -	if (frame_vector_to_pages(g2d_userptr->vec) < 0) {
> +			goto err_destroy_pages;
> +		npages =3D ret;
>   		ret =3D -EFAULT;
> -		goto err_put_framevec;
> +		goto err_unpin_pages;
>   	}
> +	g2d_userptr->npages =3D npages;
>  =20
>   	sgt =3D kzalloc(sizeof(*sgt), GFP_KERNEL);
>   	if (!sgt) {
>   		ret =3D -ENOMEM;
> -		goto err_put_framevec;
> +		goto err_unpin_pages;
>   	}
>  =20
>   	ret =3D sg_alloc_table_from_pages(sgt,
> -					frame_vector_pages(g2d_userptr->vec),
> +					g2d_userptr->pages,
>   					npages, offset, size, GFP_KERNEL);
>   	if (ret < 0) {
>   		DRM_DEV_ERROR(g2d->dev, "failed to get sgt from pages.\n");
> @@ -538,11 +534,11 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct =
g2d_data *g2d,
>   err_free_sgt:
>   	kfree(sgt);
>  =20
> -err_put_framevec:
> -	put_vaddr_frames(g2d_userptr->vec);
> +err_unpin_pages:
> +	unpin_user_pages(g2d_userptr->pages, npages);
>  =20
> -err_destroy_framevec:
> -	frame_vector_destroy(g2d_userptr->vec);
> +err_destroy_pages:
> +	kvfree(g2d_userptr->pages);
>  =20
>   err_free:
>   	kfree(g2d_userptr);
>=20

The rest all looks good, you've avoided the usual API pitfalls. :)

thanks,
--=20
John Hubbard
NVIDIA

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=noaO=DO=lists.infradead.org=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,
	MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id DA810C4363C
	for <linux-arm-kernel@archiver.kernel.org>; Wed,  7 Oct 2020 20:34:50 +0000 (UTC)
Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id 58D3C20760
	for <linux-arm-kernel@archiver.kernel.org>; Wed,  7 Oct 2020 20:34:50 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zNcHBRlJ";
	dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="bGis6r8C"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58D3C20760
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:
	Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:
	List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:
	References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:
	Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;
	 bh=ZbMhoHfxuIICFDnwuDFI3oX4jClpBicLarCqNt9VbW4=; b=zNcHBRlJ5l5m7U1fahhyKOu10
	DCHfU6+XuE2NoLKmyQAVxEiQSo4Jdjf7qArF+ZIrszuSfYGoKyelWG/haRjN9+9nbbbDHum5KT2bu
	2hhrkjv+6YpdQjjzBJoF2iLJEeiHORvgiRyp9wUy/Cjid4abY+XAzMN2Iubz3kkMar6CO+100NIj/
	iwSeZa72r1keacm/O63LvTRjgIOfnB4Kqicc4zdeiKBdgC7jxQ2xdLA/DbyVpdKWJwLTDf/hdFEIZ
	9poV57/J8kK4ruhx8I5RfeGLCZpG8jsp6q/sQ8l/5VV/jmF8+NFWpO0ESpW/RzALAga+FWTZ6Qk3L
	ARDzq0FHA==;
Received: from localhost ([::1] helo=merlin.infradead.org)
	by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux))
	id 1kQG7c-00024F-2Z; Wed, 07 Oct 2020 20:33:12 +0000
Received: from hqnvemgate25.nvidia.com ([216.228.121.64])
 by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux))
 id 1kQG7Y-00023K-UZ
 for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 20:33:10 +0000
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by
 hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
 id <B5f7e25ca0000>; Wed, 07 Oct 2020 13:32:10 -0700
Received: from [10.2.85.86] (172.20.13.39) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 7 Oct
 2020 20:32:56 +0000
Subject: Re: [PATCH 01/13] drm/exynos: Stop using frame_vector helpers
To: Daniel Vetter <daniel.vetter@ffwll.ch>, DRI Development
 <dri-devel@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org>
References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch>
 <20201007164426.1812530-2-daniel.vetter@ffwll.ch>
From: John Hubbard <jhubbard@nvidia.com>
Message-ID: <80718789-b3de-c30a-03c5-7c8cbf41f7d9@nvidia.com>
Date: Wed, 7 Oct 2020 13:32:55 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201007164426.1812530-2-daniel.vetter@ffwll.ch>
Content-Language: en-US
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
 t=1602102730; bh=l9BqHF8KWQmaN4RXmMMQ0YcJNLZG1Nf+tEGI/Rd7B58=;
 h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
 MIME-Version:In-Reply-To:Content-Type:Content-Language:
 Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
 b=bGis6r8CEYmrZyavIIA1+AVI5ZOhpqwwr99ccXacmU9iQ3VFTDuM97FlAOqT78Igm
 rCn6vdto1m5+BSCNb/A8nxrfefBagyIX9EjaXmATUsXTn9akCKaOpm6guzuSkTwIzf
 IpnyPYT00yPR0jTRCgi6gumSrIvalRt72z/Kx816tUwt9BZjxVThNnp6kaGyo0nU3j
 3PUi0rvlZKXu+7CrW0/PBtJDkTJjVt3tkFU+HWV1HnGZfccwM07dwDqshD0XGAGCor
 R7Fs108WnSzw2GTZDHNFHdIx8S9N3rVALIhly96SHgPVr7dfKcd4j8QZRD4wOkO8oz
 RPfm1ouAMFSew==
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 
X-CRM114-CacheID: sfid-20201007_163309_130609_08A9F49A 
X-CRM114-Status: GOOD (  27.33  )
X-BeenThere: linux-arm-kernel@lists.infradead.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <linux-arm-kernel.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, 
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, 
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
Cc: linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
 Jan Kara <jack@suse.cz>, Joonyoung Shim <jy0922.shim@samsung.com>,
 kvm@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>, Seung-Woo
 Kim <sw0312.kim@samsung.com>,
 =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
 Krzysztof Kozlowski <krzk@kernel.org>, Inki Dae <inki.dae@samsung.com>,
 linux-mm@kvack.org, Kyungmin Park <kyungmin.park@samsung.com>,
 Kukjin Kim <kgene@kernel.org>, Daniel Vetter <daniel.vetter@intel.com>, Andrew
 Morton <akpm@linux-foundation.org>, Dan Williams <dan.j.williams@intel.com>,
 linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org
Content-Transfer-Encoding: base64
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org

T24gMTAvNy8yMCA5OjQ0IEFNLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+IEFsbCB3ZSBuZWVkIGFy
ZSBhIHBhZ2VzIGFycmF5LCBwaW5fdXNlcl9wYWdlc19mYXN0IGNhbiBnaXZlIHVzIHRoYXQKPiBk
aXJlY3RseS4gUGx1cyB0aGlzIGF2b2lkcyB0aGUgZW50aXJlIHJhdyBwZm4gc2lkZSBvZiBnZXRf
dmFkZHJfZnJhbWVzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52
ZXR0ZXJAaW50ZWwuY29tPgo+IENjOiBKYXNvbiBHdW50aG9ycGUgPGpnZ0B6aWVwZS5jYT4KPiBD
YzogSW5raSBEYWUgPGlua2kuZGFlQHNhbXN1bmcuY29tPgo+IENjOiBKb29ueW91bmcgU2hpbSA8
ankwOTIyLnNoaW1Ac2Ftc3VuZy5jb20+Cj4gQ2M6IFNldW5nLVdvbyBLaW0gPHN3MDMxMi5raW1A
c2Ftc3VuZy5jb20+Cj4gQ2M6IEt5dW5nbWluIFBhcmsgPGt5dW5nbWluLnBhcmtAc2Ftc3VuZy5j
b20+Cj4gQ2M6IEt1a2ppbiBLaW0gPGtnZW5lQGtlcm5lbC5vcmc+Cj4gQ2M6IEtyenlzenRvZiBL
b3psb3dza2kgPGtyemtAa2VybmVsLm9yZz4KPiBDYzogQW5kcmV3IE1vcnRvbiA8YWtwbUBsaW51
eC1mb3VuZGF0aW9uLm9yZz4KPiBDYzogSm9obiBIdWJiYXJkIDxqaHViYmFyZEBudmlkaWEuY29t
Pgo+IENjOiBKw6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0LmNvbT4KPiBDYzogSmFuIEth
cmEgPGphY2tAc3VzZS5jej4KPiBDYzogRGFuIFdpbGxpYW1zIDxkYW4uai53aWxsaWFtc0BpbnRl
bC5jb20+Cj4gQ2M6IGxpbnV4LW1tQGt2YWNrLm9yZwo+IENjOiBsaW51eC1hcm0ta2VybmVsQGxp
c3RzLmluZnJhZGVhZC5vcmcKPiBDYzogbGludXgtc2Ftc3VuZy1zb2NAdmdlci5rZXJuZWwub3Jn
Cj4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZwo+IC0tLQo+ICAgZHJpdmVycy9ncHUv
ZHJtL2V4eW5vcy9LY29uZmlnICAgICAgICAgIHwgIDEgLQo+ICAgZHJpdmVycy9ncHUvZHJtL2V4
eW5vcy9leHlub3NfZHJtX2cyZC5jIHwgNDggKysrKysrKysrKysrLS0tLS0tLS0tLS0tLQo+ICAg
MiBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAyNyBkZWxldGlvbnMoLSkKPiAKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9LY29uZmlnIGIvZHJpdmVycy9ncHUv
ZHJtL2V4eW5vcy9LY29uZmlnCj4gaW5kZXggNjQxN2YzNzRiOTIzLi40MzI1N2VmM2MwOWQgMTAw
NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9LY29uZmlnCj4gKysrIGIvZHJpdmVy
cy9ncHUvZHJtL2V4eW5vcy9LY29uZmlnCj4gQEAgLTg4LDcgKzg4LDYgQEAgY29tbWVudCAiU3Vi
LWRyaXZlcnMiCj4gICBjb25maWcgRFJNX0VYWU5PU19HMkQKPiAgIAlib29sICJHMkQiCj4gICAJ
ZGVwZW5kcyBvbiBWSURFT19TQU1TVU5HX1M1UF9HMkQ9biB8fCBDT01QSUxFX1RFU1QKPiAtCXNl
bGVjdCBGUkFNRV9WRUNUT1IKPiAgIAloZWxwCj4gICAJICBDaG9vc2UgdGhpcyBvcHRpb24gaWYg
eW91IHdhbnQgdG8gdXNlIEV4eW5vcyBHMkQgZm9yIERSTS4KPiAgIAo+IGRpZmYgLS1naXQgYS9k
cml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMgYi9kcml2ZXJzL2dwdS9kcm0v
ZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMKPiBpbmRleCA5NjdhNWNkYzEyMGUuLmM4M2Y2ZmFhYzlk
ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMK
PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMKPiBAQCAtMjA1
LDcgKzIwNSw4IEBAIHN0cnVjdCBnMmRfY21kbGlzdF91c2VycHRyIHsKPiAgIAlkbWFfYWRkcl90
CQlkbWFfYWRkcjsKPiAgIAl1bnNpZ25lZCBsb25nCQl1c2VycHRyOwo+ICAgCXVuc2lnbmVkIGxv
bmcJCXNpemU7Cj4gLQlzdHJ1Y3QgZnJhbWVfdmVjdG9yCSp2ZWM7Cj4gKwlzdHJ1Y3QgcGFnZQkJ
KipwYWdlczsKPiArCXVuc2lnbmVkIGludAkJbnBhZ2VzOwo+ICAgCXN0cnVjdCBzZ190YWJsZQkJ
KnNndDsKPiAgIAlhdG9taWNfdAkJcmVmY291bnQ7Cj4gICAJYm9vbAkJCWluX3Bvb2w7Cj4gQEAg
LTM3OCw3ICszNzksNyBAQCBzdGF0aWMgdm9pZCBnMmRfdXNlcnB0cl9wdXRfZG1hX2FkZHIoc3Ry
dWN0IGcyZF9kYXRhICpnMmQsCj4gICAJCQkJCWJvb2wgZm9yY2UpCj4gICB7Cj4gICAJc3RydWN0
IGcyZF9jbWRsaXN0X3VzZXJwdHIgKmcyZF91c2VycHRyID0gb2JqOwo+IC0Jc3RydWN0IHBhZ2Ug
KipwYWdlczsKPiArCWludCBpOwoKVGhlIGFib3ZlIGxpbmUgY2FuIGFsc28gYmUgZGVsZXRlZCwg
c2VlIGJlbG93LgoKPiAgIAo+ICAgCWlmICghb2JqKQo+ICAgCQlyZXR1cm47Cj4gQEAgLTM5OCwx
NSArMzk5LDExIEBAIHN0YXRpYyB2b2lkIGcyZF91c2VycHRyX3B1dF9kbWFfYWRkcihzdHJ1Y3Qg
ZzJkX2RhdGEgKmcyZCwKPiAgIAlkbWFfdW5tYXBfc2d0YWJsZSh0b19kbWFfZGV2KGcyZC0+ZHJt
X2RldiksIGcyZF91c2VycHRyLT5zZ3QsCj4gICAJCQkgIERNQV9CSURJUkVDVElPTkFMLCAwKTsK
PiAgIAo+IC0JcGFnZXMgPSBmcmFtZV92ZWN0b3JfcGFnZXMoZzJkX3VzZXJwdHItPnZlYyk7Cj4g
LQlpZiAoIUlTX0VSUihwYWdlcykpIHsKPiAtCQlpbnQgaTsKPiArCWZvciAoaSA9IDA7IGkgPCBn
MmRfdXNlcnB0ci0+bnBhZ2VzOyBpKyspCj4gKwkJc2V0X3BhZ2VfZGlydHlfbG9jayhnMmRfdXNl
cnB0ci0+cGFnZXNbaV0pOwo+ICAgCj4gLQkJZm9yIChpID0gMDsgaSA8IGZyYW1lX3ZlY3Rvcl9j
b3VudChnMmRfdXNlcnB0ci0+dmVjKTsgaSsrKQo+IC0JCQlzZXRfcGFnZV9kaXJ0eV9sb2NrKHBh
Z2VzW2ldKTsKPiAtCX0KPiAtCXB1dF92YWRkcl9mcmFtZXMoZzJkX3VzZXJwdHItPnZlYyk7Cj4g
LQlmcmFtZV92ZWN0b3JfZGVzdHJveShnMmRfdXNlcnB0ci0+dmVjKTsKPiArCXVucGluX3VzZXJf
cGFnZXMoZzJkX3VzZXJwdHItPnBhZ2VzLCBnMmRfdXNlcnB0ci0+bnBhZ2VzKTsKPiArCWt2ZnJl
ZShnMmRfdXNlcnB0ci0+cGFnZXMpOwoKWW91IGNhbiBhdm9pZCB3cml0aW5nIHlvdXIgb3duIGxv
b3AsIGFuZCBqdXN0IHNpbXBsaWZ5IHRoZSB3aG9sZSB0aGluZyBkb3duIHRvCnR3byBsaW5lczoK
Cgl1bnBpbl91c2VyX3BhZ2VzX2RpcnR5X2xvY2soZzJkX3VzZXJwdHItPnBhZ2VzLCBnMmRfdXNl
cnB0ci0+bnBhZ2VzLAoJCQkJICAgIHRydWUpOwoJa3ZmcmVlKGcyZF91c2VycHRyLT5wYWdlcyk7
CgoKPiAgIAo+ICAgCWlmICghZzJkX3VzZXJwdHItPm91dF9vZl9saXN0KQo+ICAgCQlsaXN0X2Rl
bF9pbml0KCZnMmRfdXNlcnB0ci0+bGlzdCk7Cj4gQEAgLTQ3NCwzNSArNDcxLDM0IEBAIHN0YXRp
YyBkbWFfYWRkcl90ICpnMmRfdXNlcnB0cl9nZXRfZG1hX2FkZHIoc3RydWN0IGcyZF9kYXRhICpn
MmQsCj4gICAJb2Zmc2V0ID0gdXNlcnB0ciAmIH5QQUdFX01BU0s7Cj4gICAJZW5kID0gUEFHRV9B
TElHTih1c2VycHRyICsgc2l6ZSk7Cj4gICAJbnBhZ2VzID0gKGVuZCAtIHN0YXJ0KSA+PiBQQUdF
X1NISUZUOwo+IC0JZzJkX3VzZXJwdHItPnZlYyA9IGZyYW1lX3ZlY3Rvcl9jcmVhdGUobnBhZ2Vz
KTsKPiAtCWlmICghZzJkX3VzZXJwdHItPnZlYykgewo+ICsJZzJkX3VzZXJwdHItPnBhZ2VzID0g
a3ZtYWxsb2NfYXJyYXkobnBhZ2VzLCBzaXplb2YoKmcyZF91c2VycHRyLT5wYWdlcyksCj4gKwkJ
CQkJICAgIEdGUF9LRVJORUwpOwo+ICsJaWYgKCFnMmRfdXNlcnB0ci0+cGFnZXMpIHsKPiAgIAkJ
cmV0ID0gLUVOT01FTTsKPiAgIAkJZ290byBlcnJfZnJlZTsKPiAgIAl9Cj4gICAKPiAtCXJldCA9
IGdldF92YWRkcl9mcmFtZXMoc3RhcnQsIG5wYWdlcywgRk9MTF9GT1JDRSB8IEZPTExfV1JJVEUs
Cj4gLQkJZzJkX3VzZXJwdHItPnZlYyk7Cj4gKwlyZXQgPSBwaW5fdXNlcl9wYWdlc19mYXN0KHN0
YXJ0LCBucGFnZXMsIEZPTExfRk9SQ0UgfCBGT0xMX1dSSVRFLAo+ICsJCQkJICBnMmRfdXNlcnB0
ci0+cGFnZXMpOwo+ICAgCWlmIChyZXQgIT0gbnBhZ2VzKSB7Cj4gICAJCURSTV9ERVZfRVJST1Io
ZzJkLT5kZXYsCj4gICAJCQkgICAgICAiZmFpbGVkIHRvIGdldCB1c2VyIHBhZ2VzIGZyb20gdXNl
cnB0ci5cbiIpOwo+ICAgCQlpZiAocmV0IDwgMCkKPiAtCQkJZ290byBlcnJfZGVzdHJveV9mcmFt
ZXZlYzsKPiAtCQlyZXQgPSAtRUZBVUxUOwo+IC0JCWdvdG8gZXJyX3B1dF9mcmFtZXZlYzsKPiAt
CX0KPiAtCWlmIChmcmFtZV92ZWN0b3JfdG9fcGFnZXMoZzJkX3VzZXJwdHItPnZlYykgPCAwKSB7
Cj4gKwkJCWdvdG8gZXJyX2Rlc3Ryb3lfcGFnZXM7Cj4gKwkJbnBhZ2VzID0gcmV0Owo+ICAgCQly
ZXQgPSAtRUZBVUxUOwo+IC0JCWdvdG8gZXJyX3B1dF9mcmFtZXZlYzsKPiArCQlnb3RvIGVycl91
bnBpbl9wYWdlczsKPiAgIAl9Cj4gKwlnMmRfdXNlcnB0ci0+bnBhZ2VzID0gbnBhZ2VzOwo+ICAg
Cj4gICAJc2d0ID0ga3phbGxvYyhzaXplb2YoKnNndCksIEdGUF9LRVJORUwpOwo+ICAgCWlmICgh
c2d0KSB7Cj4gICAJCXJldCA9IC1FTk9NRU07Cj4gLQkJZ290byBlcnJfcHV0X2ZyYW1ldmVjOwo+
ICsJCWdvdG8gZXJyX3VucGluX3BhZ2VzOwo+ICAgCX0KPiAgIAo+ICAgCXJldCA9IHNnX2FsbG9j
X3RhYmxlX2Zyb21fcGFnZXMoc2d0LAo+IC0JCQkJCWZyYW1lX3ZlY3Rvcl9wYWdlcyhnMmRfdXNl
cnB0ci0+dmVjKSwKPiArCQkJCQlnMmRfdXNlcnB0ci0+cGFnZXMsCj4gICAJCQkJCW5wYWdlcywg
b2Zmc2V0LCBzaXplLCBHRlBfS0VSTkVMKTsKPiAgIAlpZiAocmV0IDwgMCkgewo+ICAgCQlEUk1f
REVWX0VSUk9SKGcyZC0+ZGV2LCAiZmFpbGVkIHRvIGdldCBzZ3QgZnJvbSBwYWdlcy5cbiIpOwo+
IEBAIC01MzgsMTEgKzUzNCwxMSBAQCBzdGF0aWMgZG1hX2FkZHJfdCAqZzJkX3VzZXJwdHJfZ2V0
X2RtYV9hZGRyKHN0cnVjdCBnMmRfZGF0YSAqZzJkLAo+ICAgZXJyX2ZyZWVfc2d0Ogo+ICAgCWtm
cmVlKHNndCk7Cj4gICAKPiAtZXJyX3B1dF9mcmFtZXZlYzoKPiAtCXB1dF92YWRkcl9mcmFtZXMo
ZzJkX3VzZXJwdHItPnZlYyk7Cj4gK2Vycl91bnBpbl9wYWdlczoKPiArCXVucGluX3VzZXJfcGFn
ZXMoZzJkX3VzZXJwdHItPnBhZ2VzLCBucGFnZXMpOwo+ICAgCj4gLWVycl9kZXN0cm95X2ZyYW1l
dmVjOgo+IC0JZnJhbWVfdmVjdG9yX2Rlc3Ryb3koZzJkX3VzZXJwdHItPnZlYyk7Cj4gK2Vycl9k
ZXN0cm95X3BhZ2VzOgo+ICsJa3ZmcmVlKGcyZF91c2VycHRyLT5wYWdlcyk7Cj4gICAKPiAgIGVy
cl9mcmVlOgo+ICAgCWtmcmVlKGcyZF91c2VycHRyKTsKPiAKClRoZSByZXN0IGFsbCBsb29rcyBn
b29kLCB5b3UndmUgYXZvaWRlZCB0aGUgdXN1YWwgQVBJIHBpdGZhbGxzLiA6KQoKdGhhbmtzLAot
LSAKSm9obiBIdWJiYXJkCk5WSURJQQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl
cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt
YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=iJ/Y=DO=lists.freedesktop.org=dri-devel-bounces@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID,
	DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,
	NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,
	USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 84596C4727E
	for <dri-devel@archiver.kernel.org>; Wed,  7 Oct 2020 20:33:09 +0000 (UTC)
Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id 090AA2083B
	for <dri-devel@archiver.kernel.org>; Wed,  7 Oct 2020 20:33:08 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="bGis6r8C"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 090AA2083B
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org
Received: from gabe.freedesktop.org (localhost [127.0.0.1])
	by gabe.freedesktop.org (Postfix) with ESMTP id 26CF46E9AA;
	Wed,  7 Oct 2020 20:33:08 +0000 (UTC)
Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com
 [216.228.121.64])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 06EEC6E9AA
 for <dri-devel@lists.freedesktop.org>; Wed,  7 Oct 2020 20:33:06 +0000 (UTC)
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by
 hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
 id <B5f7e25ca0000>; Wed, 07 Oct 2020 13:32:10 -0700
Received: from [10.2.85.86] (172.20.13.39) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 7 Oct
 2020 20:32:56 +0000
Subject: Re: [PATCH 01/13] drm/exynos: Stop using frame_vector helpers
To: Daniel Vetter <daniel.vetter@ffwll.ch>, DRI Development
 <dri-devel@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org>
References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch>
 <20201007164426.1812530-2-daniel.vetter@ffwll.ch>
From: John Hubbard <jhubbard@nvidia.com>
Message-ID: <80718789-b3de-c30a-03c5-7c8cbf41f7d9@nvidia.com>
Date: Wed, 7 Oct 2020 13:32:55 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201007164426.1812530-2-daniel.vetter@ffwll.ch>
Content-Language: en-US
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
 t=1602102730; bh=l9BqHF8KWQmaN4RXmMMQ0YcJNLZG1Nf+tEGI/Rd7B58=;
 h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
 MIME-Version:In-Reply-To:Content-Type:Content-Language:
 Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
 b=bGis6r8CEYmrZyavIIA1+AVI5ZOhpqwwr99ccXacmU9iQ3VFTDuM97FlAOqT78Igm
 rCn6vdto1m5+BSCNb/A8nxrfefBagyIX9EjaXmATUsXTn9akCKaOpm6guzuSkTwIzf
 IpnyPYT00yPR0jTRCgi6gumSrIvalRt72z/Kx816tUwt9BZjxVThNnp6kaGyo0nU3j
 3PUi0rvlZKXu+7CrW0/PBtJDkTJjVt3tkFU+HWV1HnGZfccwM07dwDqshD0XGAGCor
 R7Fs108WnSzw2GTZDHNFHdIx8S9N3rVALIhly96SHgPVr7dfKcd4j8QZRD4wOkO8oz
 RPfm1ouAMFSew==
X-BeenThere: dri-devel@lists.freedesktop.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Direct Rendering Infrastructure - Development
 <dri-devel.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Cc: linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
 Jan Kara <jack@suse.cz>, Joonyoung Shim <jy0922.shim@samsung.com>,
 kvm@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>, Seung-Woo
 Kim <sw0312.kim@samsung.com>,
 =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
 Krzysztof Kozlowski <krzk@kernel.org>, linux-mm@kvack.org,
 Kyungmin Park <kyungmin.park@samsung.com>, Kukjin Kim <kgene@kernel.org>,
 Daniel Vetter <daniel.vetter@intel.com>, Andrew
 Morton <akpm@linux-foundation.org>, Dan Williams <dan.j.williams@intel.com>,
 linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org
Content-Transfer-Encoding: base64
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>

T24gMTAvNy8yMCA5OjQ0IEFNLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+IEFsbCB3ZSBuZWVkIGFy
ZSBhIHBhZ2VzIGFycmF5LCBwaW5fdXNlcl9wYWdlc19mYXN0IGNhbiBnaXZlIHVzIHRoYXQKPiBk
aXJlY3RseS4gUGx1cyB0aGlzIGF2b2lkcyB0aGUgZW50aXJlIHJhdyBwZm4gc2lkZSBvZiBnZXRf
dmFkZHJfZnJhbWVzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52
ZXR0ZXJAaW50ZWwuY29tPgo+IENjOiBKYXNvbiBHdW50aG9ycGUgPGpnZ0B6aWVwZS5jYT4KPiBD
YzogSW5raSBEYWUgPGlua2kuZGFlQHNhbXN1bmcuY29tPgo+IENjOiBKb29ueW91bmcgU2hpbSA8
ankwOTIyLnNoaW1Ac2Ftc3VuZy5jb20+Cj4gQ2M6IFNldW5nLVdvbyBLaW0gPHN3MDMxMi5raW1A
c2Ftc3VuZy5jb20+Cj4gQ2M6IEt5dW5nbWluIFBhcmsgPGt5dW5nbWluLnBhcmtAc2Ftc3VuZy5j
b20+Cj4gQ2M6IEt1a2ppbiBLaW0gPGtnZW5lQGtlcm5lbC5vcmc+Cj4gQ2M6IEtyenlzenRvZiBL
b3psb3dza2kgPGtyemtAa2VybmVsLm9yZz4KPiBDYzogQW5kcmV3IE1vcnRvbiA8YWtwbUBsaW51
eC1mb3VuZGF0aW9uLm9yZz4KPiBDYzogSm9obiBIdWJiYXJkIDxqaHViYmFyZEBudmlkaWEuY29t
Pgo+IENjOiBKw6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0LmNvbT4KPiBDYzogSmFuIEth
cmEgPGphY2tAc3VzZS5jej4KPiBDYzogRGFuIFdpbGxpYW1zIDxkYW4uai53aWxsaWFtc0BpbnRl
bC5jb20+Cj4gQ2M6IGxpbnV4LW1tQGt2YWNrLm9yZwo+IENjOiBsaW51eC1hcm0ta2VybmVsQGxp
c3RzLmluZnJhZGVhZC5vcmcKPiBDYzogbGludXgtc2Ftc3VuZy1zb2NAdmdlci5rZXJuZWwub3Jn
Cj4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZwo+IC0tLQo+ICAgZHJpdmVycy9ncHUv
ZHJtL2V4eW5vcy9LY29uZmlnICAgICAgICAgIHwgIDEgLQo+ICAgZHJpdmVycy9ncHUvZHJtL2V4
eW5vcy9leHlub3NfZHJtX2cyZC5jIHwgNDggKysrKysrKysrKysrLS0tLS0tLS0tLS0tLQo+ICAg
MiBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAyNyBkZWxldGlvbnMoLSkKPiAKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9LY29uZmlnIGIvZHJpdmVycy9ncHUv
ZHJtL2V4eW5vcy9LY29uZmlnCj4gaW5kZXggNjQxN2YzNzRiOTIzLi40MzI1N2VmM2MwOWQgMTAw
NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9LY29uZmlnCj4gKysrIGIvZHJpdmVy
cy9ncHUvZHJtL2V4eW5vcy9LY29uZmlnCj4gQEAgLTg4LDcgKzg4LDYgQEAgY29tbWVudCAiU3Vi
LWRyaXZlcnMiCj4gICBjb25maWcgRFJNX0VYWU5PU19HMkQKPiAgIAlib29sICJHMkQiCj4gICAJ
ZGVwZW5kcyBvbiBWSURFT19TQU1TVU5HX1M1UF9HMkQ9biB8fCBDT01QSUxFX1RFU1QKPiAtCXNl
bGVjdCBGUkFNRV9WRUNUT1IKPiAgIAloZWxwCj4gICAJICBDaG9vc2UgdGhpcyBvcHRpb24gaWYg
eW91IHdhbnQgdG8gdXNlIEV4eW5vcyBHMkQgZm9yIERSTS4KPiAgIAo+IGRpZmYgLS1naXQgYS9k
cml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMgYi9kcml2ZXJzL2dwdS9kcm0v
ZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMKPiBpbmRleCA5NjdhNWNkYzEyMGUuLmM4M2Y2ZmFhYzlk
ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMK
PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMKPiBAQCAtMjA1
LDcgKzIwNSw4IEBAIHN0cnVjdCBnMmRfY21kbGlzdF91c2VycHRyIHsKPiAgIAlkbWFfYWRkcl90
CQlkbWFfYWRkcjsKPiAgIAl1bnNpZ25lZCBsb25nCQl1c2VycHRyOwo+ICAgCXVuc2lnbmVkIGxv
bmcJCXNpemU7Cj4gLQlzdHJ1Y3QgZnJhbWVfdmVjdG9yCSp2ZWM7Cj4gKwlzdHJ1Y3QgcGFnZQkJ
KipwYWdlczsKPiArCXVuc2lnbmVkIGludAkJbnBhZ2VzOwo+ICAgCXN0cnVjdCBzZ190YWJsZQkJ
KnNndDsKPiAgIAlhdG9taWNfdAkJcmVmY291bnQ7Cj4gICAJYm9vbAkJCWluX3Bvb2w7Cj4gQEAg
LTM3OCw3ICszNzksNyBAQCBzdGF0aWMgdm9pZCBnMmRfdXNlcnB0cl9wdXRfZG1hX2FkZHIoc3Ry
dWN0IGcyZF9kYXRhICpnMmQsCj4gICAJCQkJCWJvb2wgZm9yY2UpCj4gICB7Cj4gICAJc3RydWN0
IGcyZF9jbWRsaXN0X3VzZXJwdHIgKmcyZF91c2VycHRyID0gb2JqOwo+IC0Jc3RydWN0IHBhZ2Ug
KipwYWdlczsKPiArCWludCBpOwoKVGhlIGFib3ZlIGxpbmUgY2FuIGFsc28gYmUgZGVsZXRlZCwg
c2VlIGJlbG93LgoKPiAgIAo+ICAgCWlmICghb2JqKQo+ICAgCQlyZXR1cm47Cj4gQEAgLTM5OCwx
NSArMzk5LDExIEBAIHN0YXRpYyB2b2lkIGcyZF91c2VycHRyX3B1dF9kbWFfYWRkcihzdHJ1Y3Qg
ZzJkX2RhdGEgKmcyZCwKPiAgIAlkbWFfdW5tYXBfc2d0YWJsZSh0b19kbWFfZGV2KGcyZC0+ZHJt
X2RldiksIGcyZF91c2VycHRyLT5zZ3QsCj4gICAJCQkgIERNQV9CSURJUkVDVElPTkFMLCAwKTsK
PiAgIAo+IC0JcGFnZXMgPSBmcmFtZV92ZWN0b3JfcGFnZXMoZzJkX3VzZXJwdHItPnZlYyk7Cj4g
LQlpZiAoIUlTX0VSUihwYWdlcykpIHsKPiAtCQlpbnQgaTsKPiArCWZvciAoaSA9IDA7IGkgPCBn
MmRfdXNlcnB0ci0+bnBhZ2VzOyBpKyspCj4gKwkJc2V0X3BhZ2VfZGlydHlfbG9jayhnMmRfdXNl
cnB0ci0+cGFnZXNbaV0pOwo+ICAgCj4gLQkJZm9yIChpID0gMDsgaSA8IGZyYW1lX3ZlY3Rvcl9j
b3VudChnMmRfdXNlcnB0ci0+dmVjKTsgaSsrKQo+IC0JCQlzZXRfcGFnZV9kaXJ0eV9sb2NrKHBh
Z2VzW2ldKTsKPiAtCX0KPiAtCXB1dF92YWRkcl9mcmFtZXMoZzJkX3VzZXJwdHItPnZlYyk7Cj4g
LQlmcmFtZV92ZWN0b3JfZGVzdHJveShnMmRfdXNlcnB0ci0+dmVjKTsKPiArCXVucGluX3VzZXJf
cGFnZXMoZzJkX3VzZXJwdHItPnBhZ2VzLCBnMmRfdXNlcnB0ci0+bnBhZ2VzKTsKPiArCWt2ZnJl
ZShnMmRfdXNlcnB0ci0+cGFnZXMpOwoKWW91IGNhbiBhdm9pZCB3cml0aW5nIHlvdXIgb3duIGxv
b3AsIGFuZCBqdXN0IHNpbXBsaWZ5IHRoZSB3aG9sZSB0aGluZyBkb3duIHRvCnR3byBsaW5lczoK
Cgl1bnBpbl91c2VyX3BhZ2VzX2RpcnR5X2xvY2soZzJkX3VzZXJwdHItPnBhZ2VzLCBnMmRfdXNl
cnB0ci0+bnBhZ2VzLAoJCQkJICAgIHRydWUpOwoJa3ZmcmVlKGcyZF91c2VycHRyLT5wYWdlcyk7
CgoKPiAgIAo+ICAgCWlmICghZzJkX3VzZXJwdHItPm91dF9vZl9saXN0KQo+ICAgCQlsaXN0X2Rl
bF9pbml0KCZnMmRfdXNlcnB0ci0+bGlzdCk7Cj4gQEAgLTQ3NCwzNSArNDcxLDM0IEBAIHN0YXRp
YyBkbWFfYWRkcl90ICpnMmRfdXNlcnB0cl9nZXRfZG1hX2FkZHIoc3RydWN0IGcyZF9kYXRhICpn
MmQsCj4gICAJb2Zmc2V0ID0gdXNlcnB0ciAmIH5QQUdFX01BU0s7Cj4gICAJZW5kID0gUEFHRV9B
TElHTih1c2VycHRyICsgc2l6ZSk7Cj4gICAJbnBhZ2VzID0gKGVuZCAtIHN0YXJ0KSA+PiBQQUdF
X1NISUZUOwo+IC0JZzJkX3VzZXJwdHItPnZlYyA9IGZyYW1lX3ZlY3Rvcl9jcmVhdGUobnBhZ2Vz
KTsKPiAtCWlmICghZzJkX3VzZXJwdHItPnZlYykgewo+ICsJZzJkX3VzZXJwdHItPnBhZ2VzID0g
a3ZtYWxsb2NfYXJyYXkobnBhZ2VzLCBzaXplb2YoKmcyZF91c2VycHRyLT5wYWdlcyksCj4gKwkJ
CQkJICAgIEdGUF9LRVJORUwpOwo+ICsJaWYgKCFnMmRfdXNlcnB0ci0+cGFnZXMpIHsKPiAgIAkJ
cmV0ID0gLUVOT01FTTsKPiAgIAkJZ290byBlcnJfZnJlZTsKPiAgIAl9Cj4gICAKPiAtCXJldCA9
IGdldF92YWRkcl9mcmFtZXMoc3RhcnQsIG5wYWdlcywgRk9MTF9GT1JDRSB8IEZPTExfV1JJVEUs
Cj4gLQkJZzJkX3VzZXJwdHItPnZlYyk7Cj4gKwlyZXQgPSBwaW5fdXNlcl9wYWdlc19mYXN0KHN0
YXJ0LCBucGFnZXMsIEZPTExfRk9SQ0UgfCBGT0xMX1dSSVRFLAo+ICsJCQkJICBnMmRfdXNlcnB0
ci0+cGFnZXMpOwo+ICAgCWlmIChyZXQgIT0gbnBhZ2VzKSB7Cj4gICAJCURSTV9ERVZfRVJST1Io
ZzJkLT5kZXYsCj4gICAJCQkgICAgICAiZmFpbGVkIHRvIGdldCB1c2VyIHBhZ2VzIGZyb20gdXNl
cnB0ci5cbiIpOwo+ICAgCQlpZiAocmV0IDwgMCkKPiAtCQkJZ290byBlcnJfZGVzdHJveV9mcmFt
ZXZlYzsKPiAtCQlyZXQgPSAtRUZBVUxUOwo+IC0JCWdvdG8gZXJyX3B1dF9mcmFtZXZlYzsKPiAt
CX0KPiAtCWlmIChmcmFtZV92ZWN0b3JfdG9fcGFnZXMoZzJkX3VzZXJwdHItPnZlYykgPCAwKSB7
Cj4gKwkJCWdvdG8gZXJyX2Rlc3Ryb3lfcGFnZXM7Cj4gKwkJbnBhZ2VzID0gcmV0Owo+ICAgCQly
ZXQgPSAtRUZBVUxUOwo+IC0JCWdvdG8gZXJyX3B1dF9mcmFtZXZlYzsKPiArCQlnb3RvIGVycl91
bnBpbl9wYWdlczsKPiAgIAl9Cj4gKwlnMmRfdXNlcnB0ci0+bnBhZ2VzID0gbnBhZ2VzOwo+ICAg
Cj4gICAJc2d0ID0ga3phbGxvYyhzaXplb2YoKnNndCksIEdGUF9LRVJORUwpOwo+ICAgCWlmICgh
c2d0KSB7Cj4gICAJCXJldCA9IC1FTk9NRU07Cj4gLQkJZ290byBlcnJfcHV0X2ZyYW1ldmVjOwo+
ICsJCWdvdG8gZXJyX3VucGluX3BhZ2VzOwo+ICAgCX0KPiAgIAo+ICAgCXJldCA9IHNnX2FsbG9j
X3RhYmxlX2Zyb21fcGFnZXMoc2d0LAo+IC0JCQkJCWZyYW1lX3ZlY3Rvcl9wYWdlcyhnMmRfdXNl
cnB0ci0+dmVjKSwKPiArCQkJCQlnMmRfdXNlcnB0ci0+cGFnZXMsCj4gICAJCQkJCW5wYWdlcywg
b2Zmc2V0LCBzaXplLCBHRlBfS0VSTkVMKTsKPiAgIAlpZiAocmV0IDwgMCkgewo+ICAgCQlEUk1f
REVWX0VSUk9SKGcyZC0+ZGV2LCAiZmFpbGVkIHRvIGdldCBzZ3QgZnJvbSBwYWdlcy5cbiIpOwo+
IEBAIC01MzgsMTEgKzUzNCwxMSBAQCBzdGF0aWMgZG1hX2FkZHJfdCAqZzJkX3VzZXJwdHJfZ2V0
X2RtYV9hZGRyKHN0cnVjdCBnMmRfZGF0YSAqZzJkLAo+ICAgZXJyX2ZyZWVfc2d0Ogo+ICAgCWtm
cmVlKHNndCk7Cj4gICAKPiAtZXJyX3B1dF9mcmFtZXZlYzoKPiAtCXB1dF92YWRkcl9mcmFtZXMo
ZzJkX3VzZXJwdHItPnZlYyk7Cj4gK2Vycl91bnBpbl9wYWdlczoKPiArCXVucGluX3VzZXJfcGFn
ZXMoZzJkX3VzZXJwdHItPnBhZ2VzLCBucGFnZXMpOwo+ICAgCj4gLWVycl9kZXN0cm95X2ZyYW1l
dmVjOgo+IC0JZnJhbWVfdmVjdG9yX2Rlc3Ryb3koZzJkX3VzZXJwdHItPnZlYyk7Cj4gK2Vycl9k
ZXN0cm95X3BhZ2VzOgo+ICsJa3ZmcmVlKGcyZF91c2VycHRyLT5wYWdlcyk7Cj4gICAKPiAgIGVy
cl9mcmVlOgo+ICAgCWtmcmVlKGcyZF91c2VycHRyKTsKPiAKClRoZSByZXN0IGFsbCBsb29rcyBn
b29kLCB5b3UndmUgYXZvaWRlZCB0aGUgdXN1YWwgQVBJIHBpdGZhbGxzLiA6KQoKdGhhbmtzLAot
LSAKSm9obiBIdWJiYXJkCk5WSURJQQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl
ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m
by9kcmktZGV2ZWwK