From: Dongjiu Geng <gengdongjiu@huawei.com>
To: Rob Herring <robh@kernel.org>
Cc: <sboyd@kernel.org>, <mturquette@baylibre.com>,
<robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: Document the hi3559a clock bindings
Date: Mon, 16 Nov 2020 23:22:22 +0800 [thread overview]
Message-ID: <8071c22d-1a9f-6353-7dd0-026de6e465de@huawei.com> (raw)
In-Reply-To: <20201116150223.GA1645329@bogus>
On 2020/11/16 23:02, Rob Herring wrote:
> On Sat, 14 Nov 2020 00:22:36 +0000, Dongjiu Geng wrote:
>> Add DT bindings documentation for hi3559a SoC clock.
>>
>> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
>> ---
>> .../clock/hisilicon,hi3559av100-clock.yaml | 65 +++++++
>> include/dt-bindings/clock/hi3559av100-clock.h | 165 ++++++++++++++++++
>> 2 files changed, 230 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.yaml
>> create mode 100644 include/dt-bindings/clock/hi3559av100-clock.h
>>
>
>
> My bot found errors running 'make dt_binding_check' on your patch
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.example.dts:20.23-27.11: Warning (unit_address_vs_reg): /example-0/clock0: node has a reg or ranges property, but no unit name
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.example.dt.yaml: clock0: compatible: ['hisilicon,hi3559av100-clock', 'syscon'] is too long
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.example.dt.yaml: clock0: compatible: Additional items are not allowed ('syscon' was unexpected)
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.example.dt.yaml: clock0: #reset-cells:0:0: 1 was expected
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/hisilicon,hi3559av100-clock.yaml
>
>
> See https://patchwork.ozlabs.org/patch/1399891
>
> The base for the patch is generally the last rc1. Any dependencies
> should be noted.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
ok， thanks a lot for the reminder.
>
> .
>
next prev parent reply other threads:[~2020-11-16 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 0:22 [PATCH v3 0/2] Enable Hi3559A SOC clock Dongjiu Geng
2020-11-14 0:22 ` [PATCH v3 1/2] dt-bindings: Document the hi3559a clock bindings Dongjiu Geng
2020-11-16 15:02 ` Rob Herring
2020-11-16 15:22 ` Dongjiu Geng [this message]
2020-11-14 0:22 ` [PATCH v3 2/2] clk: hisilicon: Add clock driver for hi3559A SoC Dongjiu Geng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8071c22d-1a9f-6353-7dd0-026de6e465de@huawei.com \
--to=gengdongjiu@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.